February 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: restapi + engine : handle scenarios for graphicsconsoles APIs
by Code Review 02 Feb '17

02 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: restapi + engine : handle scenarios for graphicsconsoles APIs ...................................................................... restapi + engine : handle scenarios for graphicsconsoles APIs When using /graphicsconsoles REST apis for deleting or adding a graphic device to an existing VM, there are cases that the VM is left after the operation with no graphic devices (all was removed) but with a video device OR lest with one graphic devide (which was added to a headless VM) and no video device. This patch handle all those senrois for the /graphicsconsoles APIS (GET, POST, DELETE) such that in case the last graphic device was removed-the video device also removed and the entity becomes headless. and also in case the first graphic device is added to a headless entity, a "QXL" video device is also added. Those changes are relevant for VMs, Templates and Instance-types: e.g. for adding a graphic device: POST ..api/instancetypes/<instancetype-id>/graphicsconsoles <graphics_console> <protocol>spice</protocol> </graphics_console> POST ..api/templates/<template-id>/graphicsconsoles ... POST ..api/vms/<vm-id>/graphicsconsoles ... For removing a graphic device: DELETE ..api/instancetypes/<instancetype-id>/graphicsconsoles/<console-id> DELETE ..api/templates/<template-id>/graphicsconsoles/<console-id> DELETE ..api/vms/<vm-id>/graphicsconsoles/<console-id> Change-Id: I15d94b31d91d51b0319af9100fcb45f1e1984ad8 Bug-Url: https://bugzilla.redhat.com/1414086 Signed-off-by: Sharon Gratch <sgratch(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractGraphicsDeviceCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsAndVideoDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddGraphicsDeviceCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveGraphicsAndVideoDevicesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendGraphicsConsoleHelper.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendInstanceTypeGraphicsConsolesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplateGraphicsConsolesResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmGraphicsConsolesResource.java 10 files changed, 159 insertions(+), 8 deletions(-) Approvals: Juan Hernandez: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Sharon Gratch: Verified Arik Hadas: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71476 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15d94b31d91d51b0319af9100fcb45f1e1984ad8 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Sharon Gratch <sgratch(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-hosted-engine-setup[master]: hc-gluster: optionally enabling the gluster service
by Code Review 02 Feb '17

02 Feb '17

>From Simone Tiraboschi <stirabos(a)redhat.com>: Simone Tiraboschi has submitted this change and it was merged. Change subject: hc-gluster: optionally enabling the gluster service ...................................................................... hc-gluster: optionally enabling the gluster service Optionally enabling the gluster service on the host and its cluster. This will initially open the required ports on the host and will set the gluster service as enabled in the engine for the specific cluster. Change-Id: Ic8102189d607bd9bbe48ff8fc0fbce5cd3db6bc0 Bug-Url: https://bugzilla.redhat.com/1288979 Signed-off-by: Simone Tiraboschi <stirabos(a)redhat.com> --- M src/ovirt_hosted_engine_setup/constants.py M src/plugins/gr-he-setup/engine/add_host.py M src/plugins/gr-he-setup/network/firewall.py M src/plugins/gr-he-setup/network/firewall_manager.py M src/plugins/gr-he-setup/storage/nfs.py M src/plugins/gr-he-setup/storage/storage.py M templates/Makefile.am A templates/hosted-gluster.xml.in 8 files changed, 122 insertions(+), 1 deletion(-) Approvals: Sandro Bonazzola: Looks good to me, but someone else must approve Simone Tiraboschi: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/70685 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8102189d607bd9bbe48ff8fc0fbce5cd3db6bc0 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-hosted-engine-setup Gerrit-Branch: master Gerrit-Owner: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Ramesh N <rnachimu(a)redhat.com> Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: core: treat template's actual disk size as editable field
by Code Review 02 Feb '17

02 Feb '17

>From Piotr Kliczewski <piotr.kliczewski(a)gmail.com>: Piotr Kliczewski has submitted this change and it was merged. Change subject: core: treat template's actual disk size as editable field ...................................................................... core: treat template's actual disk size as editable field This field is not being set anyway (it is generated from the template's disks) so there is no problem in setting it as editable just for the reflection-based validation to pass on update template. Proper fix, however, will be to remove the actual disks size from the template. Change-Id: I216ca19c1a060e0931390d681da8217da316a00a Bug-Url: https://bugzilla.redhat.com/1417597 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71566 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I216ca19c1a060e0931390d681da8217da316a00a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: engine: Can not add power management to the host, when the h...
by Code Review 02 Feb '17

02 Feb '17

>From Moti Asayag <masayag(a)redhat.com>: Moti Asayag has submitted this change and it was merged. Change subject: engine: Can not add power management to the host, when the host has state 'UP' ...................................................................... engine: Can not add power management to the host, when the host has state 'UP' PowerManagement should be editable even when host is not in Maintenance mode. Regression caused by incomplete cleanup by commit I01cbfabc515f9bcfff875 Change-Id: Ic391bb00847903718a0a9436476ff93ebac190d9 Bug-Url: https://bugzilla.redhat.com/1416845 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/hostdeploy/UpdateVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/UpdateHostValidator.java 2 files changed, 0 insertions(+), 7 deletions(-) Approvals: Piotr Kliczewski: Looks good to me, but someone else must approve Ravi Nori: Verified Jenkins CI: Passed CI tests Moti Asayag: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/71546 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic391bb00847903718a0a9436476ff93ebac190d9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: treat template's actual disk size as editable field
by Code Review 02 Feb '17

02 Feb '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. Change subject: core: treat template's actual disk size as editable field ...................................................................... core: treat template's actual disk size as editable field This field is not being set anyway (it is generated from the template's disks) so there is no problem in setting it as editable just for the reflection-based validation to pass on update template. Proper fix, however, will be to remove the actual disks size from the template. Change-Id: I216ca19c1a060e0931390d681da8217da316a00a Bug-Url: https://bugzilla.redhat.com/1417597 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmTemplate.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/71561 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I216ca19c1a060e0931390d681da8217da316a00a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Add VNC console example
by Code Review 02 Feb '17

02 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add VNC console example ...................................................................... Add VNC console example This patch adds an example that shows how to add a VNC graphics console to a virtual machine. Change-Id: I96ffbff0d3815d3f142aeddd3d9809da1e6073bf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 0fe3ae66d9b9460a675eae00079e5cf11ce083f6) (cherry picked from commit 2d7ede3075564cd3abe477b1bbd3dd13dd4ff0d0) --- A sdk/examples/add_vnc_console.rb 1 file changed, 54 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71560 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96ffbff0d3815d3f142aeddd3d9809da1e6073bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.1]: Add VNC console example
by Code Review 02 Feb '17

02 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add VNC console example ...................................................................... Add VNC console example This patch adds an example that shows how to add a VNC graphics console to a virtual machine. Change-Id: I96ffbff0d3815d3f142aeddd3d9809da1e6073bf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 0fe3ae66d9b9460a675eae00079e5cf11ce083f6) --- A sdk/examples/add_vnc_console.rb 1 file changed, 54 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71559 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96ffbff0d3815d3f142aeddd3d9809da1e6073bf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[master]: Add VNC console example
by Code Review 02 Feb '17

02 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Add VNC console example ...................................................................... Add VNC console example This patch adds an example that shows how to add a VNC graphics console to a virtual machine. Change-Id: I96ffbff0d3815d3f142aeddd3d9809da1e6073bf Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_vnc_console.rb 1 file changed, 54 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71505 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I96ffbff0d3815d3f142aeddd3d9809da1e6073bf Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk-ruby[sdk_4.0]: Use 'Integer' instead of 'Fixnum'
by Code Review 02 Feb '17

02 Feb '17

>From Juan Hernandez <juan.hernandez(a)redhat.com>: Juan Hernandez has submitted this change and it was merged. Change subject: Use 'Integer' instead of 'Fixnum' ...................................................................... Use 'Integer' instead of 'Fixnum' Version 2.4 of Ruby unified the integer types into one single 'Integer' type. This patch adapts the SDK so that it uses it (mostly for documentation). Change-Id: Ie9c4b445c4f9f07184008c301b01f4f6ce0dfdd9 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> (cherry picked from commit 2a2b58ba3d64b2363a6339946ac7d23df2540c1f) --- M generator/src/main/java/org/ovirt/sdk/ruby/YardDoc.java M sdk/lib/ovirtsdk4/reader.rb M sdk/lib/ovirtsdk4/writer.rb M sdk/spec/reader_spec.rb 4 files changed, 7 insertions(+), 7 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/71432 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie9c4b445c4f9f07184008c301b01f4f6ce0dfdd9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk-ruby Gerrit-Branch: sdk_4.0 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine-sdk[master]: Add VNC console example
by Code Review 02 Feb '17

02 Feb '17

>From Ondra Machacek <omachace(a)redhat.com>: Ondra Machacek has submitted this change and it was merged. Change subject: Add VNC console example ...................................................................... Add VNC console example This patch adds an example that shows how to add a VNC graphics console to a virtual machine. Change-Id: Ic726a5e66fb278e4fce34681961291641518b39f Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- A sdk/examples/add_vnc_console.py 1 file changed, 62 insertions(+), 0 deletions(-) Approvals: Ondra Machacek: Looks good to me, approved Juan Hernandez: Verified Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/71504 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic726a5e66fb278e4fce34681961291641518b39f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ondra Machacek <omachace(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0