August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: build: Remove vdsbroker's tests' additional config
by Code Review 22 Aug '17

22 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80878 ) Change subject: build: Remove vdsbroker's tests' additional config ...................................................................... build: Remove vdsbroker's tests' additional config The additional configuration of the maven-surefire-plugin is a remnant from the 3.1 days, and is no longer relevant. At best, it's redundant, and at worst, it actually fails the build with the early access Java 9. Change-Id: I7bbed9deff019c0b1dc89584fbe34ba13bd74deb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/vdsbroker/pom.xml 1 file changed, 0 insertions(+), 16 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80878 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7bbed9deff019c0b1dc89584fbe34ba13bd74deb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: build: Remove classpath conf from bll tests
by Code Review 22 Aug '17

22 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80879 ) Change subject: build: Remove classpath conf from bll tests ...................................................................... build: Remove classpath conf from bll tests The additional classpath and endorsed jars in BLL's tests are remnants from oVirt 3.1, and are no longer needed. At best, they're redundant, and at worst they break the build with the early access Java 9. Change-Id: I3bc919d2d04b183c94785937c53434262c5ab56e Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/pom.xml 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Martin Peřina: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Allon Mureinik: Verified; Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80879 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3bc919d2d04b183c94785937c53434262c5ab56e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Martin Peřina <mperina(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in jenkins[master]: Fix small bug in slave repo setup
by Code Review 22 Aug '17

22 Aug '17

>From Barak Korren <bkorren(a)redhat.com>: Barak Korren has submitted this change and it was merged. ( https://gerrit.ovirt.org/80877 ) Change subject: Fix small bug in slave repo setup ...................................................................... Fix small bug in slave repo setup Bug causes configuration code to run on each job and not only when needed Change-Id: Ifc8eab468cf67798d2d172ee58585c9f1ad3fca8 Signed-off-by: Barak Korren <bkorren(a)redhat.com> --- M jobs/confs/shell-scripts/global_setup.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Barak Korren: Verified; Looks good to me, approved; Ready for merge Gil Shinar: Looks good to me Daniel Belenky: Looks good to me Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80877 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc8eab468cf67798d2d172ee58585c9f1ad3fca8 Gerrit-PatchSet: 1 Gerrit-Project: jenkins Gerrit-Branch: master Gerrit-Owner: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Anton Marchukov <amarchuk(a)redhat.com> Gerrit-Reviewer: Barak Korren <bkorren(a)redhat.com> Gerrit-Reviewer: Daniel Belenky <dbelenky(a)redhat.com> Gerrit-Reviewer: Evgheni Dereveanchin <ederevea(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Gil Shinar <gshinar(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Nadav Goldin <ngoldin(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Shlomo Ben David <sbendavi(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: inventory: Detect if env is Hosted Engine
by Code Review 22 Aug '17

22 Aug '17

>From Douglas Schilling Landgraf <dougsland(a)redhat.com>: Douglas Schilling Landgraf has submitted this change and it was merged. ( https://gerrit.ovirt.org/80875 ) Change subject: inventory: Detect if env is Hosted Engine ...................................................................... inventory: Detect if env is Hosted Engine Change-Id: I270c658e45e3484a165bf2616a423cbdcf84a76f Signed-off-by: Douglas Schilling Landgraf <dougsland(a)redhat.com> --- M src/inventory_report/Makefile.am M src/inventory_report/produceReport/pre-upgrade-checks M src/inventory_report/produceReport/produceReport.sh A src/inventory_report/produceReport/sqls/vdc_options_query_detect_hosted_engine_env.sql 4 files changed, 44 insertions(+), 12 deletions(-) Approvals: Douglas Schilling Landgraf: Verified; Looks good to me, approved Simone Tiraboschi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80875 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I270c658e45e3484a165bf2616a423cbdcf84a76f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: report io errors to guests for cd-rom devices
by Code Review 22 Aug '17

22 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80007 ) Change subject: core: report io errors to guests for cd-rom devices ...................................................................... core: report io errors to guests for cd-rom devices Use error_policy='report' for cd-rom devices. Change-Id: I62ff73048cd5bef59a7c3236fcc8c91b0254a660 Bug-Url: https://bugzilla.redhat.com/1207992 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/LibvirtVmXmlBuilder.java 1 file changed, 13 insertions(+), 1 deletion(-) Approvals: Jenkins CI: Passed CI tests Francesco Romani: Looks good to me, but someone else must approve Arik Hadas: Verified; Looks good to me, approved Michal Skrivanek: Looks good to me, but someone else must approve Milan Zamazal: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80007 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62ff73048cd5bef59a7c3236fcc8c91b0254a660 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com> Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: branding: rename some branding classes and images
by Code Review 22 Aug '17

22 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80762 ) Change subject: branding: rename some branding classes and images ...................................................................... branding: rename some branding classes and images Rename some branding classes and images for clarity. Change-Id: Ib495a1326417801c7b5fad66050cc119e03f9e62 Signed-off-by: Greg Sheremeta <gshereme(a)redhat.com> --- M backend/manager/modules/docs/src/main/webapp/WEB-INF/no_lang.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/credentialsChange.jsp M backend/manager/modules/enginesso/src/main/webapp/WEB-INF/login.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/404.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/405.jsp M backend/manager/modules/welcome/src/main/webapp/WEB-INF/ovirt-engine.jsp R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_landing_bg_bottom_left.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_landing_bg_top_right.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_logo.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_middle_logo.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_webadmin_about_bg.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_webadmin_masthead_bg.png R frontend/brands/ovirt-brand/src/main/resources/images/ovirt_webadmin_masthead_logo.png M frontend/brands/ovirt-brand/src/main/sass/_branding_common.scss M frontend/brands/ovirt-brand/src/main/sass/_branding_webadmin.scss M frontend/brands/ovirt-brand/src/main/sass/_ovirt-patternfly-compat.scss M frontend/brands/ovirt-brand/src/main/sass/_ovirt.scss M frontend/brands/ovirt-brand/src/main/sass/_welcome_base.scss M frontend/brands/ovirt-brand/src/main/sass/webadmin.scss M frontend/brands/ovirt-brand/src/main/sass/welcome.scss M frontend/webadmin/modules/frontend/src/main/resources/META-INF/resources/GwtHostPage.jsp M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/AboutPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/HeaderView.ui.xml 23 files changed, 95 insertions(+), 95 deletions(-) Approvals: Alexander Wels: Looks good to me, approved Jenkins CI: Passed CI tests Greg Sheremeta: Verified Vojtech Szocs: Looks good to me, but someone else must approve -- To view, visit https://gerrit.ovirt.org/80762 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib495a1326417801c7b5fad66050cc119e03f9e62 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Scott Dickerson <sdickers(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: frontend: Add passthrough column under vNIC profiles sub tab
by Code Review 22 Aug '17

22 Aug '17

>From Greg Sheremeta <gshereme(a)redhat.com>: Greg Sheremeta has submitted this change and it was merged. ( https://gerrit.ovirt.org/80679 ) Change subject: frontend: Add passthrough column under vNIC profiles sub tab ...................................................................... frontend: Add passthrough column under vNIC profiles sub tab Add column for passthrough property in Network -> Networks -> vNIC Profiles. Change width of Port Mirroring column to match vNIC profiles tab table. Change-Id: I33748b410393994a43870ae4b2b7b2a3daa48575 Signed-off-by: Ales Musil <amusil(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/1241410 --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkProfileView.java 1 file changed, 10 insertions(+), 1 deletion(-) Approvals: Ales Musil: Verified Jenkins CI: Passed CI tests Dan Kenigsberg: Looks good to me, but someone else must approve Greg Sheremeta: Looks good to me, approved -- To view, visit https://gerrit.ovirt.org/80679 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I33748b410393994a43870ae4b2b7b2a3daa48575 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Ales Musil <amusil(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: osinfo: update memory requirements for RHEL
by Code Review 22 Aug '17

22 Aug '17

>From Arik Hadas <ahadas(a)redhat.com>: Arik Hadas has submitted this change and it was merged. ( https://gerrit.ovirt.org/80894 ) Change subject: osinfo: update memory requirements for RHEL ...................................................................... osinfo: update memory requirements for RHEL Change-Id: I78ac7e94786517feb7292e9a44b9bb6705b3b75a Bug-Url: https://bugzilla.redhat.com/1428490 Signed-off-by: Michal Skrivanek <michal.skrivanek(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/osinfo/OsRepository.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M packaging/conf/osinfo-defaults.properties 3 files changed, 8 insertions(+), 4 deletions(-) Approvals: Jenkins CI: Passed CI tests Arik Hadas: Looks good to me, approved Michal Skrivanek: Verified -- To view, visit https://gerrit.ovirt.org/80894 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78ac7e94786517feb7292e9a44b9bb6705b3b75a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jakub Niedermertl <jniederm(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: db: disallow file type to be null
by Code Review 22 Aug '17

22 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80693 ) Change subject: db: disallow file type to be null ...................................................................... db: disallow file type to be null Since we assume the image's file type has a concrete value, it can't be null. Change-Id: Ia65236a38b8ef106eab5ec21eeda2a9ae1354212 Signed-off-by: Shani Leviim <sleviim(a)redhat.com> --- A packaging/dbscripts/upgrade/04_02_0490_disallow_file_type_to_be_null.sql 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jenkins CI: Passed CI tests Allon Mureinik: Looks good to me, approved Shani Leviim: Verified -- To view, visit https://gerrit.ovirt.org/80693 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia65236a38b8ef106eab5ec21eeda2a9ae1354212 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shani Leviim <sleviim(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: setup: Use is_secret
by Code Review 22 Aug '17

22 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/79345 ) Change subject: packaging: setup: Use is_secret ...................................................................... packaging: setup: Use is_secret Add secret constants to LOG_FILTER_KEYS by marking them is_secret=True instead of manually. Bug-Url: https://bugzilla.redhat.com/1169099 Change-Id: Ie0c28ad17644b1875b78aa4a02bd2cad92c00971 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/setup/ovirt_engine_setup/constants.py M packaging/setup/ovirt_engine_setup/engine/constants.py M packaging/setup/ovirt_engine_setup/provisiondb/constants.py M packaging/setup/plugins/ovirt-engine-common/base/remote_engine/remote_engine.py M packaging/setup/plugins/ovirt-engine-common/ovirt-engine/db/connection.py M packaging/setup/plugins/ovirt-engine-provisiondb/ovirt-engine-common/provisioning/database.py M packaging/setup/plugins/ovirt-engine-rename/ovirt-engine/pki.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/config/aaa.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/network/ovirtproviderovn.py M packaging/setup/plugins/ovirt-engine-setup/ovirt-engine/pki/ca.py 10 files changed, 22 insertions(+), 73 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved; Passed CI tests Yedidyah Bar David: Verified -- To view, visit https://gerrit.ovirt.org/79345 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0c28ad17644b1875b78aa4a02bd2cad92c00971 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0