August 2017 - Engine-commits - oVirt List Archives

Change in ovirt-engine[ovirt-engine-4.1]: backend: Add updated size validation to vnic profile names.
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80838 ) Change subject: backend: Add updated size validation to vnic profile names. ...................................................................... backend: Add updated size validation to vnic profile names. Maximum allowed vnic profile name size is now 256 characters; it is not completely unlimited. Re-add size validation with the new appropriate size (256). Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477161 Change-Id: I312e63f294a42ee0010a26eb62ce05c76ef00496 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/VnicProfile.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80838 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I312e63f294a42ee0010a26eb62ce05c76ef00496 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: dbscripts: Increase vnic_profile's name column to...
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80811 ) Change subject: packaging: dbscripts: Increase vnic_profile's name column to 256 bytes. ...................................................................... packaging: dbscripts: Increase vnic_profile's name column to 256 bytes. By default vnic profiles are named after its underlying network. With the recent change to network names where networks are no longer restricted to 15 ASCII characters, vnic profile names must follow suit. Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477569 Change-Id: I73dcabb3fd9404dc2802121d402e2c79fd5c8a75 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_01_0870_increase_vnic_profile_name_size.sql 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Passed CI tests Alona Kaplan: Looks good to me, approved Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80811 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73dcabb3fd9404dc2802121d402e2c79fd5c8a75 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: replace network name with vdsm name when needed
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80813 ) Change subject: backend: replace network name with vdsm name when needed ...................................................................... backend: replace network name with vdsm name when needed In a scenario where a network with a long name is removed or detached from a cluster, detaching the network (which is now unmanaged) from hosts will be impossible as mapping network name to vdsm name is no longer possible. To remedy this, on network removal, replace network_name in vds_interface from network name to vdsm name in each interface where the removed network is attached to in the datacenter or cluster. Change-Id: I93fca4940deae3bff497c85fcaf46e1a87f07c02 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478790 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/DetachNetworkFromClusterInternalCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/cluster/NetworkHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/dc/RemoveNetworkCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDao.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/network/InterfaceDaoImpl.java 5 files changed, 35 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80813 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I93fca4940deae3bff497c85fcaf46e1a87f07c02 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: pass vdsm name over network name to vmInfo
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80812 ) Change subject: backend: pass vdsm name over network name to vmInfo ...................................................................... backend: pass vdsm name over network name to vmInfo The actual interface's name libvirt needs to make use of is vdsm_name and not the network's name which is to be used by engine. Pass vdsm_name to vmInfo instead of network name. Change-Id: Ie53dcf8cc81da8cb83b42d215e753f40cf1b727a Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478806 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/builder/vminfo/VmInfoBuildUtils.java 1 file changed, 6 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Passed CI tests Alona Kaplan: Looks good to me, approved Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80812 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie53dcf8cc81da8cb83b42d215e753f40cf1b727a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: packaging: dbscripts: Increase vds_interface's network_name ...
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80810 ) Change subject: packaging: dbscripts: Increase vds_interface's network_name col size. ...................................................................... packaging: dbscripts: Increase vds_interface's network_name col size. vds_interface holds the network name of the relevant network. With the recent change to network names where networks are no longer restricted to 15 ASCII characters, vds_interface's network_name must follow suit and be increased to 256 bytes. Change-Id: I09bf3ee1fe6f875885b911a34628ffc16b613225 Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1478717 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M packaging/dbscripts/network_sp.sql A packaging/dbscripts/upgrade/04_01_0860_increase_vds_interface_network_name_size.sql 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80810 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09bf3ee1fe6f875885b911a34628ffc16b613225 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: Add updated size validation to network names.
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80809 ) Change subject: backend: Add updated size validation to network names. ...................................................................... backend: Add updated size validation to network names. Maximum allowed network name size is now 256 characters; it is not completely unlimited. Re-add size validations for network names with the new appropriate size (256). Change-Id: Ic6e795d148cc2ac860c3932267ba88113af6695c Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477161 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/Network.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80809 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic6e795d148cc2ac860c3932267ba88113af6695c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: frontend: Add updated size validation to network names.
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80808 ) Change subject: frontend: Add updated size validation to network names. ...................................................................... frontend: Add updated size validation to network names. Maximum allowed network name size is now 256 characters; it is not completely unlimited. Re-add size validations for network names with the new appropriate size (256). Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477161 Change-Id: Ia01ed8969910a3499d7b08169a798bf460ff07f6 Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80808 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia01ed8969910a3499d7b08169a798bf460ff07f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.1]: backend: Update business entitites definitions of network re...
by Code Review 21 Aug '17

21 Aug '17

>From Tal Nisan <tnisan(a)redhat.com>: Tal Nisan has submitted this change and it was merged. ( https://gerrit.ovirt.org/80807 ) Change subject: backend: Update business entitites definitions of network related sizes ...................................................................... backend: Update business entitites definitions of network related sizes Network name maximum size was increased to 256 characters and doesn't longer match bond name and network interface name. Dedicate new size definitions for both with their previous sizes. Bug-Id: https://bugzilla.redhat.com/show_bug.cgi?id=1477161 Change-Id: I80dde91f703d726fa579d33444684fbeef754cab Signed-off-by: Leon Goldberg <lgoldber(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/CreateOrUpdateBond.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/network/NetworkInterface.java 3 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Jenkins CI: Passed CI tests Leon Goldberg: Verified -- To view, visit https://gerrit.ovirt.org/80807 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I80dde91f703d726fa579d33444684fbeef754cab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.1 Gerrit-Owner: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Leon Goldberg <lgoldber(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: packaging: spec: require newer iso uploader
by Code Review 21 Aug '17

21 Aug '17

>From Sandro Bonazzola <sbonazzo(a)redhat.com>: Sandro Bonazzola has submitted this change and it was merged. ( https://gerrit.ovirt.org/80584 ) Change subject: packaging: spec: require newer iso uploader ...................................................................... packaging: spec: require newer iso uploader requiring newer iso uploader to ensure it's updated providing support for glusterfs storage. Change-Id: Ife5396a9ae8eb95f6c3914aa7aec30b3f2daf7a9 Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com> --- M ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Sandro Bonazzola: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/80584 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife5396a9ae8eb95f6c3914aa7aec30b3f2daf7a9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Ido Rosenzwig <irosenzw(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Rafael Martins <rafael(a)rafaelmartins.eng.br> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: ProfileListModel collections
by Code Review 20 Aug '17

20 Aug '17

>From Allon Mureinik <amureini(a)redhat.com>: Allon Mureinik has submitted this change and it was merged. ( https://gerrit.ovirt.org/80802 ) Change subject: webadmin: ProfileListModel collections ...................................................................... webadmin: ProfileListModel collections Use the optimized Collections#singletonList for a list with a single item instead of Arrays#asList. Change-Id: Ia4dc52c65f7a4a522ccb817bed07f19e23f744dc Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/profiles/ProfileListModel.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Allon Mureinik: Verified -- To view, visit https://gerrit.ovirt.org/80802 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia4dc52c65f7a4a522ccb817bed07f19e23f744dc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Sheremeta <gshereme(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0