May 2017 - Infra - oVirt List Archives

[JIRA] (OVIRT-1418) Lets remove the 'workflow' flag
by Daniel Belenky (oVirt JIRA) 29 May '17

29 May '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1418?page=com.atlassian.jira.… ] Daniel Belenky commented on OVIRT-1418: --------------------------------------- As far as I've been told, and as [~eedri] mentioned already, it's used to let others know that a patch is ready for review. But as we mark patches that are still under development with [WIP] I think that it's unnecessary. > Lets remove the 'workflow' flag > ------------------------------- > > Key: OVIRT-1418 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1418 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: Gerrit/git > Reporter: Barak Korren > Assignee: infra > > I don't remember what was David's idea behind adding it, I'm pretty sure nobody else does, and for now its just annoying. People just forget to set it, and you need to have it set to +2 to merge. -- This message was sent by Atlassian JIRA (v1000.1010.1#100044)

1 0

[JIRA] (OVIRT-1418) Lets remove the 'workflow' flag
by eedri (oVirt JIRA) 29 May '17

29 May '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1418?page=com.atlassian.jira.… ] eedri commented on OVIRT-1418: ------------------------------ +1, I also don't think it has real usage for now. We intended to use it to mark patches that are ready to review, not sure anyone uses it. On Mon, May 29, 2017 at 3:21 PM, Barak Korren (oVirt JIRA) < -- Eyal edri ASSOCIATE MANAGER RHV DevOps EMEA VIRTUALIZATION R&D Red Hat EMEA <https://www.redhat.com/> <https://red.ht/sig> TRIED. TESTED. TRUSTED. <https://redhat.com/trusted> phone: +972-9-7692018 irc: eedri (on #tlv #rhev-dev #rhev-integ) > Lets remove the 'workflow' flag > ------------------------------- > > Key: OVIRT-1418 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1418 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: Gerrit/git > Reporter: Barak Korren > Assignee: infra > > I don't remember what was David's idea behind adding it, I'm pretty sure nobody else does, and for now its just annoying. People just forget to set it, and you need to have it set to +2 to merge. -- This message was sent by Atlassian JIRA (v1000.1010.1#100044)

1 0

[JIRA] (OVIRT-1418) Lets remove the 'workflow' flag
by Barak Korren (oVirt JIRA) 29 May '17

29 May '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1418?page=com.atlassian.jira.… ] Barak Korren updated OVIRT-1418: -------------------------------- Epic Link: OVIRT-403 > Lets remove the 'workflow' flag > ------------------------------- > > Key: OVIRT-1418 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1418 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: Gerrit/git > Reporter: Barak Korren > Assignee: infra > > I don't remember what was David's idea behind adding it, I'm pretty sure nobody else does, and for now its just annoying. People just forget to set it, and you need to have it set to +2 to merge. -- This message was sent by Atlassian JIRA (v1000.1010.1#100044)

2 1

[JIRA] (OVIRT-1418) Lets remove the 'workflow' flag
by Barak Korren (oVirt JIRA) 29 May '17

29 May '17

Barak Korren created OVIRT-1418: ----------------------------------- Summary: Lets remove the 'workflow' flag Key: OVIRT-1418 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1418 Project: oVirt - virtualization made easy Issue Type: Improvement Components: Gerrit/git Reporter: Barak Korren Assignee: infra I don't remember what was David's idea behind adding it, I'm pretty sure nobody else does, and for now its just annoying. People just forget to set it, and you need to have it set to +2 to merge. -- This message was sent by Atlassian JIRA (v1000.1010.1#100044)

1 0

[JIRA] (OVIRT-1417) mock_cleanup.sh script does not erash shut-down VMs well
by Barak Korren (oVirt JIRA) 29 May '17

29 May '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1417?page=com.atlassian.jira.… ] Barak Korren reassigned OVIRT-1417: ----------------------------------- Assignee: Barak Korren (was: infra) > mock_cleanup.sh script does not erash shut-down VMs well > -------------------------------------------------------- > > Key: OVIRT-1417 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1417 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: oVirt CI > Reporter: Barak Korren > Assignee: Barak Korren > Priority: Highest > > '{{mock_cleanup.sh}}' includes the following code to cleanup VMs: > {code} > for UUID in $(virsh list --all --uuid); do > virsh destroy $UUID || : > sleep 2 > virsh undefine --remove-all-storage --storage vda --snapshots-metadata $UUID || : > done > {code} > This code probably worked at some point, but doesn't any more, instead if there are shut down VMs left on the machine, we get this error message: > {code} > error: Specified both --storage and --remove-all-storage > {code} > Need to fix this, the following was verified to work: > {code} > virsh undefine --remove-all-storage --snapshots-metadata $UUID > {code} -- This message was sent by Atlassian JIRA (v1000.1010.1#100044)

1 0

[JIRA] (OVIRT-1417) mock_cleanup.sh script does not erash shut-down VMs well
by Barak Korren (oVirt JIRA) 29 May '17

29 May '17

Barak Korren created OVIRT-1417: ----------------------------------- Summary: mock_cleanup.sh script does not erash shut-down VMs well Key: OVIRT-1417 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1417 Project: oVirt - virtualization made easy Issue Type: Improvement Components: oVirt CI Reporter: Barak Korren Assignee: infra Priority: Highest '{{mock_cleanup.sh}}' includes the following code to cleanup VMs: {code} for UUID in $(virsh list --all --uuid); do virsh destroy $UUID || : sleep 2 virsh undefine --remove-all-storage --storage vda --snapshots-metadata $UUID || : done {code} This code probably worked at some point, but doesn't any more, instead if there are shut down VMs left on the machine, we get this error message: {code} error: Specified both --storage and --remove-all-storage {code} Need to fix this, the following was verified to work: {code} virsh undefine --remove-all-storage --snapshots-metadata $UUID {code} -- This message was sent by Atlassian JIRA (v1000.1010.1#100044)

1 0

[JIRA] (OVIRT-1417) mock_cleanup.sh script does not erash shut-down VMs well
by Barak Korren (oVirt JIRA) 29 May '17

29 May '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1417?page=com.atlassian.jira.… ] Barak Korren updated OVIRT-1417: -------------------------------- Epic Link: OVIRT-400 > mock_cleanup.sh script does not erash shut-down VMs well > -------------------------------------------------------- > > Key: OVIRT-1417 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1417 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: oVirt CI > Reporter: Barak Korren > Assignee: infra > Priority: Highest > > '{{mock_cleanup.sh}}' includes the following code to cleanup VMs: > {code} > for UUID in $(virsh list --all --uuid); do > virsh destroy $UUID || : > sleep 2 > virsh undefine --remove-all-storage --storage vda --snapshots-metadata $UUID || : > done > {code} > This code probably worked at some point, but doesn't any more, instead if there are shut down VMs left on the machine, we get this error message: > {code} > error: Specified both --storage and --remove-all-storage > {code} > Need to fix this, the following was verified to work: > {code} > virsh undefine --remove-all-storage --snapshots-metadata $UUID > {code} -- This message was sent by Atlassian JIRA (v1000.1010.1#100044)

1 0

[JIRA] (OVIRT-1416) Preserve Gerrit CR flags on rebase.
by Barak Korren (oVirt JIRA) 29 May '17

29 May '17

[ https://ovirt-jira.atlassian.net/browse/OVIRT-1416?page=com.atlassian.jira.… ] Barak Korren updated OVIRT-1416: -------------------------------- Epic Link: OVIRT-403 > Preserve Gerrit CR flags on rebase. > ------------------------------------ > > Key: OVIRT-1416 > URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1416 > Project: oVirt - virtualization made easy > Issue Type: Improvement > Components: Gerrit/git > Reporter: Barak Korren > Assignee: infra > > Sometimes a patch finishes review and then needs to be rebased for some reason. This causes all flags to be lost. > We currently have settings to keep the +v flag on trivial rebase, we need the same for at least the CR flag. > Doing this for the WF flag might not be necessary though, b/c it is controlled by the patch author. -- This message was sent by Atlassian JIRA (v1000.1010.1#100044)

1 0

[JIRA] (OVIRT-1416) Preserve Gerrit CR flags on rebase.
by Barak Korren (oVirt JIRA) 29 May '17

29 May '17

Barak Korren created OVIRT-1416: ----------------------------------- Summary: Preserve Gerrit CR flags on rebase. Key: OVIRT-1416 URL: https://ovirt-jira.atlassian.net/browse/OVIRT-1416 Project: oVirt - virtualization made easy Issue Type: Improvement Components: Gerrit/git Reporter: Barak Korren Assignee: infra Sometimes a patch finishes review and then needs to be rebased for some reason. This causes all flags to be lost. We currently have settings to keep the +v flag on trivial rebase, we need the same for at least the CR flag. Doing this for the WF flag might not be necessary though, b/c it is controlled by the patch author. -- This message was sent by Atlassian JIRA (v1000.1010.1#100044)

1 0

[oVirt Jenkins] test-repo_ovirt_experimental_master - Build #6895 - FAILURE!
by jenkins＠jenkins.phx.ovirt.org 29 May '17

29 May '17

------=_Part_95_1960724250.1496054851851 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Build: http://jenkins.ovirt.org/job/test-repo_ovirt_experimental_master/6895/, Build Number: 6895, Build Status: FAILURE ------=_Part_95_1960724250.1496054851851--

1 1