- Infra - oVirt List Archives

Findbugs issues
by David Caro 24 Apr '14

24 Apr '14

This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --BiqR9cnB7IDE2sfOq9BtMg4X41CvwCcGO Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi! There are still some findbugs issues merged on ovirt-engine master, and I= 've tracked them down to a couple commits of yours, can you please review the= m and if they were introduced there, fix them? Thanks!! Commit 4c2d171a701c04f5b3a82690826aa72b08f2f3e1 by Martin Perina HostGeneralModel.java:641, ES_COMPARING_PARAMETER_STRING_WITH_EQ, Priorit= y: Low Comparison of String parameter using =3D=3D or !=3D in org.ovirt.engine.ui.uicommonweb.models.hosts.HostGeneralModel.setKdumpSta= tus(String) This code compares a java.lang.String parameter for reference equality us= ing the =3D=3D or !=3D operators. Requiring callers to pass only String constants= or interned strings to a method is unnecessarily fragile, and rarely leads to measura= ble performance gains. Consider using the equals(Object) method instead. Commit 749eba95219f36c0ad5ee8216b65a8efc8a1bae4 by Tomas Jelinek VmListModel.java:424, URF_UNREAD_FIELD, Priority: Low Unread field: org.ovirt.engine.ui.uicommonweb.models.vms.VmListModel.privateCustomPrope= rtiesKeysList This field is never read. Consider removing it from the class. pd. We have improved infra enough and we are gonna enable back the per-pa= tch checks to avoid this from happening in the future so we will not bother y= ou anymore with these issues :) --=20 David Caro Red Hat S.L. Continuous Integration Engineer - EMEA ENG Virtualization R&D Email: dcaro(a)redhat.com Web: www.redhat.com RHT Global #: 82-62605 --BiqR9cnB7IDE2sfOq9BtMg4X41CvwCcGO Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJTV+XbAAoJEEBxx+HSYmnDICoH/j6Q2kjINQXSx30EuxIj8aE4 InsSCJtQ0+wdvD2LK63ddMlgK99w5rgEmftvHIz20J0SwQiNoMFjCBDVqP6c3tDn G/iz3rtzuz5+G22SEY5bHFdQrD8tMQu57HEErbRXBuaBxVksjl9dB0PLeSVt9q8P PBLa9TQ+qYr9/ALUn4gSGCfKYG/aK/tszjwOD8IFPxtaRo9CNe5Nk9G2sJImSGHj pMYhZ09tHhsVJdOrgMfqtRSd+2XMxQPUr8jO/zQeGVQsP7fFb6LhpqfKdvZ/hLEM 4mUISnf80EsfADTBSiZrrMn2U4K0wWMox64uMtE/aIosh3KeSMyHJJROpXTnRfE= =9K9t -----END PGP SIGNATURE----- --BiqR9cnB7IDE2sfOq9BtMg4X41CvwCcGO--

3 2

[oVirt Jenkins] check_gerrit_ovirt_org - Build # 108829 - Failure!
by Jenkins ci oVirt Server 24 Apr '14

24 Apr '14

------=_Part_1337_197540333.1398312180802 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Project: http://jenkins.ovirt.org/job/check_gerrit_ovirt_org/ Build: http://jenkins.ovirt.org/job/check_gerrit_ovirt_org/108829/ Build Number: 108829 Build Status: Failure Triggered By: Started by timer ------------------------------------- Changes Since Last Success: ------------------------------------- Changes for Build #108829 ----------------- Failed Tests: ----------------- No tests ran. ------=_Part_1337_197540333.1398312180802--

1 1

[oVirt Jenkins] ovirt_engine_master_animal_sniffer_check - Build # 6470 - Fixed!
by Jenkins ci oVirt Server 23 Apr '14

23 Apr '14

------=_Part_1280_1800713754.1398278902364 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Project: http://jenkins.ovirt.org/job/ovirt_engine_master_animal_sniffer_check/ Build: http://jenkins.ovirt.org/job/ovirt_engine_master_animal_sniffer_check/6470/ Build Number: 6470 Build Status: Fixed Triggered By: Started by an SCM change ------------------------------------- Changes Since Last Success: ------------------------------------- Changes for Build #6468 [Vitor de Lima] webadmin: Prevent VM suspend in the ppc64 arch Changes for Build #6469 [Allon Mureinik] core: Audit log severity for live extend [Daniel Erez] core: RemoveSnapshotSingleDisk - use parent command type [Daniel Erez] core: AuditLogable - replace check to isNullOrEmpty Changes for Build #6470 [Alexander Wels] engine,webadmin: various coverity issues [Alexander Wels] webadmin: feedback tooltip [Daniel Erez] core: DiskImage - added vmSnapshotDescription [Daniel Erez] core: add snapshots names to merge_snapshots exection message ----------------- Failed Tests: ----------------- No tests ran. ------=_Part_1280_1800713754.1398278902364--

1 0

[oVirt Jenkins] ovirt_engine_master_animal_sniffer_check - Build # 6468 - Failure!
by Jenkins ci oVirt Server 23 Apr '14

23 Apr '14

------=_Part_1224_346340247.1398264202909 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Project: http://jenkins.ovirt.org/job/ovirt_engine_master_animal_sniffer_check/ Build: http://jenkins.ovirt.org/job/ovirt_engine_master_animal_sniffer_check/6468/ Build Number: 6468 Build Status: Failure Triggered By: Started by an SCM change ------------------------------------- Changes Since Last Success: ------------------------------------- Changes for Build #6468 [Vitor de Lima] webadmin: Prevent VM suspend in the ppc64 arch ----------------- Failed Tests: ----------------- No tests ran. ------=_Part_1224_346340247.1398264202909--

1 0

INFRA ISSUE: [oVirt Jenkins] ovirt-engine_3.4_upgrade-to-stable_merge - Build # 163 - Failure!
by Jenkins ci oVirt Server 23 Apr '14

23 Apr '14

------=_Part_1208_585014064.1398259598288 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Project: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/ Build: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/163/ Build Number: 163 Build Status: Failure Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/26861 ------------------------------------- Changes Since Last Success: ------------------------------------- Changes for Build #163 ----------------- Failed Tests: ----------------- No tests ran. ------=_Part_1208_585014064.1398259598288--

1 1

[oVirt Jenkins] check_gerrit_ovirt_org - Build # 108740 - Failure!
by Jenkins ci oVirt Server 23 Apr '14

23 Apr '14

------=_Part_1202_574939596.1398258671363 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Project: http://jenkins.ovirt.org/job/check_gerrit_ovirt_org/ Build: http://jenkins.ovirt.org/job/check_gerrit_ovirt_org/108740/ Build Number: 108740 Build Status: Failure Triggered By: Started by timer ------------------------------------- Changes Since Last Success: ------------------------------------- Changes for Build #108740 ----------------- Failed Tests: ----------------- No tests ran. ------=_Part_1202_574939596.1398258671363--

1 1

INFRA ISSUE: [oVirt Jenkins] ovirt-engine_3.4_upgrade-to-stable_merge - Build # 158 - Failure!
by Jenkins ci oVirt Server 23 Apr '14

23 Apr '14

------=_Part_1173_1576465024.1398247996482 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Project: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/ Build: http://jenkins.ovirt.org/job/ovirt-engine_3.4_upgrade-to-stable_merge/158/ Build Number: 158 Build Status: Failure Triggered By: Triggered by Gerrit: http://gerrit.ovirt.org/26948 ------------------------------------- Changes Since Last Success: ------------------------------------- Changes for Build #158 ----------------- Failed Tests: ----------------- No tests ran. ------=_Part_1173_1576465024.1398247996482--

1 2

[oVirt Jenkins] check_gerrit_ovirt_org - Build # 108720 - Failure!
by Jenkins ci oVirt Server 23 Apr '14

23 Apr '14

------=_Part_1168_459292211.1398246670640 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Project: http://jenkins.ovirt.org/job/check_gerrit_ovirt_org/ Build: http://jenkins.ovirt.org/job/check_gerrit_ovirt_org/108720/ Build Number: 108720 Build Status: Failure Triggered By: Started by timer ------------------------------------- Changes Since Last Success: ------------------------------------- Changes for Build #108720 ----------------- Failed Tests: ----------------- No tests ran. ------=_Part_1168_459292211.1398246670640--

1 1

[oVirt Jenkins] ovirt_engine_master_animal_sniffer_check - Build # 6464 - Failure!
by Jenkins ci oVirt Server 23 Apr '14

23 Apr '14

------=_Part_1144_2109163093.1398242850113 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Project: http://jenkins.ovirt.org/job/ovirt_engine_master_animal_sniffer_check/ Build: http://jenkins.ovirt.org/job/ovirt_engine_master_animal_sniffer_check/6464/ Build Number: 6464 Build Status: Failure Triggered By: Started by an SCM change ------------------------------------- Changes Since Last Success: ------------------------------------- Changes for Build #6464 [Martin Perina] core: Add flag to detect host kdump before fencing [Martin Perina] webadmin: Add detect kdump checkbox to power mgmt config [Martin Perina] restapi: Add flag to detect kdump before fencing [Martin Perina] core: Add host kdump status to VdsDynamic [Martin Perina] webadmin: Display kdump status [Martin Perina] core: Update host kdump status during vdsGetCaps [Martin Perina] restapi: Add kdump config status to Host ----------------- Failed Tests: ----------------- No tests ran. ------=_Part_1144_2109163093.1398242850113--

1 1

ovirt.org downtime (11:00-11:10 CEST)
by Dave Neary 23 Apr '14

23 Apr '14

Hi everyone, ovirt.org was down for a few minutes, and is now back up - I did it. It turns out that, surprisingly to me, "rhc snapshot save" (the command to save a copy of an OpenShift application) brings down the app to avoid database corruption - turns out it does a copy of the database files, rather than a mysqldump. The snapshot process itself looked like it was frozen, so I killed it and restarted the application with "rhc app restart -a wiki -n ovirt" to restore service. My apologies - I am, it appears, still being surprised by some idiosyncrasies of OpenShift. Cheers, Dave. -- Dave Neary - Community Action and Impact Open Source and Standards, Red Hat - http://community.redhat.com Ph: +33 9 50 71 55 62 / Cell: +33 6 77 01 92 13

1 0