May 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core:Validate shareable disk which attached to VMs
by mlipchuk＠redhat.com 24 May '12

24 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Validate shareable disk which attached to VMs ...................................................................... core:Validate shareable disk which attached to VMs Use validation when updating disk to be un shared any more. If the disk is attached to VMs then CDA message should block the operation. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I1024782e96f341d0c9b1d24eb283e76797c0a128 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 71 insertions(+), 12 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4493 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1024782e96f341d0c9b1d24eb283e76797c0a128 Gerrit-PatchSet: 16 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Change CDA message to fit shareable disk
by mlipchuk＠redhat.com 24 May '12

24 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Change CDA message to fit shareable disk ...................................................................... core:Change CDA message to fit shareable disk Use CDA message to fit more for shareable disks. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: I15e648267a78a76a5390ad24367a7cb2e9b8a2a3 --- M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 6 insertions(+), 6 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4639 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I15e648267a78a76a5390ad24367a7cb2e9b8a2a3 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Cleanup for BaseImageCommand
by mlipchuk＠redhat.com 24 May '12

24 May '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Cleanup for BaseImageCommand ...................................................................... core:Cleanup for BaseImageCommand The next changes/fixes are introduced: 1.Using the disk id to fetch the VM id which contains the disk, instead using the container id. 2.Clean clone and update image method from BaseImagesCommand. This method was never called and does not has any reason to be in the code. The vmId initialized in the cloned VM from the container id is not necessery in the BE, since all the calling methods are not using this parameter, and the vm id should not be part of the image state in the DB. 3. Remove use of container id when previewing a snapshot - Use vm id instead of container id when previewing a snapshot. 4. Remove container id use when create snapshot. 5. Clean unlogic code The initialization which is deleted is already done in getImage method. The code which is deleted represents the following logic: a = b; if (a == null) then get(b.id) if a is null then b is also null and there will be an NPE. Change-Id: Ida5aa7be5d5193a0e15d89a7888bdc0a8c15b083 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java 1 file changed, 5 insertions(+), 53 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4644 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida5aa7be5d5193a0e15d89a7888bdc0a8c15b083 Gerrit-PatchSet: 21 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change extractRemoveNetwork return to void
by mkolesni＠redhat.com 24 May '12

24 May '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Change extractRemoveNetwork return to void ...................................................................... core: Change extractRemoveNetwork return to void The list is already kept as a field in the SetupNetworksHelper so there is no need to have this method return a list and assign it. Change-Id: Ief927f8bf8e18ddf8367e61554f989a6d5b6ca71 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java 2 files changed, 5 insertions(+), 7 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4710 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief927f8bf8e18ddf8367e61554f989a6d5b6ca71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change removed networks to list of String
by mkolesni＠redhat.com 24 May '12

24 May '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Change removed networks to list of String ...................................................................... core: Change removed networks to list of String Change removed networks in SetupNetworks to be list of String, to add support of removing a network that is not managed by the engine. Change-Id: I297cec4b19b0f16b87fa1af87383dfa73f44bebd Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetupNetworksHelper.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/SetupNetworksHelperTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/SetupNetworksVdsCommandParameters.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 5 files changed, 19 insertions(+), 19 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4709 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I297cec4b19b0f16b87fa1af87383dfa73f44bebd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Fixing a release lock for case of MultipleActionRunne...
by mkublin＠redhat.com 24 May '12

24 May '12

Michael Kublin has submitted this change and it was merged. Change subject: core : Fixing a release lock for case of MultipleActionRunner ...................................................................... core : Fixing a release lock for case of MultipleActionRunner When a frontend is performing a call via MultipleActionRunner, at case of InternalCanDoAction() failure no ExcecuteAction is called, that leads that at such case there are no release for internal lock The following patch will fix an issue Change-Id: I540495f97994f8f53cd072bb43cdeedfcdc46907 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4671 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I540495f97994f8f53cd072bb43cdeedfcdc46907 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Re-Enable user queries
by ofrenkel＠redhat.com 23 May '12

23 May '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: Re-Enable user queries ...................................................................... core: Re-Enable user queries Re-enabled the query permissions mechanism that was disabled due to stability issues with the Power User Portal. Change-Id: I94eaf90401bf6b2c135db4594aeace75c7c4711f Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QueriesCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/QueriesCommandBaseTest.java 2 files changed, 18 insertions(+), 17 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, but someone else must approve Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4696 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94eaf90401bf6b2c135db4594aeace75c7c4711f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add origin field for template ovf export/import (#8182...
by tnisan＠redhat.com 23 May '12

23 May '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Add origin field for template ovf export/import (#818262) ...................................................................... core: Add origin field for template ovf export/import (#818262) https://bugzilla.redhat.com/818262 Added origin field to template ovf file export and import Change-Id: Iec4146485688bbe39eb1e05f49673ed97b42492a Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateReader.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec4146485688bbe39eb1e05f49673ed97b42492a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added disk alias to disk command events
by tnisan＠redhat.com 23 May '12

23 May '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Added disk alias to disk command events ...................................................................... core: Added disk alias to disk command events Added disk alias to the event generated upon add/remove/update/plug/unplug disk commands invocation Change-Id: I51539c31093c2aa7514e923a1e9c65c29aaff846 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 7 files changed, 59 insertions(+), 21 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51539c31093c2aa7514e923a1e9c65c29aaff846 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding template vNIC: Add VmDevice (#822129)
by mkolesni＠redhat.com 23 May '12

23 May '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Adding template vNIC: Add VmDevice (#822129) ...................................................................... core: Adding template vNIC: Add VmDevice (#822129) https://bugzilla.redhat.com/822129 Bug is a regression due to itroduction of stable device addresses feature. The fix is the missing VmDevice for this interface. Additionally, the device needs to be removed when removing the vNIC from the template, and when the whole template is removed. Change-Id: I07d963c7c83dcb6c974455a7cd4f59a3644aea92 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java 3 files changed, 11 insertions(+), 0 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4661 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07d963c7c83dcb6c974455a7cd4f59a3644aea92 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0