March 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove GetAllIdsFromExportDomainQuery
by amureini＠redhat.com 31 Mar '13

31 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove GetAllIdsFromExportDomainQuery ...................................................................... core: Remove GetAllIdsFromExportDomainQuery GetAllIdsFromExportDomainQuery is not used anywhere in the code, and hence should be removed. This patch removes the following: 1. The GetAllIdsFromExportDomainQuery class 2. The GetAllIdsFromExportDomain constant representing it in VdcQueryType 3. The GetVmsListVDSCommand class which was only used by this query. 4. The GetVmsList constant representing it in VDSCommandType. 5. The getVmsList(String, String) method in IIrsServer/IrsServerWrapper, which was only used by GetVmsListVDSCommand. 6. The GetVmsListReturnForXmlRpc class which was only used by GetVmsListVDSCommand. Change-Id: Id6c384ccbb317f67afb4d0fc13373dd6c7671f93 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetAllIdsFromExportDomainQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsListReturnForXmlRpc.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IIrsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsServerWrapper.java 7 files changed, 0 insertions(+), 96 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13280 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id6c384ccbb317f67afb4d0fc13373dd6c7671f93 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Remove unused IsStoragePoolWithSameNameExist
by amureini＠redhat.com 31 Mar '13

31 Mar '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Remove unused IsStoragePoolWithSameNameExist ...................................................................... core: Remove unused IsStoragePoolWithSameNameExist Removed the unused IsStoragePoolWithSameNameExistQuery. This patch removes the following: 1. The unused IsStoragePoolWithSameNameExistQuery class. 2. The IsStoragePoolWithSameNameExistParameters class only used by the aforementioned query class. 3. The IsStoragePoolWithSameNameExistQuery constant in VdcQueryType corresponding to the removed class. Change-Id: I08bba52c8795bba0535d4651c0b6532dd4d523c9 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsStoragePoolWithSameNameExistQuery.java D backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/IsStoragePoolWithSameNameExistParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java 3 files changed, 0 insertions(+), 37 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13227 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08bba52c8795bba0535d4651c0b6532dd4d523c9 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: cleanup: favor Charset.forName() over plain string
by yzaslavs＠redhat.com 31 Mar '13

31 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: pki: cleanup: favor Charset.forName() over plain string ...................................................................... pki: cleanup: favor Charset.forName() over plain string Change-Id: Id61cad58356820a73683666235d328a72582486b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EncryptionUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java 2 files changed, 12 insertions(+), 11 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13192 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id61cad58356820a73683666235d328a72582486b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: host-deploy: cleanup: favor Charset.forName() over plain str...
by yzaslavs＠redhat.com 31 Mar '13

31 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: cleanup: favor Charset.forName() over plain string ...................................................................... host-deploy: cleanup: favor Charset.forName() over plain string Change-Id: Ifa209cebf9efa5dc6c8e3f50447c9af25fcf9c2f Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java 2 files changed, 5 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13191 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifa209cebf9efa5dc6c8e3f50447c9af25fcf9c2f Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: host-deploy: cleanup: remove unused VdsInstallStages
by yzaslavs＠redhat.com 31 Mar '13

31 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: cleanup: remove unused VdsInstallStages ...................................................................... host-deploy: cleanup: remove unused VdsInstallStages Change-Id: Ibeecb987720428dd0bd515884dde8e6a198159a2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstallStages.java 1 file changed, 0 insertions(+), 25 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibeecb987720428dd0bd515884dde8e6a198159a2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: cleanup: Format string should use %n rather than \n
by yzaslavs＠redhat.com 31 Mar '13

31 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: pki: cleanup: Format string should use %n rather than \n ...................................................................... pki: cleanup: Format string should use %n rather than \n Workaround to quiet findbugs... we do need \n... Change-Id: I6ff7707618243d0d0989819571e425580667b5a2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13189 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ff7707618243d0d0989819571e425580667b5a2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: cleanup: Found reliance on default encoding
by yzaslavs＠redhat.com 31 Mar '13

31 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: pki: cleanup: Found reliance on default encoding ...................................................................... pki: cleanup: Found reliance on default encoding Change-Id: I181c9b3e26c5b941fe368b3287a7486b6b8f91e1 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/crypt/EncryptionUtils.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java 2 files changed, 6 insertions(+), 5 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I181c9b3e26c5b941fe368b3287a7486b6b8f91e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: cleanup: the method name SignCertificateRequest doesn't...
by yzaslavs＠redhat.com 31 Mar '13

31 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: pki: cleanup: the method name SignCertificateRequest doesn't start with a lower case letter ...................................................................... pki: cleanup: the method name SignCertificateRequest doesn't start with a lower case letter Change-Id: I6a5677d644f000254be5c8d5bdae4ba6478b8f25 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapperTest.java 3 files changed, 7 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a5677d644f000254be5c8d5bdae4ba6478b8f25 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: host-deploy: cleanup: Redundant nullcheck of vdsByUniqueId
by yzaslavs＠redhat.com 31 Mar '13

31 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: cleanup: Redundant nullcheck of vdsByUniqueId ...................................................................... host-deploy: cleanup: Redundant nullcheck of vdsByUniqueId Change-Id: Idd6454026bfa210c382d1e20d5c69dec7d11c104 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 4 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13186 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idd6454026bfa210c382d1e20d5c69dec7d11c104 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: host-deploy: cleanup: Exception is caught when Exception is ...
by yzaslavs＠redhat.com 31 Mar '13

31 Mar '13

Yair Zaslavsky has submitted this change and it was merged. Change subject: host-deploy: cleanup: Exception is caught when Exception is not thrown ...................................................................... host-deploy: cleanup: Exception is caught when Exception is not thrown Change-Id: I46993b678b8c1a1e12c8fe433d8d081657dba5b4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/13185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46993b678b8c1a1e12c8fe433d8d081657dba5b4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0