Change in ovirt-engine[master]: host-deploy: cleanup: Incorrect lazy initialization of stati...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: host-deploy: cleanup: Incorrect lazy initialization of static field VdsDeploy.s_deployPackage
......................................................................
host-deploy: cleanup: Incorrect lazy initialization of static field VdsDeploy.s_deployPackage
Change-Id: Iade6cbfc53e3736600c587d6006bbac41a3c0ff3
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iade6cbfc53e3736600c587d6006bbac41a3c0ff3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: host-deploy: cleanup: A class's finalize() method should hav...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: host-deploy: cleanup: A class's finalize() method should have protected access, not public.
......................................................................
host-deploy: cleanup: A class's finalize() method should have protected access, not public.
Change-Id: Iee1ad0b56b6e991dd54027c7be8282703c494474
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/OVirtNodeUpgrade.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHDialog.java
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13183
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee1ad0b56b6e991dd54027c7be8282703c494474
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 8 months
Change in ovirt-log-collector[master]: sos - fixed behaviour when -a option is used
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: sos - fixed behaviour when -a option is used
......................................................................
sos - fixed behaviour when -a option is used
calling sosreport -a -o postgresql set all the
postgresql plugin options to True which was an
unexpected and unhandled value.
Fixed also some minor issues like wrong indentation,
instance attribute declaration out of __init__,
file built-in redefinition.
Change-Id: Ifcebf02bd96bec18094175d97013bee1c54b5e34
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/sos/plugins/postgresql.py
1 file changed, 40 insertions(+), 18 deletions(-)
Approvals:
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifcebf02bd96bec18094175d97013bee1c54b5e34
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-log-collector[master]: Fixed set_hosts for handling correctly -H option
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: Fixed set_hosts for handling correctly -H option
......................................................................
Fixed set_hosts for handling correctly -H option
As stated in the method documentation each option set together
is treated as an intersection.
Previously -H caused an error when a host list was supplied due
to a parameter passed with the wrong type to get_hypervisor_data.
Change-Id: Ib9a99fc1e9bd49fbdcfcbdcb18dfddf6cd7e80e6
Bug-Url: https://bugzilla.redhat.com/918020
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 27 insertions(+), 31 deletions(-)
Approvals:
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13149
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib9a99fc1e9bd49fbdcfcbdcb18dfddf6cd7e80e6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-log-collector[master]: tools: added rpm to hypervisors sosreport
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: tools: added rpm to hypervisors sosreport
......................................................................
tools: added rpm to hypervisors sosreport
Provides information about rpms installed on hypervisors.
Change-Id: I57bc036b3a13f44be14d194555a448f9005b9e78
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M src/__main__.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13169
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57bc036b3a13f44be14d194555a448f9005b9e78
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-iso-uploader[master]: packaging: create the conf.d directory
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: packaging: create the conf.d directory
......................................................................
packaging: create the conf.d directory
Change-Id: Iee943cfe44c581cd6b767f8460e35aa65cec0728
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M ovirt-iso-uploader.spec.in
A src/.keep
M src/Makefile.am
3 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13147
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee943cfe44c581cd6b767f8460e35aa65cec0728
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-iso-uploader
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-image-uploader[master]: packaging: create the conf.d directory
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: packaging: create the conf.d directory
......................................................................
packaging: create the conf.d directory
Change-Id: I65b5eb9717a24a97b4e743039905f17457387dd4
Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com>
---
M ovirt-image-uploader.spec.in
A src/.keep
M src/Makefile.am
3 files changed, 6 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13146
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I65b5eb9717a24a97b4e743039905f17457387dd4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-image-uploader
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-log-collector[master]: packaging: create the conf.d directory
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: packaging: create the conf.d directory
......................................................................
packaging: create the conf.d directory
Change-Id: Ia5a5a6c6f1df8a62c39c4c30933981e01b0a5706
Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com>
---
M ovirt-log-collector.spec.in
A src/.keep
M src/Makefile.am
3 files changed, 7 insertions(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Looks good to me, but someone else must approve
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13145
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5a5a6c6f1df8a62c39c4c30933981e01b0a5706
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-log-collector[master]: config: fixup default config locaiton
by knesenko@redhat.com
Kiril Nesenko has submitted this change and it was merged.
Change subject: config: fixup default config locaiton
......................................................................
config: fixup default config locaiton
Change-Id: I643659e908f2d970299f320e3a4ee5aba05d71f5
Signed-off-by: Alon Bar-Lev <alon.barlev(a)gmail.com>
---
M src/__main__.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Alon Bar-Lev: Verified
Sandro Bonazzola: Verified; Looks good to me, but someone else must approve
Kiril Nesenko: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/13144
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I643659e908f2d970299f320e3a4ee5aba05d71f5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
11 years, 8 months
Change in ovirt-engine[master]: webadmin: grids jump to last selected entity
by vszocs@redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: grids jump to last selected entity
......................................................................
webadmin: grids jump to last selected entity
- Fixed grids jumping to last selected entity on refresh.
Change-Id: I0f34a369ba1074456614ad65b7e4cc77af963853
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=882618
Signed-off-by: Alexander Wels <awels(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/AbstractActionTable.java
1 file changed, 18 insertions(+), 5 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/10672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f34a369ba1074456614ad65b7e4cc77af963853
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 8 months