Change in ovirt-engine[master]: gluster: Added missing messages for gluster hooks
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: Added missing messages for gluster hooks
......................................................................
gluster: Added missing messages for gluster hooks
Added missing front-end messages for gluster hooks.
Change-Id: Ic73940937f7ca427bfdf96ff898922010c72199d
Bug-Url: https://bugzilla.redhat.com/971676
Bug-Url: https://bugzilla.redhat.com/971658
Signed-off-by: Sahina Bose <sabose(a)redhat.com>
--…
[View More]-
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
4 files changed, 20 insertions(+), 0 deletions(-)
Approvals:
Kanagaraj M: Looks good to me, approved
Sahina Bose: Verified
--
To view, visit http://gerrit.ovirt.org/15711
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic73940937f7ca427bfdf96ff898922010c72199d
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
[View Less]
11 years, 10 months
Change in ovirt-engine[master]: gluster: Corrected cluster service status value
by kmayilsa@redhat.com
Kanagaraj M has submitted this change and it was merged.
Change subject: gluster: Corrected cluster service status value
......................................................................
gluster: Corrected cluster service status value
Corrected the cluster service status value to be shown as Up/Down
instead of RUNNING/STOPPED.
Change-Id: I20306b662c23f22e1228f560f8b82c0a031da81b
Bug-Url: https://bugzilla.redhat.com/973608
Signed-off-by: Shubhendu Tripathi <shtripat(a)redhat.com>
…
[View More]---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/cluster/SubTabClusterServiceView.java
1 file changed, 7 insertions(+), 3 deletions(-)
Approvals:
Shubhendu Tripathi: Verified
Kanagaraj M: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15709
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I20306b662c23f22e1228f560f8b82c0a031da81b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shubhendu Tripathi <shtripat(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Shubhendu Tripathi <shtripat(a)redhat.com>
[View Less]
11 years, 10 months
Change in otopi[master]: system: info: add user id information
by Alon Bar-Lev
Alon Bar-Lev has submitted this change and it was merged.
Change subject: system: info: add user id information
......................................................................
system: info: add user id information
Change-Id: I6b00e6a2310d58aa8efbc825637d73506afe315e
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M src/plugins/otopi/system/info.py
1 file changed, 8 insertions(+), 0 deletions(-)
Approvals:
Alon Bar-Lev: Verified; Looks good to me, approved
--
To view,…
[View More] visit http://gerrit.ovirt.org/15689
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b00e6a2310d58aa8efbc825637d73506afe315e
Gerrit-PatchSet: 1
Gerrit-Project: otopi
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
[View Less]
11 years, 10 months
Change in ovirt-dwh[master]: history: change needed fuction location to pre-upgrade
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: history: change needed fuction location to pre-upgrade
......................................................................
history: change needed fuction location to pre-upgrade
Change-Id: Id0e0bd79e75df17c6ff01b50ae8184cc910db66b
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/historydbscripts_postgres/create_sp.sql
M data-warehouse/historydbscripts_postgres/upgrade/…
[View More]03_02_0050_add_function_to_update_enum_table.sql
A data-warehouse/historydbscripts_postgres/upgrade/pre_upgrade/add_function_to_update_enum_table.sql
3 files changed, 15 insertions(+), 28 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15677
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id0e0bd79e75df17c6ff01b50ae8184cc910db66b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
[View Less]
11 years, 10 months
Change in ovirt-reports[master]: packaging: updated configuration xml
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: updated configuration xml
......................................................................
packaging: updated configuration xml
Change-Id: I38a743c4097712d1a714938af851f51e951a87f3
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M reports/repository_files/resources/reports_resources/JDBC/data_sources/ovirt.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yaniv Dary: Verified; …
[View More]Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15674
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38a743c4097712d1a714938af851f51e951a87f3
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
[View Less]
11 years, 10 months
Change in ovirt-engine-sdk-java[master]: sdk: implement basic debugging capabilities
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: implement basic debugging capabilities
......................................................................
sdk: implement basic debugging capabilities
Change-Id: Iaa3b92013119c1b8afaf92cc74b1bb1f17c2b228
Signed-off-by: Michael pasternak <mpastern(a)redhat.com>
---
M ovirt-engine-sdk-java-codegen/src/main/java/org/ovirt/engine/sdk/codegen/templates/ApiTemplate
A ovirt-engine-sdk-java/log/log4j-…
[View More]default.properties
A ovirt-engine-sdk-java/log/log4j-verbose.properties
A ovirt-engine-sdk-java/log/log4j.xml
M ovirt-engine-sdk-java/pom.xml
M ovirt-engine-sdk-java/src/main/java/org/ovirt/engine/sdk/Api.java
6 files changed, 116 insertions(+), 18 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15666
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaa3b92013119c1b8afaf92cc74b1bb1f17c2b228
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-sdk-java
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
[View Less]
11 years, 10 months
Change in ovirt-engine[master]: findbugs: dont use static filed as public
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: dont use static filed as public
......................................................................
findbugs: dont use static filed as public
A mutable static field could be changed by malicious code or by
accident. The field could be made package protected to avoid this
vulnerability.
findbugs reason:
MS: Field should be package protected (MS_PKGPROTECT)
Change-Id: …
[View More]If0d3d345fdd56faf1a7b9ae826924527f6fceff2
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ADUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DefaultRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPAGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPARootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/IPAUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/ITDSUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/OpenLdapGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/OpenLdapUserContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSGroupContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSRootDSEContextMapper.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/RHDSUserContextMapper.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/gluster/BackendGlusterVolumesResource.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterPolicyModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java
19 files changed, 22 insertions(+), 22 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15287
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If0d3d345fdd56faf1a7b9ae826924527f6fceff2
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
[View Less]
11 years, 10 months
Change in ovirt-reports[master]: packaging: Updating env with correct pgpassword
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: Updating env with correct pgpassword
......................................................................
packaging: Updating env with correct pgpassword
This patch updates execExternalCmd command with
correct PGPASSFILE environment value allowing
execution of DB commands.
Change-Id: Icb5fa0cc9fbae131ce028a3346a328cc1d43da74
Bug-Url: https://bugzilla.redhat.com/974064
Signed-off-by: Alex Lourie <…
[View More]alourie(a)redhat.com>
---
M packaging/common_utils.py
1 file changed, 14 insertions(+), 3 deletions(-)
Approvals:
Alex Lourie: Verified
Kiril Nesenko: Looks good to me, but someone else must approve
Yaniv Dary: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15660
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icb5fa0cc9fbae131ce028a3346a328cc1d43da74
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-reports
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
[View Less]
11 years, 10 months
Change in ovirt-engine[master]: webadmin: Fix NPE in VmModelBehaviorBase
by tjelinek@redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: Fix NPE in VmModelBehaviorBase
......................................................................
webadmin: Fix NPE in VmModelBehaviorBase
Fix NPE which prevented new/edit VM Pool dialog from loading.
Change-Id: Iba1b40aeb51613b7283202c33b737b04f1c5a599
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/TimeZoneType.java
…
[View More]1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15282
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iba1b40aeb51613b7283202c33b737b04f1c5a599
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Martin Beták <mbetak(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
[View Less]
11 years, 10 months
Change in ovirt-engine[master]: findbugs: use entrySet iteration instead of keySet
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: findbugs: use entrySet iteration instead of keySet
......................................................................
findbugs: use entrySet iteration instead of keySet
This methods accesses the value of a Map entry, using a key that was
retrieved from a keySet iterator. It is more efficient to use an
iterator on the entrySet of the map, to avoid the Map.get(key) lookup
findbugs reason:
WMI: Inefficient use of …
[View More]keySet iterator instead of entrySet iterator (WMI_WRONG_MAP_ITERATOR)
Change-Id: I770f16b04488e21e441233686a81b4c1f3900be7
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/LdapBrokerUtils.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectAllHostsToLunCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ValueObjectMap.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/gluster/GlusterAuditLogUtil.java
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetStoragePoolInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetVmsInfoVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkItemPanel.java
14 files changed, 66 insertions(+), 60 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/15406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I770f16b04488e21e441233686a81b4c1f3900be7
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
[View Less]
11 years, 10 months