January 2015 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: Migration mode was ignored on the edit instance type

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: Migration mode was ignored on the edit instance type ...................................................................... webadmin: Migration mode was ignored on the edit instance type Simple fix by adding the setting to ExistingInstanceTypeModelBehavior. Change-Id: Iae5b9547161b7631d08d4815840746d667e4d7c9 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/ExistingInstanceTypeModelBehavior.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iae5b9547161b7631d08d4815840746d667e4d7c9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: if next run configuration exists the edit VM may l...

by tjelinek＠redhat.com

Tomas Jelinek has submitted this change and it was merged. Change subject: webadmin: if next run configuration exists the edit VM may load forever ...................................................................... webadmin: if next run configuration exists the edit VM may load forever If the nextRunConfiguration exists, the model.stopProgress(); was not called in updateVirtioScsi() which caused the progress bar to show forever. Change-Id: Iea63c3557d5b962d56ba2c0e1f97356f41474aef Bug-Url: https://bugzilla.redhat.com/1180038 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/instancetypes/InstanceTypeManager.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36679 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea63c3557d5b962d56ba2c0e1f97356f41474aef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: engine-backup: Fix changing owner

by sbonazzo＠redhat.com

Sandro Bonazzola has submitted this change and it was merged. Change subject: packaging: engine-backup: Fix changing owner ...................................................................... packaging: engine-backup: Fix changing owner Ignore errors while trying to set owner to previous db user. Change-Id: Ifc864805217cbd30b3c3b97f3be342825edc98f7 Bug-Url: https://bugzilla.redhat.com/1121961 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> --- M packaging/bin/engine-backup.sh 1 file changed, 14 insertions(+), 4 deletions(-) Approvals: Sandro Bonazzola: Looks good to me, approved oVirt Jenkins CI Server: Looks good to me, but someone else must approve Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/36150 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifc864805217cbd30b3c3b97f3be342825edc98f7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Lev Veyde <lveyde(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com> Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Remove @author from javadoc

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Remove @author from javadoc ...................................................................... engine: Remove @author from javadoc There is not such convention to maintain classes authors. For tracking changes we use git. Change-Id: I880c5ed8ce2977f10a810f4e8a1fdf8a327f6ecf Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/builtin-extensions/src/main/java/org/ovirt/engine/extensions/aaa/builtin/kerberosldap/UserAuthenticationResult.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmStaticDAOTest.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/HasPaging.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/Match.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/Regex.java M frontend/webadmin/modules/gwt-extension/src/main/java/org/ovirt/engine/ui/uioverrides/org/ovirt/engine/core/compat/RegexOptions.java 6 files changed, 0 insertions(+), 24 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Moti Asayag: Verified -- To view, visit http://gerrit.ovirt.org/36761 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I880c5ed8ce2977f10a810f4e8a1fdf8a327f6ecf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Fix NPE on edit host network

by lvernia＠redhat.com

Lior Vernia has submitted this change and it was merged. Change subject: webadmin: Fix NPE on edit host network ...................................................................... webadmin: Fix NPE on edit host network Fixed NPE related to the Host Network QoS feature. Change-Id: Ie80bb818a8f8df59cdd32e50dbf76b3c19968bdf Signed-off-by: Lior Vernia <lvernia(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostInterfaceModel.java 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Lior Vernia: Verified -- To view, visit http://gerrit.ovirt.org/36689 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie80bb818a8f8df59cdd32e50dbf76b3c19968bdf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Lior Vernia <lvernia(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-dwh[ovirt-engine-dwh-3.5]: packaging: bin: Use engine's java-home for classpath

by sradco＠redhat.com

Shirly Radco has submitted this change and it was merged. Change subject: packaging: bin: Use engine's java-home for classpath ...................................................................... packaging: bin: Use engine's java-home for classpath Change-Id: I2e9fabfc09629a6f188526e836badc5508752156 Signed-off-by: Yedidyah Bar David <didi(a)redhat.com> (cherry picked from commit 0afae9647008faff7e7eb5ac70c62fc7b4c667de) --- M packaging/bin/dwh-classpath.sh 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Shirly Radco: Looks good to me, approved Yedidyah Bar David: Verified -- To view, visit http://gerrit.ovirt.org/36759 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e9fabfc09629a6f188526e836badc5508752156 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.5 Gerrit-Owner: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[ovirt-engine-3.5]: core: sorted getJsonDiskDescription()

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: sorted getJsonDiskDescription() ...................................................................... core: sorted getJsonDiskDescription() ImagesHandler.getJsonDiskDescription() used a HashMap to serialize a Disk's Alias and Description. Since the order of iteration of a HashMap cannot be trusted, it made the method's behavior unpredictable in different environments, specifically breaking the unit tests on the default JDK8 supplied with Fedora 21. This patch replaces the internal implementation from using a HashMap to use a TreeMap, ensuring the keys are iterated by order, and thus producing a reliable output: {"DiskAlias":"some_alias","DiskDescription":"some_description}. The unit tests have been fixed accordingly, making them agnostic to JDK upgrades. Change-Id: Ic8496858a2cb5715ab9f84b8ae77f62b3e6097d4 Bug-Url: https://bugzilla.redhat.com/1180887 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImagesHandlerTest.java 2 files changed, 5 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/36762 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8496858a2cb5715ab9f84b8ae77f62b3e6097d4 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-3.5 Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org

10 years, 3 months

1
0
0 / 0

Change in ovirt-dwh[master]: history: maintain db connection for DisconnectDwh check

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: history: maintain db connection for DisconnectDwh check ...................................................................... history: maintain db connection for DisconnectDwh check Fixed that if db connection is lost then the DisconnectDwh check will try to reconnect again to the engine db. Change-Id: I948cf3aa8eabe3096e7683db67024a0702775f70 Bug-Url: https://bugzilla.redhat.com/1170501 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M etl_export/src/ovirt_engine_dwh/historyetl_3_6/HistoryETL.java M tos_project/process/HistoryETL_3.6.item M tos_project/process/HistoryETL_3.6.properties M tos_project/talend.project 4 files changed, 3,450 insertions(+), 3,512 deletions(-) Approvals: Shirly Radco: Verified Yaniv Dary: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/35878 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I948cf3aa8eabe3096e7683db67024a0702775f70 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: ui: notification to the user that a new client tools are ava...

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: ui: notification to the user that a new client tools are available ...................................................................... ui: notification to the user that a new client tools are available When new guest tools are available we indicate that by annotating the VMs running icon with annotation mark and a tooltip Change-Id: I855aa69a1d91967bde6f784e494bf4a343c78576 Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/VmStatusCell.java 3 files changed, 8 insertions(+), 4 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36580 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I855aa69a1d91967bde6f784e494bf4a343c78576 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

Change in ovirt-engine[master]: core: notification to the user that a new client tools are a...

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: core: notification to the user that a new client tools are available ...................................................................... core: notification to the user that a new client tools are available Adding guest_agent_status for vm_dynamic for storing the if update of the client tools is needed. On IsoDomainListSyncronizer check for new isos (periodically or user initiative) relevant VMs are set with the status if a newer tools are present in iso domain. Change-Id: If098422eb76295517022de1c7f716db354e7853e Signed-off-by: Shahar Havivi <shaharh(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/GuestAgentStatus.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDynamicDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDynamicDAOTest.java M backend/manager/modules/dal/src/test/resources/fixtures.xml M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml M packaging/dbscripts/create_views.sql A packaging/dbscripts/upgrade/03_06_0740_add_guest_agent_status_to_vm_dynamic.sql M packaging/dbscripts/vms_sp.sql 15 files changed, 223 insertions(+), 7 deletions(-) Approvals: Shahar Havivi: Verified Arik Hadas: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/36556 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If098422eb76295517022de1c7f716db354e7853e Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: automation(a)ovirt.org Gerrit-Reviewer: oVirt Jenkins CI Server

10 years, 3 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits January 2015