Change in ovirt-engine-sdk[master]: codegen: Extract metadata from Maven artifacts
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: codegen: Extract metadata from Maven artifacts
......................................................................
codegen: Extract metadata from Maven artifacts
Currently we require a live engine to generate the metadata. This
increases the time required to re-generate the SDK, specially when there
are more than one version that needs to be re-generated. This patch
changes the code generator so that it extracts the metadata from the
engine Maven artifacts, thus no live engine is required.
Change-Id: I059364a47d3194074ad5dcd373acf7bd3f3ce0e7
Bug-Url: https://bugzilla.redhat.com/1069204
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M README.md
M generator/pom.xml
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/Collection.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/CollectionExceptions.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/RsdlCodegen.java
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionAddTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetDisksTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetNotSearchableTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionGetSearchableTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionListNotSearchableTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/CollectionListSearchableTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/ResourceActionTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/ResourceDeleteTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/ResourceDeleteWithBodyAndParamsTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/ResourceDeleteWithBodyTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/ResourceDeleteWithParamsTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/ResourceUpdateTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubCollectionAddTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubCollectionGetTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubCollectionListTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubCollectionListWithParamsTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceActionTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceCollectionActionTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceDeleteTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceDeleteWithBodyTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceDeleteWithUrlParamsAndBodyTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceDeleteWithUrlParamsTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/rsdl/templates/SubResourceUpdateTemplate
M generator/src/main/java/org/ovirt/engine/sdk/generator/utils/UrlUtils.java
D generator/src/main/resources/README
R generator/src/main/resources/rsdl.xml
31 files changed, 696 insertions(+), 787 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/32225
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I059364a47d3194074ad5dcd373acf7bd3f3ce0e7
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in jenkins[master]: Adding HE plugin and VDSM plugin to be build in by default
by dcaroest＠redhat.com
David Caro has submitted this change and it was merged.
Change subject: Adding HE plugin and VDSM plugin to be build in by default
......................................................................
Adding HE plugin and VDSM plugin to be build in by default
Change-Id: Iafd410eb33d5b7bdb53fbed5d0caf08b9818438b
Signed-off-by: Tolik Litovsky <tlitovsk(a)redhat.com>
---
M jobs/confs/shell-scripts/build-local-ovirt-node.sh
1 file changed, 12 insertions(+), 3 deletions(-)
Approvals:
David Caro: Looks good to me, approved
Anatoly Litovsky: Verified
--
To view, visit http://gerrit.ovirt.org/37262
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafd410eb33d5b7bdb53fbed5d0caf08b9818438b
Gerrit-PatchSet: 2
Gerrit-Project: jenkins
Gerrit-Branch: master
Gerrit-Owner: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk(a)redhat.com>
Gerrit-Reviewer: David Caro <dcaroest(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: searchbackend: Removed Unused Code
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: searchbackend: Removed Unused Code
......................................................................
searchbackend: Removed Unused Code
Removed unused code from the StorageDomainFieldAutoCompleter class.
Change-Id: I2b99855e351cc18244697a36d3d07e01706a3eac
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Allon Mureinik: Looks good to me, approved
Idan Shaby: Verified
--
To view, visit http://gerrit.ovirt.org/37207
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2b99855e351cc18244697a36d3d07e01706a3eac
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
10 years, 2 months
Change in ovirt-engine[master]: searchbackend: Search Storage Domains by Wipe After Delete
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: searchbackend: Search Storage Domains by Wipe After Delete
......................................................................
searchbackend: Search Storage Domains by Wipe After Delete
This patch adds the ability to search for Storage Domains by their Wipe
After Delete value.
Change-Id: Ia45aeffbea103fc7d51dce3dd31bc3fd25196357
Bug-Url: https://bugzilla.redhat.com/1183801
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/StorageDomainFieldAutoCompleter.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit http://gerrit.ovirt.org/37206
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia45aeffbea103fc7d51dce3dd31bc3fd25196357
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: searchbackend: Search Disks by Wipe After Delete
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: searchbackend: Search Disks by Wipe After Delete
......................................................................
searchbackend: Search Disks by Wipe After Delete
This patch adds the ability to search for disks by their Wipe After
Delete value.
Change-Id: I1a8a6b6d80ba6a0c17c2119e5bc789d6e62c29a4
Bug-Url: https://bugzilla.redhat.com/1101012
Signed-off-by: Idan Shaby <ishaby(a)redhat.com>
---
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DiskConditionFieldAutoCompleter.java
1 file changed, 6 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Freddy Rolland: Looks good to me, but someone else must approve
Idan Shaby: Verified
--
To view, visit http://gerrit.ovirt.org/37205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1a8a6b6d80ba6a0c17c2119e5bc789d6e62c29a4
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Candace Sheremeta <cshereme(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-hosted-engine-ha[master]: packaging: spec: updated requirements
by msivak＠redhat.com
Martin Sivák has submitted this change and it was merged.
Change subject: packaging: spec: updated requirements
......................................................................
packaging: spec: updated requirements
VDSM 4.17 drops getVolumePath and use prepareImage
instead, introducing API breackages.
Ensuring that hosted-engine and VDSM are using the
same API.
Change-Id: I8a05026e510cafc20a24c8c69568e5fdd44ca634
Signed-off-by: Sandro Bonazzola <sbonazzo(a)redhat.com>
---
M ovirt-hosted-engine-ha.spec.in
1 file changed, 6 insertions(+), 6 deletions(-)
Approvals:
Sandro Bonazzola: Verified
Martin Sivák: Looks good to me, approved
Simone Tiraboschi: Looks good to me, but someone else must approve
Jiří Moskovčák: Looks good to me, but someone else must approve
Yedidyah Bar David: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/37122
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8a05026e510cafc20a24c8c69568e5fdd44ca634
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-hosted-engine-ha
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Jiří Moskovčák <jmoskovc(a)redhat.com>
Gerrit-Reviewer: Martin Sivák <msivak(a)redhat.com>
Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos(a)redhat.com>
Gerrit-Reviewer: Yedidyah Bar David <didi(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: core: Validate the return value of an internal query.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Validate the return value of an internal query.
......................................................................
core: Validate the return value of an internal query.
Use the internal query return value to check if it has been succeeded or
failed when calling getExistingStorageDomainList, so we can be sure that
the return object value is a list and not null in case of a failure.
Change-Id: I7a4ddd8f0e290981f1d583dfdb1722f7864b1f6d
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetFileStorageDomainsWithAttachedStoragePoolGuidQuery.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetFileStorageDomainsWithAttachedStoragePoolGuidQueryTest.java
2 files changed, 49 insertions(+), 10 deletions(-)
Approvals:
Tal Nisan: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/37272
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7a4ddd8f0e290981f1d583dfdb1722f7864b1f6d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: webadmin: Check attached DC only for data Storage.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: webadmin: Check attached DC only for data Storage.
......................................................................
webadmin: Check attached DC only for data Storage.
Filter only data storage domains when executing the validation for
attached Data Center when importing a file Storage Domain to prevent
checking it for ISO and Export Storage Domains.
Change-Id: I8fc9f48a3849f70306cc2748d1a716924a0a4f76
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Daniel Erez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/37273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8fc9f48a3849f70306cc2748d1a716924a0a4f76
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: engine: Fix ambigous error message
by rgolan＠redhat.com
Roy Golan has submitted this change and it was merged.
Change subject: engine: Fix ambigous error message
......................................................................
engine: Fix ambigous error message
Fix error message to reflect the subject DiskProfile name and the
target StorageDomain name.
Sample fixed error message:
Operation Failed: [Cannot add VM. Disk Profile 'storage-profile-1-ds-2'
is not assigned to Storage Domain 'storage-domain-2'.]
Change-Id: Id20106788bdd8a2b0f3008159c4b44dbbfaa443b
Bug-Url: https://bugzilla.redhat.com/1178018
Signed-off-by: Dudi Maroshi <dudi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/profiles/DiskProfileValidator.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
5 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Dudi Maroshi: Verified
Roy Golan: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/37259
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id20106788bdd8a2b0f3008159c4b44dbbfaa443b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Dudi Maroshi <dudi(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months
Change in ovirt-engine[master]: restapi: Validate if the Host exists when calling unregister...
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: restapi: Validate if the Host exists when calling unregistered query
......................................................................
restapi: Validate if the Host exists when calling unregistered query
Adding a validation to check if the host id exists in the setup, once
the user will call unregisteredstoragedomainsdiscover from the REST.
Change-Id: I840c7243161e284f7ae183efd16c3f79a75b07cc
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Looks good to me, approved
Maor Lipchuk: Verified
--
To view, visit http://gerrit.ovirt.org/37257
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I840c7243161e284f7ae183efd16c3f79a75b07cc
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
10 years, 2 months