July 2016 - Engine-commits - oVirt List Archives

Change in ovirt-dwh[master]: build: remove hash from build name
by Shirly Radco 06 Jul '16

06 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: remove hash from build name ...................................................................... build: remove hash from build name Change-Id: Ia064b5d2ac938bb759948d07670eab40a7c7fc12 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M automation/build-artifacts.sh 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60250 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia064b5d2ac938bb759948d07670eab40a7c7fc12 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: engine: Teardown image after verifying upload.
by tnisan＠redhat.com 06 Jul '16

06 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: engine: Teardown image after verifying upload. ...................................................................... engine: Teardown image after verifying upload. When uploading an image finishes, the uploading session is revoked and the image is being verified in VDSM. currently in the revoking function (stopImageTransferSession) there's a call to teardown image, which makes it unreachable to VDSM when trying to verify it. Move the teardown call for after stopping the session. this way only when we finish using the image it will be teared down. If the stopImageTransferSession fails, don't tear down the image, as the session still alive, thus someone might still using it. Change-Id: I7b6587452c2d2879dd97ed2645dd4c348cb0175b Bug-Url: https://bugzilla.redhat.com/1352676 Signed-off-by: Amit Aviram <aaviram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/disk/image/UploadImageCommand.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Jenkins CI: Passed CI tests Amit Aviram: Verified -- To view, visit https://gerrit.ovirt.org/60210 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b6587452c2d2879dd97ed2645dd4c348cb0175b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract balloon info from vm-statistics
by ahadas＠redhat.com 06 Jul '16

06 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract balloon info from vm-statistics ...................................................................... core: extract balloon info from vm-statistics Balloon info is something that is reported by VDSM as part of statistics cycles but it is not persisted in vm_statistics and does not always exists in VmStatistics. This is confusing. Thus, extracting it from VmStatistics to VmInternalData. Change-Id: Idc6d2167561986c907f050c41b277bca7a05acdc Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmTestPairs.java 6 files changed, 25 insertions(+), 26 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60223 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc6d2167561986c907f050c41b277bca7a05acdc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract interface statistics from vm-statistics
by ahadas＠redhat.com 06 Jul '16

06 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract interface statistics from vm-statistics ...................................................................... core: extract interface statistics from vm-statistics Move network interface statistics to VmInternalData instead of VmStatistics. Change-Id: Ieec43d8e02dbff24d67851e277da86d1a7705866 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmTestPairs.java 6 files changed, 45 insertions(+), 37 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Jenkins CI: Passed CI tests Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60222 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieec43d8e02dbff24d67851e277da86d1a7705866 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.6]: build: post ovirt-engine-dwh-3.6.8
by Shirly Radco 06 Jul '16

06 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: post ovirt-engine-dwh-3.6.8 ...................................................................... build: post ovirt-engine-dwh-3.6.8 Change-Id: If10ab5c5f119952cc74c511272126d095f2c2d2f Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M version.mak 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60213 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If10ab5c5f119952cc74c511272126d095f2c2d2f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.6 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-dwh[ovirt-engine-dwh-3.6]: build: ovirt-engine-dwh-3.6.8
by Shirly Radco 06 Jul '16

06 Jul '16

Shirly Radco has submitted this change and it was merged. Change subject: build: ovirt-engine-dwh-3.6.8 ...................................................................... build: ovirt-engine-dwh-3.6.8 updated release notes Change-Id: Iace1262cfc97f7b25989ef38bc37c027ff046064 Signed-off-by: Shirly Radco <sradco(a)redhat.com> --- M ovirt-engine-dwh.spec.in M version.mak 2 files changed, 7 insertions(+), 3 deletions(-) Approvals: Shirly Radco: Verified; Looks good to me, approved; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60212 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iace1262cfc97f7b25989ef38bc37c027ff046064 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-dwh Gerrit-Branch: ovirt-engine-dwh-3.6 Gerrit-Owner: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shirly Radco <sradco(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: Remove redundant null initialization
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove redundant null initialization ...................................................................... webadmin: Remove redundant null initialization Change-Id: I51fa77b9965436dd7b6f38ef59f0eaff8d782b26 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/DiskStatusColumn.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60236 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I51fa77b9965436dd7b6f38ef59f0eaff8d782b26 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[ovirt-engine-4.0]: ui: clarifying diskHotPlugNotSupported tool-tip message
by tnisan＠redhat.com 05 Jul '16

05 Jul '16

Tal Nisan has submitted this change and it was merged. Change subject: ui: clarifying diskHotPlugNotSupported tool-tip message ...................................................................... ui: clarifying diskHotPlugNotSupported tool-tip message Cluster version is not relevant any more for disk hot-plug support. Hence, amending the tool-tip message accordingly. Change-Id: Ibd31395fd566da4192122adf599da5c02d73ecd1 Bug-Url: https://bugzilla.redhat.com/1351636 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Jenkins CI: Passed CI tests -- To view, visit https://gerrit.ovirt.org/60230 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibd31395fd566da4192122adf599da5c02d73ecd1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: ovirt-engine-4.0 Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: core: extract vm-jobs from vm-statistics
by ahadas＠redhat.com 05 Jul '16

05 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: core: extract vm-jobs from vm-statistics ...................................................................... core: extract vm-jobs from vm-statistics VmJobs were wrongly put in VmStatistics. Although it is reported in statistics cycles, it does not represent a statistics of the virtual machine itself but statistics of operations related to it. Therefore, extracting it to VmInternalData instead. Change-Id: Iadda790d07d5f90bea6d113a291446172b722896 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/monitoring/VmAnalyzer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmStatsVdsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/entities/VmInternalData.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/monitoring/VmTestPairs.java 6 files changed, 21 insertions(+), 22 deletions(-) Approvals: Shahar Havivi: Looks good to me, approved Arik Hadas: Verified; Passed CI tests -- To view, visit https://gerrit.ovirt.org/60205 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iadda790d07d5f90bea6d113a291446172b722896 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0

Change in ovirt-engine[master]: webadmin: show template id
by ahadas＠redhat.com 05 Jul '16

05 Jul '16

Arik Hadas has submitted this change and it was merged. Change subject: webadmin: show template id ...................................................................... webadmin: show template id Present the template's ID in its general sub-tab. Change-Id: I1f1e7d68362cdaa0621e9621ace5f11071f545ff Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/template/TemplateGeneralModelForm.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants.properties M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateGeneralModel.java 4 files changed, 22 insertions(+), 3 deletions(-) Approvals: Shahar Havivi: Looks good to me, but someone else must approve Jenkins CI: Passed CI tests Daniel Erez: Looks good to me, approved Arik Hadas: Verified -- To view, visit https://gerrit.ovirt.org/60204 To unsubscribe, visit https://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1f1e7d68362cdaa0621e9621ace5f11071f545ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Jenkins CI Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>

1 0