Change in ovirt-engine-sdk[master]: sdk: restrict .get() methods to id/name
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: restrict .get() methods to id/name
......................................................................
sdk: restrict .get() methods to id/name
restrict .get() methods to id/name as using **kwargs
can produce 1:N results
Change-Id: I6fa14936df6a7a75b11fb20e4d6c3fead02bb15d
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/codegen/collection/collection.py
M src/codegen/imp/imprt.py
M src/codegen/subcollection/subcollection.py
M src/ovirtsdk/api.py
M src/ovirtsdk/infrastructure/brokers.py
M src/ovirtsdk/infrastructure/errors.py
M src/ovirtsdk/utils/filterhelper.py
7 files changed, 564 insertions(+), 477 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/8533
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6fa14936df6a7a75b11fb20e4d6c3fead02bb15d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: core: QuotaManager Test - test 1
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core: QuotaManager Test - test 1
......................................................................
core: QuotaManager Test - test 1
ValidateAndSetStorageQuota test.
Change-Id: I374769dfcc4bb99de2e578d4267fb03484d9c63f
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
1 file changed, 77 insertions(+), 4 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8439
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I374769dfcc4bb99de2e578d4267fb03484d9c63f
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: core : QuotaMnager Test - basic structure
by dfediuck@redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: core : QuotaMnager Test - basic structure
......................................................................
core : QuotaMnager Test - basic structure
Basic structure for QuotaManagerTest
Change-Id: Ie2ff7377f01fdc9de9edb5650cc796e24a8f65c3
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java
2 files changed, 515 insertions(+), 9 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8422
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2ff7377f01fdc9de9edb5650cc796e24a8f65c3
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: webadmin: localize until text (#863294)
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: webadmin: localize until text (#863294)
......................................................................
webadmin: localize until text (#863294)
https://bugzilla.redhat.com/863294
Change-Id: I32e6acb3bb7e25d10060c136f8e3f123c9bd3cc2
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/TasksTree.java
2 files changed, 4 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8452
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32e6acb3bb7e25d10060c136f8e3f123c9bd3cc2
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: restapi: BZ861929 - Don't require template for clone-vm from...
by oliel@redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: BZ861929 - Don't require template for clone-vm from snapshot
......................................................................
restapi: BZ861929 - Don't require template for clone-vm from snapshot
Change-Id: I5e49482c2777c5fd6d0aa97ba2c4e1b37c2bec2e
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java
2 files changed, 77 insertions(+), 63 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8433
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5e49482c2777c5fd6d0aa97ba2c4e1b37c2bec2e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: restapi: #854932 - remove update non-vm disk option
by oliel@redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: #854932 - remove update non-vm disk option
......................................................................
restapi: #854932 - remove update non-vm disk option
Change-Id: I4839d4495925c71e26e0b4a2feae0d82709883b3
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DisksResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java
4 files changed, 25 insertions(+), 19 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8531
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4839d4495925c71e26e0b4a2feae0d82709883b3
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: webadmin: remove domain column from template main grid (#837...
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: webadmin: remove domain column from template main grid (#837025)
......................................................................
webadmin: remove domain column from template main grid (#837025)
https://bugzilla.redhat.com/837025
Change-Id: I5a1a3198d5ff0697d107052e44fc20185e56464b
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabTemplateView.java
2 files changed, 2 insertions(+), 10 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8229
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a1a3198d5ff0697d107052e44fc20185e56464b
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: webadmin: rename Allocation to Space Allocation in new VM di...
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: webadmin: rename Allocation to Space Allocation in new VM dialog (#837025)
......................................................................
webadmin: rename Allocation to Space Allocation in new VM dialog (#837025)
https://bugzilla.redhat.com/837025
Change-Id: Icf2e851113e9788ac0f116c7126f0e72255d1c81
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/vm/VmDiskPopupWidget.java
2 files changed, 2 insertions(+), 5 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8228
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icf2e851113e9788ac0f116c7126f0e72255d1c81
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: webadmin: reorder VMs column display (#837025)
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: webadmin: reorder VMs column display (#837025)
......................................................................
webadmin: reorder VMs column display (#837025)
https://bugzilla.redhat.com/837025
Change-Id: I802da84da1f2e9f5dfd14eac3c21c8fdfb083287
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabVirtualMachineView.java
1 file changed, 18 insertions(+), 18 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I802da84da1f2e9f5dfd14eac3c21c8fdfb083287
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
12 years, 3 months
Change in ovirt-engine[master]: restapi: add direct-lun disk creation signature to meta-data
by oliel@redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: add direct-lun disk creation signature to meta-data
......................................................................
restapi: add direct-lun disk creation signature to meta-data
Change-Id: Ibf776ab1c8a36da6926e1cc32d591a2a2e0a6446
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
1 file changed, 18 insertions(+), 0 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8420
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf776ab1c8a36da6926e1cc32d591a2a2e0a6446
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years, 3 months