Change in ovirt-engine[master]: Revert "engine:Validate maximum number of hosts in DC.(#7716...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: Revert "engine:Validate maximum number of hosts in DC.(#771699)"
......................................................................
Revert "engine:Validate maximum number of hosts in DC.(#771699)"
This reverts commit bdd78019337a8757f3a0fe5aa2ea6abd12b105f8
Additional fixes are required for this patch,
will be re-pushed later.
Change-Id: I05c334738864796c33c01fe3b6940088d3fdb11f
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
5 files changed, 26 insertions(+), 47 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8316
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I05c334738864796c33c01fe3b6940088d3fdb11f
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: Fix HotPlugDiskToVm command test
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Fix HotPlugDiskToVm command test
......................................................................
core: Fix HotPlugDiskToVm command test
Change-Id: I3b881c2328d8cf10f6d7bd831f426d437d9b749d
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
2 files changed, 9 insertions(+), 1 deletion(-)
Approvals:
Tal Nisan: Verified
Allon Mureinik: Looks good to me, but someone else must approve
Asaf Shakarchi: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8313
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3b881c2328d8cf10f6d7bd831f426d437d9b749d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: Display the single status of domains in main tab.
by asaf＠redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: webadmin: Display the single status of domains in main tab.
......................................................................
webadmin: Display the single status of domains in main tab.
Create a new view (storage_domains_for_search) which contains storage
domains specifically entries used by search, the view contains the
status per storage domain, for domains (ISO) that are attached to more than one pool,
a null value will be displayed in the status field.
Search now uses the new created domains view described above.
In WebAdmin main storage domain tab, for ISO domain, the shared (cross
pool) status is displayed, otherwise the domain's status is used.
Change-Id: If18c028dfcb985fd96f302b53401c1082a349416
Bug-Url: https://bugzilla.redhat.com/852100
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M backend/manager/dbscripts/create_views.sql
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabStorageView.java
3 files changed, 34 insertions(+), 5 deletions(-)
Approvals:
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8258
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If18c028dfcb985fd96f302b53401c1082a349416
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: Forbid attaching a locked disk to a VM
by asaf＠redhat.com
Asaf Shakarchi has submitted this change and it was merged.
Change subject: core: Forbid attaching a locked disk to a VM
......................................................................
core: Forbid attaching a locked disk to a VM
- Forbid attaching a locked disk to a VM.
- Replaced message key 'ACTION_TYPE_FAILED_VM_IMAGE_IS_LOCKED' which was
intended for many disks to 'ACTION_TYPE_FAILED_DISKS_ARE_LOCKED as
it's more appropriate.
- Added a new messge key (ACTION_TYPE_FAILED_DISK_IS_LOCKED) for
single disk.
- Filtered disks which are in lock state from
'GetAllAttachableDisksByPoolId' stored procedure in order to filter locked
disks in webadmin when attaching an existing disk to a VM.
Bug-Url: https://bugzilla.redhat.com/856137
Change-Id: I109654547b68da245a5fdc2b2188feedd45c2ca7
Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com>
---
M backend/manager/dbscripts/all_disks_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_de.properties
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_it.properties
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors_nl.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
14 files changed, 39 insertions(+), 22 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Allon Mureinik: Looks good to me, but someone else must approve
Asaf Shakarchi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8167
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I109654547b68da245a5fdc2b2188feedd45c2ca7
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: webadmin: added missing b.e. to common.gwt.xml
by ecohen＠redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: added missing b.e. to common.gwt.xml
......................................................................
webadmin: added missing b.e. to common.gwt.xml
Added missing business entities classes to Common.gwt.xml:
BusinessEntityGuidComparator.java and BusinessEntityComparator.java
(the dependency created by http://gerrit.ovirt.org/#/c/8273/)
Change-Id: I475ded325ddc98cc501b7c860a2a0d3aa939698c
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8309
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I475ded325ddc98cc501b7c860a2a0d3aa939698c
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: Disabling plug disks command during snapshoting (#8444...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Disabling plug disks command during snapshoting (#844440)
......................................................................
core: Disabling plug disks command during snapshoting (#844440)
Lock the VM entity when taking a snapshot to avoid plug/unplug disk
command to run and fail during the action
Bug-Url: https://bugzilla.redhat.com/844440
Change-Id: I4980c8cff7aec9bd10bba344f9592bbbf1c20b8d
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommand.java
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Tal Nisan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8298
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4980c8cff7aec9bd10bba344f9592bbbf1c20b8d
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: Added storage pool name to VDS non operational log (#8...
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: core: Added storage pool name to VDS non operational log (#854210)
......................................................................
core: Added storage pool name to VDS non operational log (#854210)
Added storage pool name to the storage domain not accessible audit log
in SetVDSNonOperational command
Bug-Url: https://bugzilla.redhat.com/854210
Change-Id: I18abfa25c762a19bb65f65d62b310fe22bea1aaf
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
2 files changed, 11 insertions(+), 7 deletions(-)
Approvals:
Tal Nisan: Verified
Michael Kublin: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8306
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I18abfa25c762a19bb65f65d62b310fe22bea1aaf
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: ordering getAllFromVms
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: ordering getAllFromVms
......................................................................
core: ordering getAllFromVms
This patch sets an ascending order to getAllFromVms
stored procedure.
This ordering matches the ordering of Vm related entities
at java code (also based on ascending order)
Change-Id: I5a5958e870d3315316a59e1038101b2511bd8811
Bug-Url: https://bugzilla.redhat.com/861705
signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/dbscripts/vms_sp.sql
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8274
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5a5958e870d3315316a59e1038101b2511bd8811
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: order collections at updateAllInTransaction
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: order collections at updateAllInTransaction
......................................................................
core: order collections at updateAllInTransaction
This patch sorts all collections at UpdateAllInTransaction in order
to prevent dead lock during updates (see for example updateAllInTransaction
for vmStatistics and the code at ResourceManager.init).
Change-Id: I979cb7d2273c2eaaa2866dcb4a5f760f9266e11a
Bug-Url: https://bugzilla.redhat.com/861705
signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDevice.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmDynamic.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmNetworkStatistics.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmStatistics.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
6 files changed, 31 insertions(+), 12 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8273
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I979cb7d2273c2eaaa2866dcb4a5f760f9266e11a
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 6 months
Change in ovirt-engine[master]: core: Introducing Business Entity comparators
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Introducing Business Entity comparators
......................................................................
core: Introducing Business Entity comparators
Introducing helper classes for basic logic of
Business Entities comparisson, based on ID
comparisson.
Change-Id: I979cb7d2273c2eaaa2866dcb4a5f760e9266e11a
Bug-Url: https://bugzilla.redhat.com/861705
Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com>
---
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntityComparator.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntityGuidComparator.java
2 files changed, 31 insertions(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8290
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I979cb7d2273c2eaaa2866dcb4a5f760e9266e11a
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 6 months