October 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: packaging: Validate configuration directory exists before fi...

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Validate configuration directory exists before files creation ...................................................................... packaging: Validate configuration directory exists before files creation Before this patch, engine-upgrade used to copy new files into his configuration directory, without validating that is really exists, which could cause a nasty IOError. Change-Id: Ie4f9f0868568ce56fcfc9566a0adb2b07736b3af Signed-off-by: Ofer Schreiber <oschreib(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 5 insertions(+), 0 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8340 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie4f9f0868568ce56fcfc9566a0adb2b07736b3af Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Interface Name Custom Value (#861867)

by msalem＠redhat.com

Muli Salem has submitted this change and it was merged. Change subject: core: Interface Name Custom Value (#861867) ...................................................................... core: Interface Name Custom Value (#861867) This patch changes RemoveVmTemplateInterfaceParameters not to send a VmNetworkInterface object, but rather only the interface Id. It also fetches the Interface Name from the Db, instead of from the params. Change-Id: I985261c9517efa52673145ffb8d29bd537c08ed9 Bug-Url: https://bugzilla.redhat.com/861867 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/RemoveVmTemplateInterfaceParameters.java 3 files changed, 15 insertions(+), 27 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8334 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I985261c9517efa52673145ffb8d29bd537c08ed9 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: add alias property to disk and deprecate name

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: add alias property to disk and deprecate name ...................................................................... restapi: add alias property to disk and deprecate name https://bugzilla.redhat.com/show_bug.cgi?id=859897 Change-Id: Ia93d9abd29e51239f64ae1b43306d44f10ae7af5 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/DiskMapper.java 3 files changed, 10 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia93d9abd29e51239f64ae1b43306d44f10ae7af5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: RSDL does not document VM CPU pinning #856508

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL does not document VM CPU pinning #856508 ...................................................................... restapi: RSDL does not document VM CPU pinning #856508 https://bugzilla.redhat.com/show_bug.cgi?id=856508 Change-Id: I911e95301dd11010f52f9434dac6a145a037bc09 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8323 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I911e95301dd11010f52f9434dac6a145a037bc09 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: RSDL missing method for removing VM from storage do...

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: RSDL missing method for removing VM from storage domain #858618 ...................................................................... restapi: RSDL missing method for removing VM from storage domain #858618 This commit treats both SD vm & template which where lacking RSDL signature https://bugzilla.redhat.com/show_bug.cgi?id=858618 Change-Id: I8f03abcfd2c3d05eebacdc356916fb9657eaf1b3 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/StorageDomainResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendStorageDomainResource.java 3 files changed, 23 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8318 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f03abcfd2c3d05eebacdc356916fb9657eaf1b3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: remove unused import

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: remove unused import ...................................................................... packaging: remove unused import Change-Id: Ic1a884cbcaee6f39ad782dcc567f645501fd1296 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 0 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8342 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic1a884cbcaee6f39ad782dcc567f645501fd1296 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: fix typo in exception

by juan.hernandez＠redhat.com

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: fix typo in exception ...................................................................... packaging: fix typo in exception Change-Id: Ia02875f749386216690c6e2d25e63432219603a0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8341 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia02875f749386216690c6e2d25e63432219603a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix task parame creation regression (862799)

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: Fix task parame creation regression (862799) ...................................................................... core: Fix task parame creation regression (862799) A careless refactoring introduced a regression that disallowed creating tasks for external commands. This patch fixes it, and restores the previous behaviour (albeit in a streamlined, readable, manner, that does not involve copy-pasting the same block of code over and over). Change-Id: I71290e58978b680dbbbf88b024a19482b637a91b Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=862799 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java 1 file changed, 3 insertions(+), 7 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8339 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I71290e58978b680dbbbf88b024a19482b637a91b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Adjust mac address field size

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: webadmin: Adjust mac address field size ...................................................................... webadmin: Adjust mac address field size The patch adjusts the column width of longer than standard mac address field and show the entire content of it as a tool tip. Change-Id: I9f7736300652a20dcd6e785e6836de66c4d97f0c Bug-Url: https://bugzilla.redhat.com/823397 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/InterfacePanel.java A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/LabelWithToolTip.java 2 files changed, 24 insertions(+), 1 deletion(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f7736300652a20dcd6e785e6836de66c4d97f0c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Itzik Brown <itzikb(a)mellanox.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

11 years, 6 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Extend host mac address to support IB HCA

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: engine: Extend host mac address to support IB HCA ...................................................................... engine: Extend host mac address to support IB HCA The host mac address field is extended to 59 so it could store InfiniBand HCA mac address. Change-Id: I680782190ea107b76c3bc714e765dd0ce00eea65 Bug-Url: https://bugzilla.redhat.com/823397 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1430_extend_host_mac_address_size.sql 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I680782190ea107b76c3bc714e765dd0ce00eea65 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Itzik Brown <itzikb(a)mellanox.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 6 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits October 2012