October 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: [DC Guide me] Host in one cluster should be displa...
by alkaplan＠redhat.com 03 Oct '12

03 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: [DC Guide me] Host in one cluster should be displayed in others ...................................................................... webadmin: [DC Guide me] Host in one cluster should be displayed in others https://bugzilla.redhat.com/856504 - If the host is configured in one of the dc's clusters it should be displayed in the others. - If there is at least one host in the dc, the select host should be in the optional area. (There is no need to check if the host is supported by any cluster). Change-Id: I800345a112aff8b4c913d9eed93e2f70d1f560d0 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java 2 files changed, 5 insertions(+), 8 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I800345a112aff8b4c913d9eed93e2f70d1f560d0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal, webadmin: Japanese locale support
by vszocs＠redhat.com 03 Oct '12

03 Oct '12

Vojtech Szocs has submitted this change and it was merged. Change subject: userportal,webadmin: Japanese locale support ...................................................................... userportal,webadmin: Japanese locale support Added support for Japanese locale to WebAdmin and UserPortal. This patch contains: - Japanese properties files for all the localized texts in the application - Tweaks to the gwt.xml files to compile permutations also for Japanese There are currently two locales (languages) supported by both applications: - English, mapped to "default" GWT locale - Japanese, mapped to "ja" GWT locale By default, only default (English) locale is used during GWT compilation. You can override this default behavior using "gwt.locale" property: mvn clean install -Pgwt-admin,gwt-user -Dgwt.locale=default,ja Or you can simply use "all-langs" profile to use all locales: mvn clean install -Pgwt-admin,gwt-user,all-langs Bug-Url: https://bugzilla.redhat.com/862370 Change-Id: I1c208ef4569eba4cd6ac07f064baf92f7504d18d Signed-off-by: Einav Cohen <ecohen(a)redhat.com> --- A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationConstants_ja.properties A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/CommonApplicationMessages_ja.properties A frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Constants_ja.properties A frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums_ja.properties A frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Messages_ja.properties A frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/SpiceRedKeys_ja.properties M frontend/webadmin/modules/userportal-gwtp/pom.xml A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja.properties A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/ConsoleErrors_ja.properties A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_ja.properties A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationConstants_ja.properties A frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/ApplicationMessages_ja.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/userportal/UserPortal.gwt.xml M frontend/webadmin/modules/webadmin/pom.xml A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja.properties A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/ConsoleErrors_ja.properties A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors_ja.properties A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationConstants_ja.properties A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/ApplicationMessages_ja.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/WebAdmin.gwt.xml 20 files changed, 4,496 insertions(+), 8 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Vojtech Szocs: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8312 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1c208ef4569eba4cd6ac07f064baf92f7504d18d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: fix failing RunVmCommandTest
by tjelinek＠redhat.com 03 Oct '12

03 Oct '12

Tomas Jelinek has submitted this change and it was merged. Change subject: engine: fix failing RunVmCommandTest ...................................................................... engine: fix failing RunVmCommandTest Fixed failing tests. The patch 53d8f8a731aef88de1cb6c7c5011cf2de243ae71 caused test failures. The RunVmCommandTest expected that if the params are not null, they will be set. Changed that the test does not set the params, but the VM itself. Change-Id: Icf07dad1b910af31a8c1f79a06a3fc06586f7de6 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RunVmCommandTest.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Tomas Jelinek: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icf07dad1b910af31a8c1f79a06a3fc06586f7de6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Rename allow_reconnect to allow_override
by juan.hernandez＠redhat.com 03 Oct '12

03 Oct '12

Juan Hernandez has submitted this change and it was merged. Change subject: restapi: Rename allow_reconnect to allow_override ...................................................................... restapi: Rename allow_reconnect to allow_override Several people have expressed their preference for allow_override instead allow_reconnect in the name of the property that defines if a user can connecto to a display when there is already another user connected. Change-Id: Ida77e6591f6108c2d3c0a36fbec35f64f94ac32b Bug-Url: https://bugzilla.redhat.com/856512 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/TemplateMapper.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/TemplateMapperTest.java M backend/manager/modules/restapi/types/src/test/java/org/ovirt/engine/api/restapi/types/VmMapperTest.java 6 files changed, 15 insertions(+), 15 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8325 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida77e6591f6108c2d3c0a36fbec35f64f94ac32b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Allowing to change otpValidity when in maintenance (#8...
by oourfali＠redhat.com 03 Oct '12

03 Oct '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Allowing to change otpValidity when in maintenance (#862299) ...................................................................... core: Allowing to change otpValidity when in maintenance (#862299) https://bugzilla.redhat.com/show_bug.cgi?id=862299 We should be able to change the otpValidity when the host is in maintenance mode. This patch makes the proper fixes in order to allow that. Change-Id: Ia8d43be7af9608bc785a811bcfe81a976b156c7a Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsHandler.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8324 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia8d43be7af9608bc785a811bcfe81a976b156c7a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Guide me- select host doesn't show all the needed ...
by alkaplan＠redhat.com 03 Oct '12

03 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Guide me- select host doesn't show all the needed hosts(#856504) ...................................................................... webadmin: Guide me- select host doesn't show all the needed hosts(#856504) https://bugzilla.redhat.com/856504 - If a host is configured in one of the dc's clusters, all the other clusters in the dc should show the host in their guide me- select hosts. - If there are clusters in the dc that their version is supported by a host, the host should be in their select host list. (Until now, if one of the clusters didn't support the host, the host wasn't shown in all the dc clusters lists). Change-Id: I6c28984f21a795c48e3c7fa4a9669ec269922337 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java 2 files changed, 10 insertions(+), 34 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8327 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6c28984f21a795c48e3c7fa4a9669ec269922337 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: 4.9.6 vdsm version is considered as 3.0 instead of...
by alkaplan＠redhat.com 03 Oct '12

03 Oct '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: 4.9.6 vdsm version is considered as 3.0 instead of 3.1 (#856507) ...................................................................... webadmin: 4.9.6 vdsm version is considered as 3.0 instead of 3.1 (#856507) https://bugzilla.redhat.com/856507 All 4.9 vdsm versions are considered as 3.0 except 4.9.6. In the webadmin there was a bug, and 4.9.6 was also considered as 3.0. It caused the guide me to avoid adding 4.9.6 host to 3.1 cluster. Also, when selecting host in Cluster guide me and clicking cancel, and then clicking on select host again there was an exception because the dc d.m was reseted when canceling the selecet window. Change-Id: I216c78c6882c9ef18d28950b5889e8d9793f3b4e Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/Extensions.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/common/AboutModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/MoveHost.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/label/VersionLabel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/renderer/VersionRenderer.java 8 files changed, 68 insertions(+), 99 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I216c78c6882c9ef18d28950b5889e8d9793f3b4e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix "Expand All" button on system tree (#856233)
by achub＠redhat.com 03 Oct '12

03 Oct '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Fix "Expand All" button on system tree (#856233) ...................................................................... webadmin: Fix "Expand All" button on system tree (#856233) https://bugzilla.redhat.com/856233 Change-Id: I8ec0be0b6b2249fe4ef9af3e0214b031cdb8dbcc Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java 1 file changed, 10 insertions(+), 0 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8322 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8ec0be0b6b2249fe4ef9af3e0214b031cdb8dbcc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ConnectHostToStoragePoolServersCommand is not called w...
by mkublin＠redhat.com 03 Oct '12

03 Oct '12

Michael Kublin has submitted this change and it was merged. Change subject: core: ConnectHostToStoragePoolServersCommand is not called when cluster is added to existing datacenter ...................................................................... core: ConnectHostToStoragePoolServersCommand is not called when cluster is added to existing datacenter The following patch will prevent of adding of cluster to new data center if one of the host in cluster has status Up. 1. The patch fixing a bug 2. Performing clean up of code 3. Fixing bug with update of virt service 4. Adds some performance improvements Change-Id: I05343b232f565b1b829645795bf804e246a405fd Bug-Url: NA Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 136 insertions(+), 147 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8320 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I05343b232f565b1b829645795bf804e246a405fd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Make Gluster Actions Lowercase
by oliel＠redhat.com 03 Oct '12

03 Oct '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Make Gluster Actions Lowercase ...................................................................... restapi: Make Gluster Actions Lowercase Change-Id: I27f6df1ce17821cb56220d71f4f4c2828e82fa96 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/gluster/GlusterVolumeResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8294 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27f6df1ce17821cb56220d71f4f4c2828e82fa96 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0