November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: add release_suffix variable to spec
by juan.hernandez＠redhat.com 28 Nov '12

28 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: add release_suffix variable to spec ...................................................................... packaging: add release_suffix variable to spec This will allow simpler jenkins automatic build to be able to add the git hash as release suffix. Example: $ rpmbuild -tb -D "release_suffix ${git_head}" ovirt-engine-3.1.0.tar.gz Change-Id: I080ee4b74790fe880b32fbab48050c078698527e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9444 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I080ee4b74790fe880b32fbab48050c078698527e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Query getdisksvmguid caused postmaster processes to ...
by mkublin＠redhat.com 28 Nov '12

28 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Query getdisksvmguid caused postmaster processes to consume constantly 100%cpu. ...................................................................... engine: Query getdisksvmguid caused postmaster processes to consume constantly 100%cpu. The following bug occurrs because of the following query being run from GetVmStatsVDSCommand every running VM in the system. The run is cyclic and runs in infinitive loop. I don't see reason of that query, update of dynamic data ofor disc is done under lock, in worst case the dynamic data will be updated with wrong values, in next run which occurring every 4 seconds, the disk will be updated with correct values. I think we can live with wrong values for 4 seconds in case of race The change reduced CPU of machine with DB from 100% to 30%, which is still a high, but better Change-Id: I9ef4a24908a75ab4fc1f02eed7c97a7125a5db41 Bug-Url: https://bugzilla.redhat.com/879930 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerObjectsBuilder.java 1 file changed, 22 insertions(+), 37 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9468 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9ef4a24908a75ab4fc1f02eed7c97a7125a5db41 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Perfromance improvements at IrsBrokerCommand
by mkublin＠redhat.com 28 Nov '12

28 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Perfromance improvements at IrsBrokerCommand ...................................................................... engine: Perfromance improvements at IrsBrokerCommand The following patch is removing unneeded query for storage pool. The objects can be passed to methods and not retrieved again from DB Change-Id: I9b6054950b45793a8f37e7f8b261dbd315ff6859 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 86 insertions(+), 90 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9469 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b6054950b45793a8f37e7f8b261dbd315ff6859 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix storage quota release on stopStatelessVm
by dfediuck＠redhat.com 27 Nov '12

27 Nov '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Fix storage quota release on stopStatelessVm ...................................................................... core: Fix storage quota release on stopStatelessVm StopVmBase was defined QuotaStorageDependent and the getQuotaStorageConsumptionParameters() was implemented to handle cases a stateless vm is stopped (vm images are deleted). Change-Id: I7088b94cd716bb93b2a4813963a980f4eab9e597 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java 2 files changed, 22 insertions(+), 2 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9470 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7088b94cd716bb93b2a4813963a980f4eab9e597 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Quota Dependency Test + RemoveSnapshot fix
by dfediuck＠redhat.com 27 Nov '12

27 Nov '12

Doron Fediuck has submitted this change and it was merged. Change subject: core: Quota Dependency Test + RemoveSnapshot fix ...................................................................... core: Quota Dependency Test + RemoveSnapshot fix Added a test that checks that is VdcActionType is defined quota dependent - the correlating command is implementing the correct interface. RemoveSnapshotCommand did not implement QuotaStorageDependent. Fixed: implementation added. Change-Id: Ifd9e215abaa5de0fc03dae0609d9dc3ffc957f55 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaDependencyTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java 4 files changed, 106 insertions(+), 33 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifd9e215abaa5de0fc03dae0609d9dc3ffc957f55 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Changed edit VM disk to use run single action (#84...
by tnisan＠redhat.com 27 Nov '12

27 Nov '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Changed edit VM disk to use run single action (#848806) ...................................................................... webadmin: Changed edit VM disk to use run single action (#848806) The edit VM disk command in uicommon used run multiple actions for no reason due to this the VM disks list was not refreshed after the command excution and waited for the next timer interval to refresh, this caused the update data to appear only after a few seconds instead of immediately Change-Id: I75f4ebe1f20ce8e924f2d5d79ab1b1b6e3d6ef27 Bug-Url: https://bugzilla.redhat.com/848806 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 8 insertions(+), 13 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9467 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I75f4ebe1f20ce8e924f2d5d79ab1b1b6e3d6ef27 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in samples-portals[master]: typo fix: Action Faild
by shavivi＠redhat.com 27 Nov '12

27 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: typo fix: Action Faild ...................................................................... typo fix: Action Faild Change-Id: Ibc3e1bde594301367cc4e67990e96ac249b46d7a Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M python/WebHandler.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9502 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc3e1bde594301367cc4e67990e96ac249b46d7a Gerrit-PatchSet: 1 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in samples-portals[master]: Python Sample: first commit
by shavivi＠redhat.com 27 Nov '12

27 Nov '12

Shahar Havivi has submitted this change and it was merged. Change subject: Python Sample: first commit ...................................................................... Python Sample: first commit Working sample of Python user portal using REST API Change-Id: I1d15dd5df8992c84b2c9529168919d05ba88bc33 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- A python/Broker.py A python/README A python/RestClient.py A python/RestCommand.py A python/WebHandler.py A python/ovirt.conf 6 files changed, 422 insertions(+), 0 deletions(-) Approvals: Shahar Havivi: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9387 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1d15dd5df8992c84b2c9529168919d05ba88bc33 Gerrit-PatchSet: 3 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in samples-portals[master]: Typo fix in user VMs table
by oourfali＠redhat.com 27 Nov '12

27 Nov '12

Oved Ourfali has submitted this change and it was merged. Change subject: Typo fix in user VMs table ...................................................................... Typo fix in user VMs table Change-Id: Ic7329f6c4c2935c6ae59bc8f8fc2c811b2304384 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M python/WebHandler.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9438 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7329f6c4c2935c6ae59bc8f8fc2c811b2304384 Gerrit-PatchSet: 1 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: better general VDSM exception handling
by rgolan＠redhat.com 27 Nov '12

27 Nov '12

Roy Golan has submitted this change and it was merged. Change subject: core: better general VDSM exception handling ...................................................................... core: better general VDSM exception handling refactor error translation to separate network exceptions and protocol exception so error on XML formatting could be propagated and logged correctly. Change-Id: Id2391ec81626cd984f64b9a738adca9be4116d5a Signed-off-by: Roy Golan <rgolan(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/875725 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsBrokerCommand.java 3 files changed, 14 insertions(+), 20 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9479 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2391ec81626cd984f64b9a738adca9be4116d5a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:End failed live snapshot with warning.
by mlipchuk＠redhat.com 27 Nov '12

27 Nov '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:End failed live snapshot with warning. ...................................................................... core:End failed live snapshot with warning. Engine fails to create Live-Snapshot during power off of VM. This is since the KVM process might be killed in the middle of the process and the synchronization between the engine VM and the KVM process in the VDSM are not reliable and could be racy. The proposed solution is to avoid the rollback of the entire operation, but instead finish the command with success, and add an appropriate audit log. That way will allow the VM to be configured to the new snapshot at the next run. Change-Id: I1b7f841d3fa02800fd58590c87d64e31227adfe5 Signed-Off-By: Maor Lipchuk <mlipchuk(a)redhat.com> Bug-Url: https://bugzilla.redhat.com/870928 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 15 insertions(+), 7 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9390 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1b7f841d3fa02800fd58590c87d64e31227adfe5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change "Active" vnic to "Plugged"
by alkaplan＠redhat.com 27 Nov '12

27 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Change "Active" vnic to "Plugged" ...................................................................... webadmin: Change "Active" vnic to "Plugged" - VmInterface Dialog -change Activate checkobox to radio button- "Card Status". - Add plugged column to VM->VM Interface table. - Changed "Activated" property om VmInterfaceModel to "Plugged". Change-Id: Ib42f1e622ee1b55e65a6ec274e762cea9a08d531 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationResources.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java R frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/template/TemplateNetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseInterfaceListModelTable.java A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/network/icn_plugged.png A frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/ui/common/images/network/icn_un_plugged.png M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceListModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmInterfaceModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/AbstractNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/cluster/ClusterManageNetworkPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/vm/VmInterfacePopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineNetworkInterfaceView.java 18 files changed, 249 insertions(+), 78 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib42f1e622ee1b55e65a6ec274e762cea9a08d531 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix Moving Disk message (#856082)
by amureini＠redhat.com 27 Nov '12

27 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix Moving Disk message (#856082) ...................................................................... core: Fix Moving Disk message (#856082) Log message notifying about moving disk said "moveing", and is now corrected to "moving". The original message used ${Action}ing. The current one uses ${Action}, and MoveOrCopyDiskCommand is replacing it with Moving or Copying according to the operation taking place. Change-Id: I53bb3238d1a5e6b3e966adf488a10946e252ffe3 Bug-Url: https://bugzilla.redhat.com/856082 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/9303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53bb3238d1a5e6b3e966adf488a10946e252ffe3 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: DB upgrade from 3.0 to 3.1 fails(#880350)
by emesika＠redhat.com 27 Nov '12

27 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: DB upgrade from 3.0 to 3.1 fails(#880350) ...................................................................... core: DB upgrade from 3.0 to 3.1 fails(#880350) upgrade from 3.0.x to 3.1 failed in 2 points ; 1) 03_01_0950 Reason : script assumes that a storage is in only one DC and attempt to insert duplicate rows that violates primary key to the permission table Solution: check before inserting to permissions table that record with the same key does not exist 2) 03_01_1020 Reason :script adds a column_id column to the async_tasks table. Since this column type is UUID and is defined as NOT NULL, the addition will fail if at the point that this upgrade script is running the table is not empty Solution : Create the column with an empty UUID (00000.....000000) DEFAULT After this column was added , drop the default. Change-Id: Id9658673c16610da4a25e33c7969bcde61a64259 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/03_01_0950_add_permissions_on_storage_to_users.sql M backend/manager/dbscripts/upgrade/03_01_1020_add_command_id_to_async_tasks_table.sql 2 files changed, 14 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9500 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9658673c16610da4a25e33c7969bcde61a64259 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: [es_ES] heading "Virtual size" is truncated in Spa...
by oourfali＠redhat.com 27 Nov '12

27 Nov '12

Oved Ourfali has submitted this change and it was merged. Change subject: webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379) ...................................................................... webadmin: [es_ES] heading "Virtual size" is truncated in Spanish (#871379) https://bugzilla.redhat.com/871379 Increased the size of the "Virtual Size" column to fit all locales. Verified on all locales. Change-Id: Ie71097c4fae81753135eec2b28702ca9bf822f41 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alona Kaplan: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/9505 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie71097c4fae81753135eec2b28702ca9bf822f41 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unused private method from CommonVmPoolWithVmsC...
by lhornyak＠redhat.com 26 Nov '12

26 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: remove unused private method from CommonVmPoolWithVmsCommand ...................................................................... core: remove unused private method from CommonVmPoolWithVmsCommand getQuotaId is not used Change-Id: I715d25fe1bd99a5c0af435c4ad0dcd207d1a0aa6 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9393 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I715d25fe1bd99a5c0af435c4ad0dcd207d1a0aa6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: db - fixing wrong nfs_version argument in storage_san....
by rgolan＠redhat.com 26 Nov '12

26 Nov '12

Roy Golan has submitted this change and it was merged. Change subject: core: db - fixing wrong nfs_version argument in storage_san.sp ...................................................................... core: db - fixing wrong nfs_version argument in storage_san.sp 67761e1f513bdd17915ba7a47a6597ab23c4326d refactored nfs_version type and the insert sp but missed the update. Change-Id: Id9a2f060164f17e01db30f84bdf87a91c9b25769 Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/dbscripts/storages_san_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9459 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9a2f060164f17e01db30f84bdf87a91c9b25769 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: upgrade from 3.0.7 to SI24.4 fail(#879918)
by emesika＠redhat.com 26 Nov '12

26 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: upgrade from 3.0.7 to SI24.4 fail(#879918) ...................................................................... upgrade from 3.0.7 to SI24.4 fail(#879918) upgrade from 3.0.7 to SI24.4 fails: ERROR: insert or update on table vm_device violates foreign key constraint fk_vm_device_vm _static This bug is a result of missing FK between vmt_guid in vm_interface and vm_guid in vm_static. This cause junk interface left in vm_interface when a template that has interfaces is removed. Since in upgrade from 3.0 to 3.1 we added the vm_device table, there is an attempt to insert those junk interfaces to vm_device that fails on the FK constraint between vm_device and vm_static. This patch fix the bug by: 1) Fixing the upgrade script to cleanup those junk interfaces before an attempt to insert it to vm_device is done. 2) Adds the missing FK between vm_interface and vm_static to prevent junk data in future. Change-Id: Iaf4af7908566b5d16e39ea5167c6d6dffc5884db Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/03_01_0440_vm_device_upgrade_data.sql A backend/manager/dbscripts/upgrade/03_01_1520_add_fk_vm_interface_vm_static_template.sql 2 files changed, 9 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9462 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaf4af7908566b5d16e39ea5167c6d6dffc5884db Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: skip quota for flows with no storage pool
by rgolan＠redhat.com 26 Nov '12

26 Nov '12

Roy Golan has submitted this change and it was merged. Change subject: core: skip quota for flows with no storage pool ...................................................................... core: skip quota for flows with no storage pool Quota checks are being made based on a commands "quota dependency" which is being marked by an enum on the VdcActionType. The problem is that some commands, e.g. AddDisk may need quota check on regular disk but not on external floating LUN disk, mainly because this command will not have a storage pool (floating disk doesn't belong to a data center) thus - no quota could be calculated on it. As a way out, instead of breaking a command to two, (one quotable and one not) an empty list of quota params can be submitted so no quota checks will be made. Change-Id: Ie468db3709522653cd93c338564592e2ba439c4a Signed-off-by: Roy Golan <rgolan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java 2 files changed, 15 insertions(+), 7 deletions(-) Approvals: ofri masad: Looks good to me, but someone else must approve Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9410 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie468db3709522653cd93c338564592e2ba439c4a Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix NPE on Clone VM from Snapshot
by mlipchuk＠redhat.com 25 Nov '12

25 Nov '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Fix NPE on Clone VM from Snapshot ...................................................................... core: Fix NPE on Clone VM from Snapshot Clone VM from snapshot throw NPE while using MoveOrCopyImageGroup. This happens since AddVmFromSnapshot creates the task first with the parameters and only after that it creates the disk in the DB. The proposed fix is to get the wipeAfterDelete flag from the parameters in case the destination disk is null. This fix should be revisited, to change the AddVmFromSnapshot to create the disk before the creation of task. Change-Id: I2c18b1ac552f598fc20e74aa67f81dabb915a8c2 Signed-Off-By: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9445 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2c18b1ac552f598fc20e74aa67f81dabb915a8c2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfReader cleanup - remove unused parameter
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader cleanup - remove unused parameter ...................................................................... core: OvfReader cleanup - remove unused parameter Removed the vmDevice parameter from the getResourceType method. This method is private, and the parameter is not used, so we can be sure it is not required. Change-Id: Iaa9872617cc62539b2b8c33c5dbe2df21db355bb Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9307 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iaa9872617cc62539b2b8c33c5dbe2df21db355bb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfReader cleanup - correct DiskImage method
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader cleanup - correct DiskImage method ...................................................................... core: OvfReader cleanup - correct DiskImage method Replaced the usage of the deprecated DiskImage.set_imagegroup_id(Guid) with the newer DiskImage.setId(Guid) which it delegated to. Change-Id: I9b8f472eafe2ba98e8925508e6097b7093a70764 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9306 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9b8f472eafe2ba98e8925508e6097b7093a70764 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfReader cleanup - remove StringHelper
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader cleanup - remove StringHelper ...................................................................... core: OvfReader cleanup - remove StringHelper Removed usages of the deprecated StringHelper and replaced them with standard calls. * StringHelper.isNullOrEmpty(String) was replaced with apache commons' standard StringUtils.isEmpty(String). * StringHelper.EqOp(String, constant) was replaced with Java's standard constant.equals(String) Change-Id: I22f49eb0eec5c9849a4a2242a51ba0217718f0d1 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 29 insertions(+), 30 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22f49eb0eec5c9849a4a2242a51ba0217718f0d1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: OvfReader cleanup - document empty blocks
by amureini＠redhat.com 25 Nov '12

25 Nov '12

Allon Mureinik has submitted this change and it was merged. Change subject: core: OvfReader cleanup - document empty blocks ...................................................................... core: OvfReader cleanup - document empty blocks Documented the empty implementation of buildNetworks() and readSnapshostsSection(String) to avoid warnings by code analysis tools (e.g., Eclipse IDE's built-in inspection feature). Change-Id: I619991e6ebbbffac6c99a1ab2a98fa27aa57dadd Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfReader.java 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9304 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I619991e6ebbbffac6c99a1ab2a98fa27aa57dadd Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Replaced quartz job to thread job at MigrateVDSComma...
by mkublin＠redhat.com 25 Nov '12

25 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Replaced quartz job to thread job at MigrateVDSCommand ...................................................................... engine: Replaced quartz job to thread job at MigrateVDSCommand Because of we have more threads at the system and it is more covinient to open a thread instead of quarzt job with zero delay Change-Id: I7699a8d8e931ff336335d476fc4fc9251715b4fd Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/MigrateVDSCommand.java 1 file changed, 41 insertions(+), 52 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7699a8d8e931ff336335d476fc4fc9251715b4fd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0