November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: utils: move Tar, CachedTar classes to own package
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: move Tar, CachedTar classes to own package ...................................................................... utils: move Tar, CachedTar classes to own package Change-Id: Ic0227d540ede0be17f5803e3046092a7317207fc Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/CachedTar.java R backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/Tar.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java 4 files changed, 5 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9245 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0227d540ede0be17f5803e3046092a7317207fc Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: ssh: move to member '_' convention
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: ssh: move to member '_' convention ...................................................................... utils: ssh: move to member '_' convention We had several discussion over this. Convention for members/static/globals is very helpful when dealing with patch hunk and review, as every variable can be assigned to proper context without reading the whole code. It also avoid naming clashes between the different scope level. I am aware that some people are not used to variable name convention, however it is much easier to maintain and review patches in this mode. I am enforcing this convention on bootstrap and ssh sources, and I hope that others will see the benefit in this method as well. Change-Id: I1bca20cec1e309105805d2c741c56abf04ab33d5 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ConstraintByteArrayOutputStream.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressInputStream.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressOutputStream.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java 4 files changed, 76 insertions(+), 76 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9171 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1bca20cec1e309105805d2c741c56abf04ab33d5 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: tar: throw an exception if base does not exist
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: tar: throw an exception if base does not exist ...................................................................... utils: tar: throw an exception if base does not exist Change-Id: I25e4e41f7c68c9a6b797b7436c8565d2ad059329 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Tar.java 1 file changed, 11 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9165 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25e4e41f7c68c9a6b797b7436c8565d2ad059329 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: ssh: cleanup: rename server with host
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: ssh: cleanup: rename server with host ...................................................................... utils: ssh: cleanup: rename server with host 'Host' is more compatible with the other API. Change-Id: I4b342fa033713608baa977c8e0592be2f5c35927 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterServersQuery.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/ssh/BasicTest.java 4 files changed, 15 insertions(+), 15 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9246 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b342fa033713608baa977c8e0592be2f5c35927 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: split the logic of ovirt-node upgrade out
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: split the logic of ovirt-node upgrade out ...................................................................... bootstrap: split the logic of ovirt-node upgrade out Currently we have 4 separate bootstrap methods: 1. Host. 2. Node registration. 3. Node installation. 4. Node upgrade. While there is something common between (1-3), node upgrade is totally different sequence: 1. Unlike bootstrap it is executing foreign code (not originated at engine machine. 2. Unlike bootstrap it is non-customizable. This change split the logic of the node upgrade out, to ease future VdsInstaller retirement. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: I22dee8f1238de198abba72f576fb4ee82c513f34 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java 1 file changed, 48 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9172 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22dee8f1238de198abba72f576fb4ee82c513f34 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: allow distinguish error from non error messages
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: allow distinguish error from non error messages ...................................................................... bootstrap: allow distinguish error from non error messages The old bootstrap xml like protocol will remain for a while until the node upgrade script rewritten. Till then we need to know if there was an error message to fail the command without relaying on constants within messages as VdsInstaller had done so far. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: I62de9fab0ae3c10d245ed6c2580bf8fcc09057d6 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallerMessages.java 1 file changed, 17 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9161 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62de9fab0ae3c10d245ed6c2580bf8fcc09057d6 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: handle bootstrap messages using string member
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: handle bootstrap messages using string member ...................................................................... bootstrap: handle bootstrap messages using string member Current implementation holds the VdsInstaller object in context of InstallVdsCommand only to extract the error message out of it. VdsInstaller is going to be retired so we move the reference to local scope and store the error message in string at state scope. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: I928db05fa3ca7cd5941f30af8036d598847ea7d2 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ApproveVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java 2 files changed, 15 insertions(+), 11 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9173 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I928db05fa3ca7cd5941f30af8036d598847ea7d2 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Event log - a method to bypass flow
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Event log - a method to bypass flow ...................................................................... core: Event log - a method to bypass flow Event log - a method to bypass flood filtering Adding a customId field to AuditLogableBase in order to enable distinguishing between events that have same instance references (dc, cluster, vm etc) but still should be treated as separate events such that the anti-flood event mechanism will not mask those events and display just one per the defined period. It is the responsibility of the AuditLogableBase instance creator to call setCustomId with a different id per log message instance in order to treat those messages as different messages. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875375 Change-Id: Iff160c4241618a2d0c475e13ea13ddefe8220f06 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 2 files changed, 12 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9148 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff160c4241618a2d0c475e13ea13ddefe8220f06 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: host add: differentiate between authentication er...
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: host add: differentiate between authentication error and other errors ...................................................................... bootstrap: host add: differentiate between authentication error and other errors New SSHClient implementation allows differentiating between these cases as requested. Change-Id: I0d87fdd0c8942ec39632bd4562694bd5d027cbd7 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 22 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9178 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d87fdd0c8942ec39632bd4562694bd5d027cbd7 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: packaging: Updated allinone plugin for new security mode
by juan.hernandez＠redhat.com 19 Nov '12

19 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated allinone plugin for new security mode ...................................................................... packaging: Updated allinone plugin for new security mode Change-Id: I0cec49b25fedba3994b84571e8a4845f3d0da536 Signed-off-by: Alex Lourie <alourie(a)redhat.com> (cherry picked from commit c833bba55a19b2e2383d532b87c363a7895a8927) --- M packaging/fedora/setup/plugins/all_in_one_100.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Alex Lourie: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved Moran Goldboim: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/9146 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0cec49b25fedba3994b84571e8a4845f3d0da536 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: ofer.schre(a)gmail.com

1 0

Change in ovirt-engine[master]: webadmin: Setup Network- default boot protocol wasn't none.
by alkaplan＠redhat.com 19 Nov '12

19 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Setup Network- default boot protocol wasn't none. ...................................................................... webadmin: Setup Network- default boot protocol wasn't none. When doing the following- 1. Opening the Setup Network Dialog. 1. Dragging "unattached", "non vlan" Network on a Nic. 2. Detaching the Network. 3. Attaching another "unattached", "non vlan" Network to the Nic. Result- The default boot protocol of the network is empty- there is no selected radio button. Bug-Url:https://bugzilla.redhat.com/875724 Change-Id: Ie1d2d8525bcf20d9cd907b0c80a34bd82b1e4d9d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 1 file changed, 31 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1d2d8525bcf20d9cd907b0c80a34bd82b1e4d9d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: add advanced parameters to VM Interface dialog
by alkaplan＠redhat.com 19 Nov '12

19 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: add advanced parameters to VM Interface dialog ...................................................................... webadmin: add advanced parameters to VM Interface dialog - Add advanced parameters section to VM Interface dialog - "port mirroring" and "activate" should be moved to the advanced parametrs section. Change-Id: I94b3c38bf353ddadd9390a0797723db6c9e81304 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml 2 files changed, 26 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94b3c38bf353ddadd9390a0797723db6c9e81304 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removed OnPropertyChanged from AuditLog
by lhornyak＠redhat.com 19 Nov '12

19 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: removed OnPropertyChanged from AuditLog ...................................................................... core: removed OnPropertyChanged from AuditLog OnPropertyChanged was not used Change-Id: I533a4287c02612a5e124317467225c6f03d19951 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I533a4287c02612a5e124317467225c6f03d19951 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removed OnPropertyChanged from DiskImageDynamic
by lhornyak＠redhat.com 19 Nov '12

19 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: removed OnPropertyChanged from DiskImageDynamic ...................................................................... core: removed OnPropertyChanged from DiskImageDynamic OnPropertyChanged was not used. Change-Id: Ie029b245e3d6aecda954028fe8d6ea23a29a08d0 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie029b245e3d6aecda954028fe8d6ea23a29a08d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: simplify setters on VM bean
by lhornyak＠redhat.com 19 Nov '12

19 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: simplify setters on VM bean ...................................................................... core: simplify setters on VM bean The comparison was not needed. Change-Id: If65eb174fb1090b86a8a60f41c33c30a7eb295b4 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 1 file changed, 3 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65eb174fb1090b86a8a60f41c33c30a7eb295b4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unused OnPropertyChanged
by lhornyak＠redhat.com 19 Nov '12

19 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: remove unused OnPropertyChanged ...................................................................... core: remove unused OnPropertyChanged OnPropertyChanged was not used, deleted Change-Id: I08735d92a8e90cc0dfebfb1ce682b5697eecbd2c Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 1 file changed, 0 insertions(+), 48 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08735d92a8e90cc0dfebfb1ce682b5697eecbd2c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Aligning labels in Volume dialog for Japanese loca...
by gchaplik＠redhat.com 19 Nov '12

19 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Aligning labels in Volume dialog for Japanese locale ...................................................................... webadmin: Aligning labels in Volume dialog for Japanese locale Changed the width of the labels and messages so that it looks proper in Default and Japanese locale. Change-Id: I9abad6b3f53bbbf5d571d288db649c4d7405e9b2 Bug-Url: https://bugzilla.redhat.com/872403 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.ui.xml 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9abad6b3f53bbbf5d571d288db649c4d7405e9b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change Error Messages (#871864)
by msalem＠redhat.com 18 Nov '12

18 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Change Error Messages (#871864) ...................................................................... engine: Change Error Messages (#871864) This patch adds the vlan id to the error NETWORK_VLAN_IN_USE, and changes the range of legal vlan ids in the error to match the actual allowed range. Change-Id: I095ecde03174fabafbb556ffc82ba22a8b443a36 Bug-Url: https://bugzilla.redhat.com/871864 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateNetworkCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 12 insertions(+), 10 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I095ecde03174fabafbb556ffc82ba22a8b443a36 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated timeout while adding host in AIO plugin
by oschreib＠redhat.com 18 Nov '12

18 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated timeout while adding host in AIO plugin ...................................................................... packaging: Updated timeout while adding host in AIO plugin Change-Id: I7a93690a68c699a68f93fc561ee9c5135179fd7f Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/plugins/all_in_one_100.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a93690a68c699a68f93fc561ee9c5135179fd7f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Free Mac Addresses in ImportVmCommand (#864346)
by msalem＠redhat.com 18 Nov '12

18 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Free Mac Addresses in ImportVmCommand (#864346) ...................................................................... engine: Free Mac Addresses in ImportVmCommand (#864346) This patch adds a list of mac addresses that gathers all the macs that are added during ImportVmCommand, in case the command fails and these macs need to be released. Change-Id: I228d747be7e2c456e1777a51fd6fdfeca518bbbb Bug-Url: https://bugzilla.redhat.com/864346 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java 2 files changed, 22 insertions(+), 8 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I228d747be7e2c456e1777a51fd6fdfeca518bbbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: release 3.2.0.7-1
by mpastern＠redhat.com 18 Nov '12

18 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.2.0.7-1 ...................................................................... cli: release 3.2.0.7-1 Change-Id: I0c6c3a64cc7b97c20b7a34ab57c21c9d66f23021 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 7 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0c6c3a64cc7b97c20b7a34ab57c21c9d66f23021 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: disable output redirection via config #866853
by mpastern＠redhat.com 18 Nov '12

18 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: disable output redirection via config #866853 ...................................................................... cli: disable output redirection via config #866853 paging disabling is done via 'no_paging = True' configuration value. https://bugzilla.redhat.com/show_bug.cgi?id=866853 Change-Id: I633691151acc75441b177dc8c5996552fd4a5628 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/context.py M src/cli/executionmode.py M src/cli/settings.py M src/ovirtcli/options.py M src/ovirtcli/settings.py 5 files changed, 17 insertions(+), 7 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I633691151acc75441b177dc8c5996552fd4a5628 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: CTRL + C signal while password prompt appears causes to...
by mpastern＠redhat.com 18 Nov '12

18 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: CTRL + C signal while password prompt appears causes to rhevm-cli to fall #868647 ...................................................................... cli: CTRL + C signal while password prompt appears causes to rhevm-cli to fall #868647 https://bugzilla.redhat.com/show_bug.cgi?id=868647 Change-Id: Ic462b2baefa9d947e31ab0e81f1a10e06dff26b6 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/context.py 1 file changed, 18 insertions(+), 11 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9261 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic462b2baefa9d947e31ab0e81f1a10e06dff26b6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Cleanup and Refactor VmInterfaceType
by masayag＠redhat.com 18 Nov '12

18 Nov '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Cleanup and Refactor VmInterfaceType ...................................................................... core: Cleanup and Refactor VmInterfaceType The patch includes the following: * Use meaningful names for variable * Set explicit speed for each driver * Remove private c'tor from enum Change-Id: Ib4a75f51f0ce04f94278bec55809185677634df5 Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateInterfaceCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmInterfaceType.java 8 files changed, 29 insertions(+), 34 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib4a75f51f0ce04f94278bec55809185677634df5 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Revert back a message for host general tab (#87182...
by achub＠redhat.com 18 Nov '12

18 Nov '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Revert back a message for host general tab (#871823) ...................................................................... webadmin: Revert back a message for host general tab (#871823) Change-Id: If65f9d3d10055ebcd5e738571ed3a75641314117 Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationMessages.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65f9d3d10055ebcd5e738571ed3a75641314117 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Show "Guide Me" dialog after adding data center (#...
by achub＠redhat.com 18 Nov '12

18 Nov '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Show "Guide Me" dialog after adding data center (#872160) ...................................................................... webadmin: Show "Guide Me" dialog after adding data center (#872160) Change-Id: If25ef37b0d9ff79737e7efe8283272aca50b0d4b Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java 1 file changed, 30 insertions(+), 15 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If25ef37b0d9ff79737e7efe8283272aca50b0d4b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: release 3.2.0.4-1
by mpastern＠redhat.com 18 Nov '12

18 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 3.2.0.4-1 ...................................................................... sdk: release 3.2.0.4-1 Change-Id: Id777f2faa15612432597f7eaea0f6d90b2158dda Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-sdk.spec.in M setup.py 3 files changed, 19 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9300 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id777f2faa15612432597f7eaea0f6d90b2158dda Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: adapt to sdk #853947 fix
by mpastern＠redhat.com 18 Nov '12

18 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: cli: adapt to sdk #853947 fix ...................................................................... cli: adapt to sdk #853947 fix Change-Id: Ib0b502c934ba97012a1cf942f5dcd4b2dde11c7c Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/utils/methodhelper.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9260 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib0b502c934ba97012a1cf942f5dcd4b2dde11c7c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern＠redhat.com 18 Nov '12

18 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api ...................................................................... sdk: rebase to latest api - to StorageDomainVM.import() added action.exclusive parameter - to StorageDomainTemplate.import() added action.exclusive parameter Change-Id: I4578c0c939959e271d83a7d3c1279d31a621e0af Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtsdk/infrastructure/brokers.py 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9255 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4578c0c939959e271d83a7d3c1279d31a621e0af Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: update README
by mpastern＠redhat.com 18 Nov '12

18 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: update README ...................................................................... sdk: update README Change-Id: I8973d019ed84a2505589bc27d1dd26a90cfba8d8 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M README 1 file changed, 0 insertions(+), 11 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9080 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8973d019ed84a2505589bc27d1dd26a90cfba8d8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: rebase to latest api
by mpastern＠redhat.com 18 Nov '12

18 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: rebase to latest api ...................................................................... sdk: rebase to latest api - added /current argument to VmCdRom.update() acorrding to #869257 - implemented support for #869257 - added /async argument to VmCdRom.update() - added /async argument to ClusterNetworks.update() - removed Disk.update() method - added parameters overload for adding direct-lun disk - added vm/template.display.smartcard_enabled - added correlation_id to VMDisk.activate()/deactivate() - added correlation_id to VMNic.activate()/deactivate() - added certificate property to vm - Disk.lunStorage renamed to Disk.lun_storage Change-Id: Ic25c7a166698a28b22350f9988e418b2aef5b199 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/subcollection/subresource.py M src/codegen/utils/paramutils.py M src/ovirtsdk/infrastructure/brokers.py M src/ovirtsdk/infrastructure/errors.py M src/ovirtsdk/xml/params.py 5 files changed, 288 insertions(+), 110 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9079 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic25c7a166698a28b22350f9988e418b2aef5b199 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk[master]: sdk: Cannot create simultaneous connections to multiple serv...
by mpastern＠redhat.com 18 Nov '12

18 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: Cannot create simultaneous connections to multiple servers #853947 ...................................................................... sdk: Cannot create simultaneous connections to multiple servers #853947 https://bugzilla.redhat.com/show_bug.cgi?id=853947 Change-Id: I53272bec94b5cd19a32fdd793d2b6786581a85f1 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/codegen/collection/collection.py M src/codegen/collection/collectionexceptions.py M src/codegen/collection/resource.py M src/codegen/entrypoint/entrypoint.py M src/codegen/imp/imprt.py M src/codegen/main.py M src/codegen/subcollection/subcollection.py M src/codegen/subcollection/subresource.py M src/ovirtsdk/api.py M src/ovirtsdk/infrastructure/brokers.py A src/ovirtsdk/infrastructure/cache.py M src/ovirtsdk/infrastructure/common.py M src/ovirtsdk/infrastructure/connectionspool.py A src/ovirtsdk/infrastructure/context.py M src/ovirtsdk/infrastructure/contextmanager.py M src/ovirtsdk/utils/parsehelper.py M src/ovirtsdk/web/connection.py 17 files changed, 3,215 insertions(+), 1,591 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I53272bec94b5cd19a32fdd793d2b6786581a85f1 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine-sdk Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Clean up of exceptions
by mkublin＠redhat.com 18 Nov '12

18 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Clean up of exceptions ...................................................................... engine: Clean up of exceptions The following patch is removing unneeded exceptions, unneeded catch of exceptions, unneeded code inside of catch block. Also contains some small clean ups of IrsBrokerCommand Change-Id: I27352290878620e922b1ba263172267ec9001aa0 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetStoragePoolInfoVDSCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IRSNetworkException.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/GetVGListVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/HSMGetStorageDomainInfoVDSCommand.java 5 files changed, 78 insertions(+), 178 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9267 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I27352290878620e922b1ba263172267ec9001aa0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Removed duplicate retrieve of vdsm task, during SPM ...
by mkublin＠redhat.com 18 Nov '12

18 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removed duplicate retrieve of vdsm task, during SPM election ...................................................................... engine: Removed duplicate retrieve of vdsm task, during SPM election The following fix will remove unneeded cal for vdsm tasks during SPM election. At case that we choose a new spm, no need for additional retrieve of tasks from vdsm, a call for tasks is done inside of AsyncTaskManager.getInstance().StopStoragePoolTasks(storagePool) Change-Id: Idfd42b80ca241010cda578433b4365478c071334 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsEventListener.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9266 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfd42b80ca241010cda578433b4365478c071334 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Fail Import Vm on MAC Address (#872100)
by msalem＠redhat.com 18 Nov '12

18 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Fail Import Vm on MAC Address (#872100) ...................................................................... engine: Fail Import Vm on MAC Address (#872100) This patch changes the VmInterfaceManager to throw a VdcBllExpection when trying to add a interface with a used MAC address. It also adds a new VdcBllError for this case, and changes the VmInterfaceManagerTest according to the change in behavior. Change-Id: I68d37ed183adb4adf8abf8b11332f6c822f8c4c0 Bug-Url: https://bugzilla.redhat.com/872100 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/network/VmInterfaceManager.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/network/VmInterfaceManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 74 insertions(+), 69 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9144 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I68d37ed183adb4adf8abf8b11332f6c822f8c4c0 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Adding support for installing functions ...
by emesika＠redhat.com 18 Nov '12

18 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Adding support for installing functions ... ...................................................................... core: Adding support for installing functions ... Adding support for installing functions that are needed for an upgrade script Consider the following You are writing an upgrade script that is doing lot of data manipulations using local functionsThose functions should be called also after upgrade completed when data in the system is modified Now , those functions are dependant on a new object created lets say ,table T which was added in a prev upgrade script.You can not add those functions to the common_sp.sql since it runs before the upgrade scripts and at that point table T is not valid yet. You can duplicate the functions and handle a local copy in the upgrade script and another in the *_sp.sql file but this code duplication is a mess and may lead to problems.You can install the functions only from the upgrade script and not drop then at the end, but then, if you have some fixes to the functions , they will not run again after the upgrade script is executed and the refreshstoredprocedure s script will not refresh the code. The solution that I suggest here is to enable adding one or more lines at the start of the upgrade script with the format: --#source sql_file for example : --#source myfunctions_sp.sql This will run myfunctions_sp.sql and install its functions before the upgrade script is running and keep functions (that are not temporary) in the *_sp.sql files so we can fix a function and refreshstoredprocedures will install the fixed code. Change-Id: I91de335159a6c87c0f9d7f1383da25bb93b4a684 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh M backend/manager/dbscripts/upgrade.sh 2 files changed, 32 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/1214 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91de335159a6c87c0f9d7f1383da25bb93b4a684 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: NPE fix when adding a domain (#856583)
by derez＠redhat.com 18 Nov '12

18 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: NPE fix when adding a domain (#856583) ...................................................................... webadmin: NPE fix when adding a domain (#856583) When trying to add a storage domain with a not-supported format there was an NPE causing a bad error message instead of the correct one. This was caused since the StorageModel in StorageListModel wasn't set to the selected item. It is now. Change-Id: I07cb27ce4c50410840032cdda06deb3b20a5aa8b Bug-Url: https://bugzilla.redhat.com/856583 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9259 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I07cb27ce4c50410840032cdda06deb3b20a5aa8b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: disks main-tab - disable prefix localization
by ecohen＠redhat.com 16 Nov '12

16 Nov '12

Einav Cohen has submitted this change and it was merged. Change subject: webadmin: disks main-tab - disable prefix localization ...................................................................... webadmin: disks main-tab - disable prefix localization Extract disks search prefix strings to NON-NLS constants. [disksSearchPrefix("Disks:"), diskTypeSearchPrefix("disk_type = "), searchConjunctionAnd(" and" ), searchRegexAll("(.)*")] Since these string are part of the search query, they should be declared as NON-NLS (Non-National Language Support). Change-Id: I47b6986b47f6ddca036580310a64716c4519675b Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabDiskView.java 2 files changed, 22 insertions(+), 27 deletions(-) Approvals: Daniel Erez: Verified Einav Cohen: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I47b6986b47f6ddca036580310a64716c4519675b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix log message in VdsInstaller
by juan.hernandez＠redhat.com 16 Nov '12

16 Nov '12

Juan Hernandez has submitted this change and it was merged. Change subject: core: Fix log message in VdsInstaller ...................................................................... core: Fix log message in VdsInstaller The current code uses {1} in a log message with only one parameter, it should use {0} instead. Change-Id: Iba1bfd6a35076c9e51cff1959b5a3ea87ed41120 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Looks good to me, but someone else must approve Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9291 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iba1bfd6a35076c9e51cff1959b5a3ea87ed41120 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Do not force fencing proxy to be ...(#876235)
by emesika＠redhat.com 16 Nov '12

16 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core:Do not force fencing proxy to be ...(#876235) ...................................................................... core:Do not force fencing proxy to be ...(#876235) Do not force fencing proxy to be in UP status Currently when a host is non-responsive and has Power Management configured, we are looking for a proxy host in the same cluster to carry out the fencing commands that will actually reboot the problematic host. The algorithm of finding such a proxy was up to now to find the first host that is in UP status in the host DC. This patch modified the algorithm of proxy finding to 1) Look for a Host in the problematic Host DC which is UP 2) If 1) fails, try to use any other Host in the same DC as a proxy skipping Hosts is non-operational status with NETWORK_UNREACHABLE reason. This is done because there is no connection between the Host status and its ability to carry out proxy commands (which can be done if Host has network connectivity) although we can assume that a Host that is in UP status is connected to the network and its chance to succeed in carrying out the fencing operations is the best. Change-Id: I437e9b2bb0300f8d71cc8f0c50aaff1b253a63bb Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FencingExecutor.java 1 file changed, 33 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9251 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I437e9b2bb0300f8d71cc8f0c50aaff1b253a63bb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-dwh[master]: packaging: fixed setup issues (#876240\876242)
by ydary＠redhat.com 15 Nov '12

15 Nov '12

Yaniv Dary has submitted this change and it was merged. Change subject: packaging: fixed setup issues (#876240\876242) ...................................................................... packaging: fixed setup issues (#876240\876242) - made etl run always with the ovirt engine java version. - fixed the return code value return from service. - added sleep to let health status load before etl start. bug-url: https://bugzilla.redhat.com/876242 bug-url: https://bugzilla.redhat.com/876240 Change-Id: I608a4495c65459e0488ef298cf790ce5ab454830 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M data-warehouse/history_etl/history_service/history_service.sh M data-warehouse/history_etl/history_service/ovirt-engine-dwhd M packaging/ovirt-engine-dwh-setup.py 3 files changed, 7 insertions(+), 1 deletion(-) Approvals: Yaniv Dary: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9277 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I608a4495c65459e0488ef298cf790ce5ab454830 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-dwh Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network main tab is not visible in some tree selec...
by msalem＠redhat.com 15 Nov '12

15 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: webadmin: Network main tab is not visible in some tree selections. ...................................................................... webadmin: Network main tab is not visible in some tree selections. Network Main Tab should be visible also when selecting in the tree- - Data Center - Cluster - Host Change-Id: Id88e55cc18d244730b415400a43622dfe39df8dc Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java 1 file changed, 17 insertions(+), 6 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Alona Kaplan: Looks good to me, but someone else must approve Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9077 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id88e55cc18d244730b415400a43622dfe39df8dc Gerrit-PatchSet: 12 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add Network Search for Host Name
by msalem＠redhat.com 15 Nov '12

15 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Add Network Search for Host Name ...................................................................... engine: Add Network Search for Host Name This patch adds the network_vds_view, to be used by the tree search for Networks by Host name. It also joins the network table with this new view. Change-Id: I4567828abdba27f50f40e75a7989da965f475417 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkCrossRefAutoCompleter.java A backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkHostConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjects.java M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/SearchBackend.gwt.xml 6 files changed, 59 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9265 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4567828abdba27f50f40e75a7989da965f475417 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add Vds Port Validation 65535 (#871328)
by msalem＠redhat.com 15 Nov '12

15 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Add Vds Port Validation 65535 (#871328) ...................................................................... engine: Add Vds Port Validation 65535 (#871328) This patch changes the maximum port number to 65535 using a validation in VdsStatic. Change-Id: I0e2cf636c32fc74f88f1c47ab609a616e2e5860f Bug-Url: https://bugzilla.redhat.com/871328 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitiesDefinitions.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VdsStatic.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_es.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_es.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_fr.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_ja.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_pt_BR.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors_zh_CN.properties 17 files changed, 25 insertions(+), 25 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9149 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0e2cf636c32fc74f88f1c47ab609a616e2e5860f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add Network Search for Cluster Name
by msalem＠redhat.com 15 Nov '12

15 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Add Network Search for Cluster Name ...................................................................... engine: Add Network Search for Cluster Name This patch adds the cluster name column to network_cluster_view. It also joins the network and network_cluster tables. Change-Id: I77bc293ac47b7cc94a1d4355da2fec11649c4b47 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/dbscripts/create_views.sql M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkClusterConditionFieldAutoCompleter.java A backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/NetworkCrossRefAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SearchObjectAutoCompleter.java 4 files changed, 25 insertions(+), 4 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I77bc293ac47b7cc94a1d4355da2fec11649c4b47 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Improve of IrsBrokerCommand
by mkublin＠redhat.com 15 Nov '12

15 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Improve of IrsBrokerCommand ...................................................................... core: Improve of IrsBrokerCommand The following patch is removing getIsValidWithoutSpmStart() method and performs some clean up. The method is removed because of it can trigger spm election, also were unify additional places for nullify of all internal proxies of IrsBrokerCommand Change-Id: I822acd7afdc128195637efbd467548877488c1f5 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 10 insertions(+), 18 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9187 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I822acd7afdc128195637efbd467548877488c1f5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Aligning buttons in AddBricks dialog
by gchaplik＠redhat.com 15 Nov '12

15 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Aligning buttons in AddBricks dialog ...................................................................... webadmin: Aligning buttons in AddBricks dialog Add button is moved down and placed along side brick directory. Clear button is removed as there is only one field which needs to be cleared. Change-Id: I57a3893bbc0db14d23dee5f52d3f7e1f0b1098a3 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.ui.xml 3 files changed, 3 insertions(+), 35 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I57a3893bbc0db14d23dee5f52d3f7e1f0b1098a3 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix System Tree rendering in GlusterOnly mode
by gchaplik＠redhat.com 15 Nov '12

15 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix System Tree rendering in GlusterOnly mode ...................................................................... webadmin: Fix System Tree rendering in GlusterOnly mode System Tree was not visible while running oVirt in GlusterOnly mode. Modified the code to call Execute() method of outer class instead self(leads to recursive execution). Change-Id: I6ef526960ad67038168f9cc9830cfe6df23ea6bc Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9017 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6ef526960ad67038168f9cc9830cfe6df23ea6bc Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Hide Networks tab in GlusterOnly mode
by gchaplik＠redhat.com 15 Nov '12

15 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Hide Networks tab in GlusterOnly mode ...................................................................... webadmin: Hide Networks tab in GlusterOnly mode Networks main tab will not be shown while running oVirt in GlusterOnly mode. Change-Id: I6fc54746365c4b0c94a8c82b6cc0fe3ba697e3c5 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkListModel.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fc54746365c4b0c94a8c82b6cc0fe3ba697e3c5 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Fix Volume virt option configuration version
by gchaplik＠redhat.com 15 Nov '12

15 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fix Volume virt option configuration version ...................................................................... webadmin: Fix Volume virt option configuration version Passing 'general' as the version while retrieving the Virt related volume options from configuration. Change-Id: I03679ae1237607ea6273e1d55f31ffbc02893b21 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java 1 file changed, 7 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9134 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03679ae1237607ea6273e1d55f31ffbc02893b21 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0