November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: bootstrap: fix ovirt-node parameters and locations
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: fix ovirt-node parameters and locations ...................................................................... bootstrap: fix ovirt-node parameters and locations currently we hold old rhev-h settings, while ovirt-node is different. Change-Id: I3fa85dd89a3b7056aa4ed7c1ac3f5b49965c3b97 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9156 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3fa85dd89a3b7056aa4ed7c1ac3f5b49965c3b97 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: cleanup the ca interface
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: pki: cleanup the ca interface ...................................................................... pki: cleanup the ca interface VdsInstaller is about the retire, but it contains some dirty code that is actually belongs to the ca internals. In this patch we move this code into the ca interface so that the VdsInstaller replacement will not contain any knowledge of the ca internals. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: If8c9285ed3a0640fea17a4ce629d6deb532430c4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java 2 files changed, 92 insertions(+), 29 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9162 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If8c9285ed3a0640fea17a4ce629d6deb532430c4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: do not check connectivity nor unique id when VdsI...
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: do not check connectivity nor unique id when VdsInstall=false ...................................................................... bootstrap: do not check connectivity nor unique id when VdsInstall=false Change-Id: Ief74abae57c4fd7b76642df62aba7690a9f66208 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=873222 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9157 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ief74abae57c4fd7b76642df62aba7690a9f66208 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: ssh: fixup activity detection
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: ssh: fixup activity detection ...................................................................... utils: ssh: fixup activity detection Current implementation considers only the first active stream, leaving other streams marked as active. Activity detection should clear all streams' activity flag at every loop iteration. Change-Id: Ibb63134b2829ae57c902f9d3c33f10c5311bcf76 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9169 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb63134b2829ae57c902f9d3c33f10c5311bcf76 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: ssh: optimize progress streams
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: ssh: optimize progress streams ...................................................................... utils: ssh: optimize progress streams Default java implementation of filtered stream is byte-by-byte operation. Bypass behaviour to buffer methods. Change-Id: I9a890581b324ae3f9223587e1eeb0c53675bd060 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressInputStream.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/ProgressOutputStream.java 2 files changed, 19 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9170 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9a890581b324ae3f9223587e1eeb0c53675bd060 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: tests: do not use default key alias
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: tests: do not use default key alias ...................................................................... utils: tests: do not use default key alias Allow to specify key to use as client. Change-Id: I6242a2b6f138c3438ff95febe0b85e0b48befe65 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java 1 file changed, 5 insertions(+), 8 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9167 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6242a2b6f138c3438ff95febe0b85e0b48befe65 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: ssh: don't add ssh command to exception
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: ssh: don't add ssh command to exception ...................................................................... utils: ssh: don't add ssh command to exception It results in a long unclear message to the user. Change-Id: If4e221b423a46dcaf01ca540a4671caeedb90dce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ssh/SSHClient.java 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9168 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If4e221b423a46dcaf01ca540a4671caeedb90dce Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: tests: tar: cleanup main() entry point
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: tests: tar: cleanup main() entry point ...................................................................... utils: tests: tar: cleanup main() entry point People found that this unused testing only code needs to not leak. Change-Id: I85ac69a75fdef1d5e60f7e33d79bc223535c01a0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/archivers/tar/Tar.java 1 file changed, 3 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9166 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I85ac69a75fdef1d5e60f7e33d79bc223535c01a0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: utils: tar: support long file names within tar
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: tar: support long file names within tar ...................................................................... utils: tar: support long file names within tar Change-Id: I364d67dc408af21e08a20014c6a0c99a413fe3be Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/Tar.java 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9164 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I364d67dc408af21e08a20014c6a0c99a413fe3be Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: pki: accept subject name for certificate
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: pki: accept subject name for certificate ...................................................................... pki: accept subject name for certificate This enables generating a completely empty certificate request, setting subject at engine machine. This much safer (security wise) and much easier to handle at host during bootstrap. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875528 Change-Id: I9798deff39a69f9fd25c0ab9e998b5a7b206daeb Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/conf/ca/SignReq.sh M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/OpenSslCAWrapper.java 3 files changed, 37 insertions(+), 14 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9163 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9798deff39a69f9fd25c0ab9e998b5a7b206daeb Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0