November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: utils: tar: split tar unit test from VdsInstallerSSH tests.
by yzaslavs＠redhat.com 20 Nov '12

20 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: utils: tar: split tar unit test from VdsInstallerSSH tests. ...................................................................... utils: tar: split tar unit test from VdsInstallerSSH tests. VdsInstallerSSH.java is about to retire. Improve some. Change-Id: I0482fb6a7dbb93f6a7f85773aa8a4d813eb7af87 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- A backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/archivers/tar/TarTest.java 1 file changed, 140 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9292 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0482fb6a7dbb93f6a7f85773aa8a4d813eb7af87 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: make Permits inherit form BaseResources
by mpastern＠redhat.com 20 Nov '12

20 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: make Permits inherit form BaseResources ...................................................................... restapi: make Permits inherit form BaseResources Permits should inherit form BaseResources according to API collection pattern Change-Id: Ib83071d0eb869204c32d9729f73cc1d996947304 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 13 insertions(+), 9 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib83071d0eb869204c32d9729f73cc1d996947304 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Fence Host fails if something ...(#871768)
by emesika＠redhat.com 20 Nov '12

20 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core:Fence Host fails if something ...(#871768) ...................................................................... core:Fence Host fails if something ...(#871768) Fence Host fails if something went wrong in FenceQuietTimeBetweenOperationsInSec window [180seconds] We have a configuration setting of Quiet Time Between PM Operations, this should control PM operations invoked by the user. The intension is to prevent subsequent calls to PM stop/start without waiting to a stable status. Adding a condition in the FenceVdsBaseCommand canDoAction validation , not to check Quiet Time Between PM Operations if the command is internal (i.e. was invoked by the system and not by the user) Change-Id: I2cab006a6e911d1eaad888c5c4e41bb4aca68f03 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9211 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cab006a6e911d1eaad888c5c4e41bb4aca68f03 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: make GlusterBricks inherit form BaseResources
by mpastern＠redhat.com 20 Nov '12

20 Nov '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: make GlusterBricks inherit form BaseResources ...................................................................... restapi: make GlusterBricks inherit form BaseResources GlusterBricks should inherit form BaseResources according to API collection pattern Change-Id: I6eec579c3eb7079b1c5f4c43168f2a1bd9ac5d0e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd 1 file changed, 18 insertions(+), 12 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9351 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6eec579c3eb7079b1c5f4c43168f2a1bd9ac5d0e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated ui text for the handling of the system ta...
by oschreib＠redhat.com 19 Nov '12

19 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated ui text for the handling of the system tasks ...................................................................... packaging: Updated ui text for the handling of the system tasks Change-Id: I67eba20d4f71c028808f740e599c94b1c02d1cab Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/engine-upgrade.py 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9330 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I67eba20d4f71c028808f740e599c94b1c02d1cab Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Simon Grinberg <sgrinber(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: LSM - rephrasing move dialog warning
by tnisan＠redhat.com 19 Nov '12

19 Nov '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: LSM - rephrasing move dialog warning ...................................................................... webadmin: LSM - rephrasing move dialog warning Rephrasing move dialog warning to: "Note: Moving the disk while the VM is running" Change-Id: Ide176585aa0d094b202a766ebb0e11313677c59f Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9338 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ide176585aa0d094b202a766ebb0e11313677c59f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix error message for locked disks
by tnisan＠redhat.com 19 Nov '12

19 Nov '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Fix error message for locked disks ...................................................................... core: Fix error message for locked disks This fix is related to bug Bug-Url: https://bugzilla.redhat.com/865551 , though not specifically mentioned there. It fixes an error message displayed when trying to run a VM while one or more of its disks are locked. Previous message's disks_aliases was not substituted with actual disks aliases. The same issue occurred with MoveOrCopyDiskCommand. There were two separate messages for the one locked disk and multiple locked disks. Now one message replaces the two previous ones, along with the correct disk(s) alias(es). Change-Id: I7c56d9d2926eaf34b4a279c8d61a8cb166524da9 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 11 files changed, 56 insertions(+), 24 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/8693 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7c56d9d2926eaf34b4a279c8d61a8cb166524da9 Gerrit-PatchSet: 14 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Quota refactor
by gchaplik＠redhat.com 19 Nov '12

19 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: Quota refactor ...................................................................... core: Quota refactor Design can be found here: http://wiki.ovirt.org/wiki/Features/Design/Quota-3.2 Adding Objects for Quota consumption parameters Adding InvalidQuotaParametersException Unit test of QuotaManager redesign to fit the new API Change of AddDiskCommand to new design Change implementation of AddVmCommand. Change implementation of AddVmTemplateCommand. Change implementation for ChangeQuotaCommand Change implementation for CommonVmPoolWithVmsCommand Change implementation for ChangeQuotaForDiskCommand Changed implementation of CreateAllSnapshotsFromVmCommand Changed implementation of AddVmTemplateCommand Changed implementation of ImportVmCommand Changed implementation of MoveOrCopyDiskCommand Changed implementation of RemoveDiskCommand QuotaCRUDCommand no longer implements Quotable. Change implementation of RemoveVmCommand Change implementation of RemoveVmFromImportExportCommand Change implementation of RemoveVmTemplateCommand Change implementation of RemoveVmTemplateFromImportExportCommand Change implementation of RestoreAllSnapshotsCommand Change implementation of RunVmCommand Change implementation of RunVmOnceCommand Change implementation of StopVmCommandBase Change implementation of UpdateVmCommand Change implementation of UpdateVmDiskCommand Cleaned unused methods from QuotaManager activate new design in CommandBase (removed all records of old design) Change-Id: I109ae8ae0191f46abaa1be21a7ecfebe50b9993f Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/dbscripts/create_functions.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeQuotaForDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmOnceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StopVmCommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmPoolHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/ChangeQuotaCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/InvalidQuotaParametersException.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParameter.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaConsumptionParametersWrapper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManager.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaManagerAuditLogger.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaSanityParameter.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaStorageConsumptionParameter.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaStorageDependent.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaVdsDependent.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/quota/QuotaVdsGroupConsumptionParameter.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/quota/QuotaManagerTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/VdcActionType.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/quota/QuotaPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaStorageView.java 41 files changed, 1,759 insertions(+), 1,683 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9180 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I109ae8ae0191f46abaa1be21a7ecfebe50b9993f Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Disallow removing of a DC when not all hosts are in ma...
by tnisan＠redhat.com 19 Nov '12

19 Nov '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Disallow removing of a DC when not all hosts are in maintenance (#850286) ...................................................................... core: Disallow removing of a DC when not all hosts are in maintenance (#850286) When trying to force remove a Data Center when not all it's hosts are in maintenance mode, fail the CanDoAction Change-Id: I88e2938d4c1b02065b330929e15c579f714e4385 Bug-Url: https://bugzilla.redhat.com/850286 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 35 insertions(+), 1 deletion(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9110 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I88e2938d4c1b02065b330929e15c579f714e4385 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: bootstrap: do not get unique id at canDoAction
by yzaslavs＠redhat.com 19 Nov '12

19 Nov '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: do not get unique id at canDoAction ...................................................................... bootstrap: do not get unique id at canDoAction CURRENT IMPLEMENTATION engine has duplicate complex vdsm logic to generate the vdsm id. @Reloadable @TypeConverterAttribute(String.class) @DefaultValueAttribute( "IDFILE=/etc/vdsm/vdsm.id; " + "if [ -r \"${IDFILE}\" ]; then " + "cat \"${IDFILE}\"; " + "else " + "UUID=\"$(" + "dmidecode -s system-uuid 2> /dev/null | " + "sed -e 's/.*Not.*//' " + ")\"; " + "if [ -z \"${UUID}\" ]; then " + "UUID=\"$(uuidgen 2> /dev/null)\" && " + "mkdir -p \"$(dirname \"${IDFILE}\")\" && " + "echo \"${UUID}\" > \"${IDFILE}\" && " + "chmod 0644 \"${IDFILE}\"; " + "fi; " + "[ -n \"${UUID}\" ] && echo \"${UUID}\"; " + "fi" ) BootstrapNodeIDCommand(372), The command is executed synchronously (UI wise) when host is added. ASSUMPTIONS OF CURRENT IMPLEMENTATION 1. dmidecode exists out of the box in any distribution. ---> WRONG: fedora 17 has no, and other distributions may also lack. 2. host id is only dmidecode output. ---> WRONG: over time we saw that we need extra logic to keep the id sane, especially when the hardware id does not exist or malformed. 3. dmidecode utility is used for host id ---> WRONG: there are plans to make it more secure/robust using TPM, which requires software at host to generate. PROBLEMS IN CURRENT IMPLEMENTATION 1. if dmidecode utility is missing we cannot acquire host id before performing bootstrap. The whole idea of bootstrap process is to take vanilla distribution and install vdsm. dmidecode is missing from vanilla, hence cannot be executed before bootstrap. 2. the logic of generating host id exists both in engine and vdsm, both implementations need to synced, and kept synced between versions, which in practice cannot be achieved. As there is too much static noise (distribute on different channels, not be able to update all IT components, etc...). 3. If host id generation method is changed, the engine implementation should be changed as well, while engine should not really care how vdsm maintain its identity. NEW IMPLEMENTATION Acquire vdsm id during bootstrap process, at the earliest. When all dependencies are available. If vdsm id is duplicate: 1. post an error to host event log. 2. set the state of the host to "install fail". USER VISIBLE CHANGES The following existing scenario: 1. user has host xxx.com with ip 1.1.1.1, he added this host using xxx.com as host name. 2. user add new host, at the host field he *BY MISTAKE* writes 1.1.1.1. 3. the user is blocked from proceeding because of duplicate uuid between xxx.com(existing) and 1.1.1.1(new). 4. the confused user fixes the host field to 1.1.1.2 and proceed. Behaves as: 1. user has host xxx.com with ip 1.1.1.1, he added this host using xxx.com as host name. 2. user add new host, at the host field he *BY MISTAKE* writes 1.1.1.1. 3. installation starts, and ends up with installation failed status on the new host. 4. user sees the error message, and remove the host added by mistake. REASONING The above sequence of adding the same host with different name/address is not common or frequent, and does not justify the need to duplicate vdsm logic into engine, nor find a solution for distributions that locks the dmidecode utility at their base system layout, nor to lock our-self to dmidecode utility. Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=875527 Change-Id: I0263dbae34aaa02c126c5ed1dc52a84f4f5e77f8 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsCommand.java D backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstallHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/itests/BasicTestSetup.java 4 files changed, 64 insertions(+), 180 deletions(-) Approvals: Alon Bar-Lev: Verified Yair Zaslavsky: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9159 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0263dbae34aaa02c126c5ed1dc52a84f4f5e77f8 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0