November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: webadmin: Setup Network- default boot protocol wasn't none.
by alkaplan＠redhat.com 19 Nov '12

19 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Setup Network- default boot protocol wasn't none. ...................................................................... webadmin: Setup Network- default boot protocol wasn't none. When doing the following- 1. Opening the Setup Network Dialog. 1. Dragging "unattached", "non vlan" Network on a Nic. 2. Detaching the Network. 3. Attaching another "unattached", "non vlan" Network to the Nic. Result- The default boot protocol of the network is empty- there is no selected radio button. Bug-Url:https://bugzilla.redhat.com/875724 Change-Id: Ie1d2d8525bcf20d9cd907b0c80a34bd82b1e4d9d Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java 1 file changed, 31 insertions(+), 19 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9194 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie1d2d8525bcf20d9cd907b0c80a34bd82b1e4d9d Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: add advanced parameters to VM Interface dialog
by alkaplan＠redhat.com 19 Nov '12

19 Nov '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: add advanced parameters to VM Interface dialog ...................................................................... webadmin: add advanced parameters to VM Interface dialog - Add advanced parameters section to VM Interface dialog - "port mirroring" and "activate" should be moved to the advanced parametrs section. Change-Id: I94b3c38bf353ddadd9390a0797723db6c9e81304 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/networkinterface/NetworkInterfacePopupWidget.ui.xml 2 files changed, 26 insertions(+), 3 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9310 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94b3c38bf353ddadd9390a0797723db6c9e81304 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removed OnPropertyChanged from AuditLog
by lhornyak＠redhat.com 19 Nov '12

19 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: removed OnPropertyChanged from AuditLog ...................................................................... core: removed OnPropertyChanged from AuditLog OnPropertyChanged was not used Change-Id: I533a4287c02612a5e124317467225c6f03d19951 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/AuditLog.java 1 file changed, 0 insertions(+), 8 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9285 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I533a4287c02612a5e124317467225c6f03d19951 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removed OnPropertyChanged from DiskImageDynamic
by lhornyak＠redhat.com 19 Nov '12

19 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: removed OnPropertyChanged from DiskImageDynamic ...................................................................... core: removed OnPropertyChanged from DiskImageDynamic OnPropertyChanged was not used. Change-Id: Ie029b245e3d6aecda954028fe8d6ea23a29a08d0 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/DiskImageDynamic.java 1 file changed, 0 insertions(+), 5 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9284 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie029b245e3d6aecda954028fe8d6ea23a29a08d0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: simplify setters on VM bean
by lhornyak＠redhat.com 19 Nov '12

19 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: simplify setters on VM bean ...................................................................... core: simplify setters on VM bean The comparison was not needed. Change-Id: If65eb174fb1090b86a8a60f41c33c30a7eb295b4 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 1 file changed, 3 insertions(+), 9 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9283 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If65eb174fb1090b86a8a60f41c33c30a7eb295b4 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: remove unused OnPropertyChanged
by lhornyak＠redhat.com 19 Nov '12

19 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: remove unused OnPropertyChanged ...................................................................... core: remove unused OnPropertyChanged OnPropertyChanged was not used, deleted Change-Id: I08735d92a8e90cc0dfebfb1ce682b5697eecbd2c Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VM.java 1 file changed, 0 insertions(+), 48 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9282 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I08735d92a8e90cc0dfebfb1ce682b5697eecbd2c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Aligning labels in Volume dialog for Japanese loca...
by gchaplik＠redhat.com 19 Nov '12

19 Nov '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Aligning labels in Volume dialog for Japanese locale ...................................................................... webadmin: Aligning labels in Volume dialog for Japanese locale Changed the width of the labels and messages so that it looks proper in Default and Japanese locale. Change-Id: I9abad6b3f53bbbf5d571d288db649c4d7405e9b2 Bug-Url: https://bugzilla.redhat.com/872403 Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/VolumePopupView.ui.xml 1 file changed, 8 insertions(+), 6 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9281 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9abad6b3f53bbbf5d571d288db649c4d7405e9b2 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change Error Messages (#871864)
by msalem＠redhat.com 18 Nov '12

18 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Change Error Messages (#871864) ...................................................................... engine: Change Error Messages (#871864) This patch adds the vlan id to the error NETWORK_VLAN_IN_USE, and changes the range of legal vlan ids in the error to match the actual allowed range. Change-Id: I095ecde03174fabafbb556ffc82ba22a8b443a36 Bug-Url: https://bugzilla.redhat.com/871864 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateNetworkCommand.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 12 insertions(+), 10 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I095ecde03174fabafbb556ffc82ba22a8b443a36 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated timeout while adding host in AIO plugin
by oschreib＠redhat.com 18 Nov '12

18 Nov '12

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Updated timeout while adding host in AIO plugin ...................................................................... packaging: Updated timeout while adding host in AIO plugin Change-Id: I7a93690a68c699a68f93fc561ee9c5135179fd7f Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/plugins/all_in_one_100.py 1 file changed, 2 insertions(+), 1 deletion(-) Approvals: Ofer Schreiber: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9297 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a93690a68c699a68f93fc561ee9c5135179fd7f Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Free Mac Addresses in ImportVmCommand (#864346)
by msalem＠redhat.com 18 Nov '12

18 Nov '12

Muli Salem has submitted this change and it was merged. Change subject: engine: Free Mac Addresses in ImportVmCommand (#864346) ...................................................................... engine: Free Mac Addresses in ImportVmCommand (#864346) This patch adds a list of mac addresses that gathers all the macs that are added during ImportVmCommand, in case the command fails and these macs need to be released. Change-Id: I228d747be7e2c456e1777a51fd6fdfeca518bbbb Bug-Url: https://bugzilla.redhat.com/864346 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java 2 files changed, 22 insertions(+), 8 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9302 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I228d747be7e2c456e1777a51fd6fdfeca518bbbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0