Change in ovirt-engine-sdk[master]: sdk: release 3.2.0.5-1
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: release 3.2.0.5-1
......................................................................
sdk: release 3.2.0.5-1
Change-Id: If078e6ab7c797b8006502b3298999cf4ece7604c
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M Makefile
M ovirt-engine-sdk.spec.in
M setup.py
3 files changed, 5 insertions(+), 2 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9379
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If078e6ab7c797b8006502b3298999cf4ece7604c
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
12 years, 1 month
Change in ovirt-engine-sdk[master]: sdk: httpsconnection.source_address is not supported on pyth...
by mpastern@redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: httpsconnection.source_address is not supported on python26 #877897
......................................................................
sdk: httpsconnection.source_address is not supported on python26 #877897
https://bugzilla.redhat.com/show_bug.cgi?id=877897
Change-Id: Ibc539087d509168347bb527eff3105b878ceffe6
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtsdk/web/httpsconnection.py
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Oved Ourfali: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/9375
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibc539087d509168347bb527eff3105b878ceffe6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: engine: Remove a dead code from VdsManager
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: engine: Remove a dead code from VdsManager
......................................................................
engine: Remove a dead code from VdsManager
The following condition was removed from VdsManager because it will never be true.
_vdsUpdater is cleaned usually before realising a lock inside a VdsManager and exit
of critical section.
The method UpdateVmDynamic is usually called under lock of VdsManger, so always _vdsUpdater
will be null.
The method from VdsUpdateRuntimeInfo not in use anymore - that's why removed.
Change-Id: Ib79757485afc1cdcb505b10030b68c0d15a50fdb
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsUpdateRunTimeInfo.java
2 files changed, 0 insertions(+), 13 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9374
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib79757485afc1cdcb505b10030b68c0d15a50fdb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: core: Removed unneeded quartz job scheduling during run vm
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Removed unneeded quartz job scheduling during run vm
......................................................................
core: Removed unneeded quartz job scheduling during run vm
The following patch is simple, I remove a scheduled quarzt job which
should update the db.
The main problem which is solved it is a job was scheduled each run vm, so
under load we scheduled a number of jobs equals to number of run vms,
it is similar to DDOS attack on internal quartz scheduler.
Change-Id: I8d2365910f471bf01774d3ff7c7fb49520af5386
Signed-off-by: Michael Kublin <mkublin(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java
1 file changed, 11 insertions(+), 35 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9373
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d2365910f471bf01774d3ff7c7fb49520af5386
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: core: set storage domain format V3 for DC 3.2
by amureini@redhat.com
Allon Mureinik has submitted this change and it was merged.
Change subject: core: set storage domain format V3 for DC 3.2
......................................................................
core: set storage domain format V3 for DC 3.2
The automatic upgrade mechanism introduced in de5a415 didn't take in
account future data center versions.
Change-Id: I5fe0bde2616bb393b2d3c15da0b216531f58e54f
Signed-off-by: Federico Simoncelli <fsimonce(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Allon Mureinik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9249
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5fe0bde2616bb393b2d3c15da0b216531f58e54f
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: engine: cannot run VM when path is null in devices spec-para...
by shavivi@redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: engine: cannot run VM when path is null in devices spec-params
......................................................................
engine: cannot run VM when path is null in devices spec-params
Change-Id: I1d5e2d67adcbb46608a5349fdf39cd68e2108067
Bug-Url: https://bugzilla.redhat.com/875623
Signed-off-by: Shahar Havivi <shavivi(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9327
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1d5e2d67adcbb46608a5349fdf39cd68e2108067
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: webadmin: Messages text fixes
by ecohen@redhat.com
Einav Cohen has submitted this change and it was merged.
Change subject: webadmin: Messages text fixes
......................................................................
webadmin: Messages text fixes
In this patch, some fixes were made to some of the messages:
- Network engine is mandatory, it cannot be modified.
- The management Network (engine) is mandatory and cannot be removed.
For the messages above (in which "engine" represents the Management
Network), "engine" was replaced with a placeholder for the Management
Network name ("${NetworkName}"), which should be retreived from the
configuration instead of being hard-coded.
Also, the relevant engine commands that were referring to the messages
above were changed to include also a "parameter value" message (in the
form of "$NetworkName [network-name-from-configuration]") in the
relevant canDoActionMessages list.
- The default gateway should be set only on engine network
The message above was changed to:
The default gateway should be set only on the Management Network
At this point, this message cannot contain the actual management network
name placeholder (like the first two messages mentioned in this commit
comment), as this message is being used by the
NetworkInterfaceValidator, which doesn't seem to support multiple
messages / messages with parameters' placeholders.
- Internal oVirt Engine Error
- oVirt Engine has stopped
- oVirt History Service Started
- oVirt History Service Stopped
- oVirt History Service Error
- Could not connect to oVirt Engine Service, please try to refresh
- the page. If the problem persists contact your System Administrator
- Fencing is disabled due to oVirt Engine service start up sequence.
- Permission denied. oVirt Engine Administrator permission is required.
- Authentication Failed. Error in DNS configuration. Please verify
- the oVirt Engine Host has a valid reverse DNS (PTR) record.
- Authentication Failed. oVirt Engine clock is not synchronized with
directory services (must be within 5 minutes difference).
- Please verify the clocks are synchronized and restart the service.
- Login failed, if the oVirt Engine Service was restarted please wait
few seconds and try again, if the problem persists please
- check your oVirt Engine license.
- oVirt Engine has detected that the system clock has been modified
The (unnecessary) "oVirt" string was removed from the messages above.
Change-Id: I6368f77f174ff17b4f78856d01236eb07bae8e2a
Bug-Url: https://bugzilla.redhat.com/873036
Signed-off-by: Einav Cohen <ecohen(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/DetachNetworkToVdsGroupCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/AuthenticationResult.java
M backend/manager/modules/utils/src/test/resources/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/VdsmErrors.properties
13 files changed, 54 insertions(+), 48 deletions(-)
Approvals:
Einav Cohen: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9095
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6368f77f174ff17b4f78856d01236eb07bae8e2a
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: packaging: Fix double ownership of backups directory.
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Fix double ownership of backups directory.
......................................................................
packaging: Fix double ownership of backups directory.
Currently rpm installation of ovirt on fedora18 fails due to dual
package ownership of the backups directory.
This change fixes the ownership of the directory to -backend
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=876164
Change-Id: I57144d53cc672e3a75089b932e49af98751ed564
Signed-off-by: Ohad Basan <obasan(a)redhat.com>
---
M packaging/fedora/spec/ovirt-engine.spec.in
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9216
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I57144d53cc672e3a75089b932e49af98751ed564
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: engine: Added null check to avoid NPE
by ofrenkel@redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Added null check to avoid NPE
......................................................................
engine: Added null check to avoid NPE
If the qualified brick name is not available in the brick list,
may through null pointer exception. To avoid this null check is added.
Change-Id: I3ad34678038312072579a35b65d0879b523e15df
Signed-off-by: Dhandapani <dgopal(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeStatusReturnForXmlRpc.java
1 file changed, 8 insertions(+), 2 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/9117
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ad34678038312072579a35b65d0879b523e15df
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 1 month
Change in ovirt-engine[master]: packaging: change handling of sysctl.conf
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: change handling of sysctl.conf
......................................................................
packaging: change handling of sysctl.conf
in fedora 18 the location of /etc/sysctl.conf had changed to
/usr/lib/sysctl.d/00-system.conf
In case the patch doesn't find /etc/sysctl.conf it creates a new file
under /etc/sysctl.d and uses it instead.
Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=867833
Change-Id: I9ca4988beea1627b2da442a7fcf8fef3cf3db6a5
Signed-off-by: Ohad Basan <obasan(a)redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine-cleanup.py
M packaging/fedora/setup/engine-setup.py
3 files changed, 46 insertions(+), 12 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/8705
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ca4988beea1627b2da442a7fcf8fef3cf3db6a5
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ohad Basan <obasan(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
12 years, 1 month