November 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: NPEs in AddVmTemplate end methods after engine crash

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: NPEs in AddVmTemplate end methods after engine crash ...................................................................... core: NPEs in AddVmTemplate end methods after engine crash AddVmTemplateCommand endSuccesfully() method had 2 NPEs after engine crash occrured. 1. VmTemplateId wasn't set after loading the async task info because of wrong setter name 2. getVm() returned null because vm id is not set per the parent command parameters. Change-Id: I12c40cd3736a0516473de223ec84301f84983d3b Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AddVmTemplateParameters.java 2 files changed, 9 insertions(+), 3 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Vered Volansky: Looks good to me, but someone else must approve Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/9106 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I12c40cd3736a0516473de223ec84301f84983d3b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: compensate on wrong object leads to NPE

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: compensate on wrong object leads to NPE ...................................................................... core: compensate on wrong object leads to NPE Compensation during unlock vm is performed on the vm itself and not on the vm dynamic data, which causes to NPE during compensation process as the defined DAO for the status update is per vm dynamic. Change-Id: I9e10cbec65d0d9c8e66794a9fecf2e59facfdb45 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/9074 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9e10cbec65d0d9c8e66794a9fecf2e59facfdb45 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: errors during preview of diskless snapshots

by mlipchuk＠redhat.com

Maor Lipchuk has submitted this change and it was merged. Change subject: core: errors during preview of diskless snapshots ...................................................................... core: errors during preview of diskless snapshots 1. When creating a diskless snapshot, then adding a disk to the vm and later on try to preview that snapshots an NPE occurs within ovf writer. The exception occurs because of outdated disk information contained within the vm - the problem wasn't fixed locally but globally to prevent it from occuring in other flows as well. VmHandler.updateDisksFromDb() should clear the current disks of the vm otherwise we might get corrupted disk information for the vm (by adding the disks information from the DB while not clearing the present information). 2. When trying to run diskless snapshots exception can occur for various reason in VmHandler.updateVmInSpm(). When such exception occurs the operation should be rolled back (in the bug scenario - it wasn't as there were db updates that were executed with no transaction which led to partially rollback). Change-Id: I6e8edc74bc34676f526dfd24d2f89eb60d8acf2e Bug-Url: https://bugzilla.redhat.com/873595 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java 2 files changed, 16 insertions(+), 12 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified -- To view, visit http://gerrit.ovirt.org/9128 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e8edc74bc34676f526dfd24d2f89eb60d8acf2e Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: cleanup ActivateDeactivateVmNicCommand

by lhornyak＠redhat.com

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: cleanup ActivateDeactivateVmNicCommand ...................................................................... engine: cleanup ActivateDeactivateVmNicCommand use getVmNetworkInterfaceDao rather than DbFacade.getinstance().getVmNetworkInterfaceDao() Change-Id: Iabbfa46b3cbd9d0b01a10648583bcf90d9042bba Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9126 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iabbfa46b3cbd9d0b01a10648583bcf90d9042bba Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Fixing NPE at RegisterVdsQuery

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: engine: Fixing NPE at RegisterVdsQuery ...................................................................... engine: Fixing NPE at RegisterVdsQuery The following patch will fix a NPE which can occurred at RegisterVdsQuery during writting to logs Change-Id: I03199e5d16671d43b74e37dd28215bccfd4467e1 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 0 insertions(+), 4 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9177 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I03199e5d16671d43b74e37dd28215bccfd4467e1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: Re-run vm on other host if vm creation fail

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Re-run vm on other host if vm creation fail ...................................................................... engine: Re-run vm on other host if vm creation fail When an error with error code different than 'Done' or 'exists' is returned from VDSM while trying to run a vm, there would be an attempt to re-run the vm on other host. Change-Id: I35569a2ebfbea3e8eb69b414c31748c49cb29841 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=680743 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/CreateVmVDSCommand.java 2 files changed, 13 insertions(+), 0 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/9085 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I35569a2ebfbea3e8eb69b414c31748c49cb29841 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: engine: fix NPE in hosts tab

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: engine: fix NPE in hosts tab ...................................................................... engine: fix NPE in hosts tab Change-Id: I6a912226a46ffabb5def3a4937c598e10e6961b7 Bug-id: https://bugzilla.redhat.com/871293 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Shahar Havivi: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9151 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6a912226a46ffabb5def3a4937c598e10e6961b7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: core: lsm - live snapshots rollback

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: lsm - live snapshots rollback ...................................................................... core: lsm - live snapshots rollback * LiveMigrateDiskCommand: ** Marking taskGroupSuccesses as false when VM is UP. ** Overriding vdsId getter for nullity check. * LiveSnapshotTaskHandler: ** Executing only when taskGroupSuccess is true. ** CreateAllSnapshotsFromVmParameters - updating taskGroupSuccess (needed for CreateAllSnapshotsFromVmCommand -> endVmCommand). * AbstractSPMAsyncTaskHandler -> execute: ** Executing only when taskGroupSuccess is true. Change-Id: I24f9bc88623a9cd0addade874c7f2beeab67d423 Bug-Url: https://bugzilla.redhat.com/873329 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 3 files changed, 24 insertions(+), 26 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9142 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I24f9bc88623a9cd0addade874c7f2beeab67d423 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: no compat version for exported vm

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: no compat version for exported vm ...................................................................... webadmin: no compat version for exported vm Due to a change in the backend side, while fetching an exported vm, the compatibility version is empty. Therefore the disks subtab in the export dialog was empty (there is a check for hot_plug_enabled which depends on compat_version, this subtab is reused also in the disk main tab). not showing any disk data, prevents the user from changing disk allocation policy, destination SD and quota. Change-Id: If72968b984ad1637e879eea5e64dbc38a58828ed Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java 1 file changed, 14 insertions(+), 12 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9100 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If72968b984ad1637e879eea5e64dbc38a58828ed Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

12 years, 1 month

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Fixing typo - changing "till" to "until"

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Fixing typo - changing "till" to "until" ...................................................................... webadmin: Fixing typo - changing "till" to "until" This patch fixes more typos of "till" in UI monitoring of async tasks. Although there is a constant of untilEndTime, after consulting with Gilad, we decided to provide more flexibility and add this consult to represent time between two values. Change-Id: Id260d437914911c71cc2ea22d9a0314e62d72c77 Bug-Url: https://bugzilla.redhat.com/863294 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/footer/TasksTree.java 2 files changed, 4 insertions(+), 1 deletion(-) Approvals: Gilad Chaplik: Looks good to me, approved Yair Zaslavsky: Verified -- To view, visit http://gerrit.ovirt.org/9145 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id260d437914911c71cc2ea22d9a0314e62d72c77 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 1 month

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits November 2012