November 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Fixing http connection leak at proxy for SPM
by mkublin＠redhat.com 11 Nov '12

11 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Fixing http connection leak at proxy for SPM ...................................................................... core: Fixing http connection leak at proxy for SPM The following patch will fix a connection leak which we have during nullify of IrsProxy. A proxy is representating spm, each time that spm moved to maintaince or replaced we change a proxy, but coneection of http client was not closed. Also there are was some interesting code: set proxy to null and after that to call Dispose() method, where to shutdown connections when a proxy is not null - magic. Also I removed some one lines method, they don't help, and caused for a lot bugs especilaly at that class Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfee Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java 1 file changed, 22 insertions(+), 26 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9116 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iec0941108ae66c6174626915a45f02ab0996cfee Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Remove IsValidVDSCommand (Preporation for removing g...
by mkublin＠redhat.com 11 Nov '12

11 Nov '12

Michael Kublin has submitted this change and it was merged. Change subject: engine: Remove IsValidVDSCommand (Preporation for removing global lock on SPM ops) ...................................................................... engine: Remove IsValidVDSCommand (Preporation for removing global lock on SPM ops) The following patch will remove IsValidVDSCommand. The following command was used in order to check if pool is up and we have spm. First of all the using of command at canDoaction is wrong, a simple check for status of pool or status of domain should be enough. But the most exciting part is that the following command can trigger SPM election and it is done without any synchronization, so we can easilly have a couple spm elections simenteniously. The code at IsValidVDSCommand was getCurrentIrsProxyData().getIsValid(), which is actually code at IrsProxyData: getIrsProxy() != null, where getIrsProxy() is elect SPM if we have not one. Change-Id: I73c0fa0fd66f2f14132594a0b0450a7ecd7cf166 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/IsoDomainListSyncronizer.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStorageDomainCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommandTestAbstract.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IrsBrokerCommand.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/IsValidVDSCommand.java 14 files changed, 73 insertions(+), 159 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9097 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I73c0fa0fd66f2f14132594a0b0450a7ecd7cf166 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix upgrade scripts gap validation
by emesika＠redhat.com 10 Nov '12

10 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: fix upgrade scripts gap validation ...................................................................... core: fix upgrade scripts gap validation Current implementation of upgrade mechanism does not allow subsequent scripts to have more than a 10 gap in their numbering. For example, if last installed script is 03011500 then a subsequent upgrade with 03011501 to 03011510 is OK while 03011511 03011512 and so forth will be rejected. This patch fix bug when moving to another major version , for example from 0301 to 0302. It adds a condition that checks for gaps between two subsequent versions only if their major version (first 4 digits) match. Change-Id: Id260d437914911c71cc2ea22d9a0314e62d72c78 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/dbfunctions.sh 1 file changed, 12 insertions(+), 5 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9133 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id260d437914911c71cc2ea22d9a0314e62d72c78 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Generate UUIDs from engine
by emesika＠redhat.com 10 Nov '12

10 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Generate UUIDs from engine ...................................................................... core: Generate UUIDs from engine We used to generate UUIDs used as primary keys of bookmarks, tags, clusters hosts and pools in the database. This patch changes the engine so that it generates them directly and passes them as parameters to the stored procedures as needed. Note that some UUIDs can still be generated using the database function uuid_generate_v1 during first installation and upgrades, as upgrade scripts haven't been changed. Change-Id: Idecd3aa570017b4198243a9d3f9ebfdc7a777195 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/dbscripts/bookmarks_sp.sql M backend/manager/dbscripts/business_entity_snapshot_sp.sql M backend/manager/dbscripts/common_sp.sql M backend/manager/dbscripts/insert_data.sql M backend/manager/dbscripts/inst_sp.sql M backend/manager/dbscripts/tags_sp.sql M backend/manager/dbscripts/vds_groups_sp.sql M backend/manager/dbscripts/vds_sp.sql M backend/manager/dbscripts/vm_pools_sp.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/BusinessEntitySnapshot.java M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/NGuid.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BookmarkDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/BusinessEntitySnapshotDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/TagDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsGroupDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VdsStaticDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmPoolDAODbFacadeImpl.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsDAOImpl.java M packaging/fedora/setup/engine-setup.py 19 files changed, 81 insertions(+), 53 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Juan Hernandez: Verified -- To view, visit http://gerrit.ovirt.org/8990 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idecd3aa570017b4198243a9d3f9ebfdc7a777195 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: removed getVmNetworkInterfaceDao
by lhornyak＠redhat.com 08 Nov '12

08 Nov '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: core: removed getVmNetworkInterfaceDao ...................................................................... core: removed getVmNetworkInterfaceDao getVmNetworkInterfaceDao is doing the same as getVmNetworkInterfaceDAO defined declared in superclass. Change-Id: I22fa3778a4540e35a826ed6ea3ee5153df4e17a1 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ActivateDeactivateVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RestoreAllSnapshotCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java 12 files changed, 16 insertions(+), 21 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9105 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22fa3778a4540e35a826ed6ea3ee5153df4e17a1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Get Gluster Volume Profile Info Query
by ofrenkel＠redhat.com 08 Nov '12

08 Nov '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: Get Gluster Volume Profile Info Query ...................................................................... engine: Get Gluster Volume Profile Info Query - New entity classes for Gluster Volume Profile Info - New XmlRpc class for Profile Info - New bll and vds query - New Junit test for the query Change-Id: Ic47eb168bd4bcd5f3297a7e89a5ef46e643ed73e Signed-off-by: Dhandapani <dgopal(a)redhat.com> --- A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeProfileInfoQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BlockStats.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/BrickProfileDetails.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/FopStats.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/GlusterVolumeProfileInfo.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/ProfileStatsType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/gluster/StatsInfo.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterVolumeQueriesParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterVolumeProfileInfoVDSParameters.java M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeProfileInfoVDSCommand.java A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeProfileInfoReturnForXmlRpc.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 21 files changed, 673 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic47eb168bd4bcd5f3297a7e89a5ef46e643ed73e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Integer reference comparison fix
by masayag＠redhat.com 08 Nov '12

08 Nov '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Integer reference comparison fix ...................................................................... core: Integer reference comparison fix Changed the comparison from reference comparison(==) to equals on Integer values, since higher values of Integer are not cached, and there is no varanty even with lower values. Change-Id: I001fcb6349b36ee22e49e003c8391ad44002e5ac Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterManager.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9104 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I001fcb6349b36ee22e49e003c8391ad44002e5ac Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:PCI addresses are deleted when VM...(#873581)
by emesika＠redhat.com 07 Nov '12

07 Nov '12

Eli Mesika has submitted this change and it was merged. Change subject: core:PCI addresses are deleted when VM...(#873581) ...................................................................... core:PCI addresses are deleted when VM...(#873581) PCI addresses are deleted when VM Template is imported When a VM or Template is imported, we must set the VM/Template device addresses as appears in the OVF. This patch adds another signature to addManagedDevice with an additional address parameter and uses it for imported managed objects. Change-Id: I41a0826a82aaec39425261c9030d99cd3b462832 Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java 1 file changed, 35 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9087 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I41a0826a82aaec39425261c9030d99cd3b462832 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: VmBase - diskList member - remove final
by derez＠redhat.com 07 Nov '12

07 Nov '12

Daniel Erez has submitted this change and it was merged. Change subject: core: VmBase - diskList member - remove final ...................................................................... core: VmBase - diskList member - remove final Removing 'final' keyword from diskList member in VmBase. GWT RPC doesn't serialize 'private final' members (i.e. diskList is returned as null to the UI). Change-Id: I6bb5fe3d0abfd15f3b38233309a3f468f7fafdbf Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6bb5fe3d0abfd15f3b38233309a3f468f7fafdbf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Failed move disk should not set illegal disk.
by mlipchuk＠redhat.com 07 Nov '12

07 Nov '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: Failed move disk should not set illegal disk. ...................................................................... core: Failed move disk should not set illegal disk. When disk failed to be moved to another storage domain, the engine set the disk status to Illegal with the destination storage domain. The proposed fix, set the disk state to OK, with the original storage domain if the move task fails. By doing that, the user can use the VM disks even if the move operation failed. As part of the fix, some of the code which updated the destination storage domain in the disk, moved from the execute part to the EndSuccesfully section. Change-Id: I22c83bdd2e7182be49156c20992c494bcb68915a Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java 2 files changed, 25 insertions(+), 24 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9103 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22c83bdd2e7182be49156c20992c494bcb68915a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0