December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[master]: agent: rewrote nic's addresses functions in python 2.4 synta...
by bazulay＠redhat.com 26 Dec '12

26 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: agent: rewrote nic's addresses functions in python 2.4 syntax. ...................................................................... agent: rewrote nic's addresses functions in python 2.4 syntax. Change-Id: I17c6fb0dc2ac818677155444442f4a004f8463ec Signed-off-by: Gal Hammer <ghammer(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 8 insertions(+), 2 deletions(-) Approvals: Barak Azulay: Looks good to me, approved Gal Hammer: Verified -- To view, visit http://gerrit.ovirt.org/10378 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I17c6fb0dc2ac818677155444442f4a004f8463ec Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: fix NPE when adding vm with no cpu mode
by mpastern＠redhat.com 26 Dec '12

26 Dec '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: fix NPE when adding vm with no cpu mode ...................................................................... restapi: fix NPE when adding vm with no cpu mode A check whether the lately added attribute 'cpu mode' is defined (set) in a request before trying to map it to enum value was missing, thus creating a NPE. Change-Id: I94b2269a952e4dedcd08ee4b22940aeca020fb4c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10372 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I94b2269a952e4dedcd08ee4b22940aeca020fb4c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fixing compensation of RemoveStoragePool
by yzaslavs＠redhat.com 25 Dec '12

25 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing compensation of RemoveStoragePool ...................................................................... core: Fixing compensation of RemoveStoragePool The following patch takes advantage of the on delete cascacade defined for storage_pool_iso_map table on storage_pools and removes the explicity call to remove the stoage pool iso map entry. Bug-Url: https://bugzilla.redhat.com/889209 Change-Id: I09d8322c87bd4981c232fa8217532a541e24cc63 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStoragePoolCommand.java 1 file changed, 0 insertions(+), 9 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d8322c87bd4981c232fa8217532a541e24cc63 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: updated change-log for version 1.0.7
by bazulay＠redhat.com 25 Dec '12

25 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: updated change-log for version 1.0.7 ...................................................................... updated change-log for version 1.0.7 Change-Id: I8439b85ca0b479455dc7b03ff25ceccd04594f60 Signed-off-by: Gal Hammer <ghammer(a)redhat.com> --- M configure.ac M ovirt-guest-agent.spec 2 files changed, 8 insertions(+), 2 deletions(-) Approvals: Barak Azulay: Looks good to me, approved Gal Hammer: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8439b85ca0b479455dc7b03ff25ceccd04594f60 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup in VdsDeploy
by yzaslavs＠redhat.com 25 Dec '12

25 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: cleanup in VdsDeploy ...................................................................... core: cleanup in VdsDeploy Remove unused variable and code in VdsDeploy Change-Id: I09d8322c88bd4982c232fa8217532a541e24cc64 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsDeploy.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10290 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I09d8322c88bd4982c232fa8217532a541e24cc64 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webamin: hide cpuPin section according to config values
by gchaplik＠redhat.com 25 Dec '12

25 Dec '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webamin: hide cpuPin section according to config values ...................................................................... webamin: hide cpuPin section according to config values According to cpuPinningEnabled flag, and CpuPinMigrationEnabled flag in case of migration. Change-Id: Ifae4242379136d6dc580d1ee6c78757ff1e7e022 Bug-Url: https://bugzilla.redhat.com/867039 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 3 files changed, 29 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9664 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifae4242379136d6dc580d1ee6c78757ff1e7e022 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: pki: pending key fixups
by Alon Bar-Lev 25 Dec '12

25 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: pki: pending key fixups ...................................................................... vdsm: pki: pending key fixups pending key existence should be deferred to misc stage as we do not have the actual vdsm key store at validation stage. make the cleanup stage more verbose, so it won't have application logic. Change-Id: I937229e5d156777b409364a1a6d44f705f4d3fce Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/pki.py 1 file changed, 27 insertions(+), 20 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10362 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I937229e5d156777b409364a1a6d44f705f4d3fce Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: vdsm: pki: fix accept enrollment
by Alon Bar-Lev 25 Dec '12

25 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: vdsm: pki: fix accept enrollment ...................................................................... vdsm: pki: fix accept enrollment Due to python indent typo Change-Id: I2cb780e61a6071616187e0e21aae768866aba976 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/ovirt-host-deploy/vdsm/pki.py 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2cb780e61a6071616187e0e21aae768866aba976 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: core: misc: dump environment before validation
by Alon Bar-Lev 25 Dec '12

25 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: misc: dump environment before validation ...................................................................... core: misc: dump environment before validation Useful for debug. Change-Id: I026da7e83bd7cf9b17b73156c7e090649dd297fa Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/plugins/otopi/core/misc.py 1 file changed, 9 insertions(+), 0 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10360 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I026da7e83bd7cf9b17b73156c7e090649dd297fa Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in otopi[master]: core: config: add enforce environment configuration
by Alon Bar-Lev 25 Dec '12

25 Dec '12

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: config: add enforce environment configuration ...................................................................... core: config: add enforce environment configuration Change-Id: I50129b16d59a7ad8e1337fad9fc9b2cb650e8e0a Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M README M src/otopi/constants.py M src/plugins/otopi/core/config.py 3 files changed, 17 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10359 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I50129b16d59a7ad8e1337fad9fc9b2cb650e8e0a Gerrit-PatchSet: 1 Gerrit-Project: otopi Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0