December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-guest-agent[master]: Let udev reset user rights on virtio-channel during package ...
by bazulay＠redhat.com 25 Dec '12

25 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: Let udev reset user rights on virtio-channel during package removal ...................................................................... Let udev reset user rights on virtio-channel during package removal When the package is removed udev should be triggered to reset the access rights on the virtio-channel. Change-Id: If1c80a7f9068aa4f23710b0ba3afa43196e66520 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=882245 Signed-off-by: Vinzenz Feenstra <evilissimo(a)gmail.com> --- M ovirt-guest-agent.spec 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10286 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If1c80a7f9068aa4f23710b0ba3afa43196e66520 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: guest-agent: Unification of line endings to unix
by bazulay＠redhat.com 25 Dec '12

25 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: guest-agent: Unification of line endings to unix ...................................................................... guest-agent: Unification of line endings to unix Change-Id: I7f85bdc2c295c695d1877641eb89515b6f94974f Signed-off-by: Vinzenz Feenstra <vfeenstr(a)redhat.com> --- A .gitattributes M GinaSSO/GinaDlg.cpp M GinaSSO/GinaDlg.h M GinaSSO/GinaSSO.cpp M GinaSSO/GinaSSO.h M GinaSSO/GinaSSO.rc M GinaSSO/ReadMe.txt M GinaSSO/resource.h M GinaSSO/stdafx.cpp M GinaSSO/stdafx.h M gdm-plugin/test-login.py M ovirt-guest-agent/GuestAgentWin32.py M ovirt-guest-agent/OVirtGuestService.py M ovirt-guest-agent/WinFile.py M ovirt-guest-agent/consoleapps/Makefile.am M ovirt-guest-agent/pam/Makefile.am M ovirt-guest-agent/setup.py M pam-ovirt-cred/cred_channel.c M pam-ovirt-cred/test.c M windows-credprov/OVirtCredProv.cpp M windows-credprov/OVirtCredProv.h M windows-credprov/OVirtCredProv.rc 22 files changed, 2,616 insertions(+), 2,606 deletions(-) Approvals: Vinzenz Feenstra: Verified; Looks good to me, but someone else must approve Barak Azulay: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9463 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f85bdc2c295c695d1877641eb89515b6f94974f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Vinzenz Feenstra <vfeenstr(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Gal Hammer <ghammer(a)redhat.com> Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: userportal: Change VerticalPanel to FlowPanel
by alkaplan＠redhat.com 25 Dec '12

25 Dec '12

Alona Kaplan has submitted this change and it was merged. Change subject: userportal: Change VerticalPanel to FlowPanel ...................................................................... userportal: Change VerticalPanel to FlowPanel Replace VerticalPanel with FlowPanel in few places in the SideTabExtendedResouces. Change-Id: I597617bb8ac6a3bf5e81630751c739820cab2cef Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedResourceView.ui.xml 2 files changed, 10 insertions(+), 10 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10328 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I597617bb8ac6a3bf5e81630751c739820cab2cef Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: adding GetAllDisksByStorageDomainIdQuery
by derez＠redhat.com 24 Dec '12

24 Dec '12

Daniel Erez has submitted this change and it was merged. Change subject: core: adding GetAllDisksByStorageDomainIdQuery ...................................................................... core: adding GetAllDisksByStorageDomainIdQuery Adding a new query for getting DiskImages by StorageDomainId: GetAllDisksByStorageDomainIdQuery Change-Id: I017e12a7b3b77ee618f257ab3d719b98bc21eebc Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/dbscripts/disk_images_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksByStorageDomainIdQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAODbFacadeImpl.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/DiskImageDAOWrapperImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java 7 files changed, 65 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10321 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I017e12a7b3b77ee618f257ab3d719b98bc21eebc Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Chris Morrissey <cmorriss(a)netapp.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add comments to addDiskCommand
by mlipchuk＠redhat.com 24 Dec '12

24 Dec '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: add comments to addDiskCommand ...................................................................... core: add comments to addDiskCommand In case of async task execution, we need to set the found storage domain id in the parameters so we will have it during the run of the end methods, the added comments clarifies it. Change-Id: I818e38c98aaa2ed76239e4303df7d1bb20d3628b Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 8 insertions(+), 1 deletion(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10344 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I818e38c98aaa2ed76239e4303df7d1bb20d3628b Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Added option to filter by running
by masayag＠redhat.com 24 Dec '12

24 Dec '12

Moti Asayag has submitted this change and it was merged. Change subject: engine: Added option to filter by running ...................................................................... engine: Added option to filter by running The GetVmsAndNetworkInterfacesByNetworkIdQuery can now optionally filter only the VMs that are either 'running' or 'not running'. Change-Id: I3af34ab30cc9eb6ee71ac1fe4fbd5d8f676f1453 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsAndNetworkInterfacesByNetworkIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmsAndNetworkInterfacesByNetworkIdQueryTest.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsAndNetworkInterfacesByNetworkIdParameters.java 3 files changed, 69 insertions(+), 12 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10348 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3af34ab30cc9eb6ee71ac1fe4fbd5d8f676f1453 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine, webadmin: Add specific query parameters
by mkolesni＠redhat.com 24 Dec '12

24 Dec '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine, webadmin: Add specific query parameters ...................................................................... engine, webadmin: Add specific query parameters Added specific parameters for GetVmsAndNetworkInterfacesByNetworkId query. These parameters are needed to add support for filtering the result by VMs that are 'running' and not 'running'. Query call was modified to use these parameters and in the next patches the filtering will be added. Change-Id: Iddf5de505092dfc3081f8b6b52fc3b4f74c09412 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetVmsAndNetworkInterfacesByNetworkIdQuery.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetVmsAndNetworkInterfacesByNetworkIdQueryTest.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetVmsAndNetworkInterfacesByNetworkIdParameters.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/networks/NetworkVmListModel.java 4 files changed, 33 insertions(+), 9 deletions(-) Approvals: Mike Kolesnik: Verified Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10347 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iddf5de505092dfc3081f8b6b52fc3b4f74c09412 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: Fixed support for reporting devices with only ipv6.
by bazulay＠redhat.com 24 Dec '12

24 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: Fixed support for reporting devices with only ipv6. ...................................................................... Fixed support for reporting devices with only ipv6. ethtool.get_active_devices does not consider as up the devices that have only an IPv6 address set. Also, it throws an IOError exception when doing get_ipaddr of a device that is up but does not have an IPv4 address set. Thus, doing the filtering by using the device flags and getting the IPv4 address in a similar way as how we get the IPv6 one, not only fixes the issue but increases the consistency of the code. Change-Id: I92010740da24bb30c7316c268c704d9067b28aae Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 11 insertions(+), 5 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I92010740da24bb30c7316c268c704d9067b28aae Gerrit-PatchSet: 5 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-guest-agent[master]: Fix pep8 errors in the linux guest agent.
by bazulay＠redhat.com 24 Dec '12

24 Dec '12

Barak Azulay has submitted this change and it was merged. Change subject: Fix pep8 errors in the linux guest agent. ...................................................................... Fix pep8 errors in the linux guest agent. Cleanup of the code to bring it up to standards of the rest of ovirt. Change-Id: I7e8e12bdf42ef86d88a0d4d38750f2e1bc739e22 Signed-off-by: Antoni S. Puimedon <asegurap(a)redhat.com> --- M ovirt-guest-agent/GuestAgentLinux2.py 1 file changed, 54 insertions(+), 41 deletions(-) Approvals: Barak Azulay: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10218 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7e8e12bdf42ef86d88a0d4d38750f2e1bc739e22 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-guest-agent Gerrit-Branch: master Gerrit-Owner: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: cleanup RunVmCommand#statelessVmTreatment
by rgolan＠redhat.com 24 Dec '12

24 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: cleanup RunVmCommand#statelessVmTreatment ...................................................................... core: cleanup RunVmCommand#statelessVmTreatment - Remove unnecessary local field 'p' - Rename 'tmpVar' field to 'createAllSnapshotsFromVmParameters', so that the name will be more meaningful Change-Id: I967b4af546e14a00ac74764458b3cb2c3d946beb Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java 1 file changed, 9 insertions(+), 10 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10331 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I967b4af546e14a00ac74764458b3cb2c3d946beb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0