December 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: introduce InternalMigrateVmParameters
by rgolan＠redhat.com 24 Dec '12

24 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: introduce InternalMigrateVmParameters ...................................................................... core: introduce InternalMigrateVmParameters Introduce InternalMigrateVmParameters class that should be used when calling internal migrate command. It replaces MigrateVmParameters that was previously used, and was confusing as it let the caller set 'force migration' flag which isn't in use in internal migration operation. Change-Id: I6054e71c99ac8dfc2f281d835048af597a9742c0 Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmParameters.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java 3 files changed, 32 insertions(+), 10 deletions(-) Approvals: Roy Golan: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/10319 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6054e71c99ac8dfc2f281d835048af597a9742c0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Refactor InternalMigrateVmCommand#canMigrateVm
by rgolan＠redhat.com 24 Dec '12

24 Dec '12

Roy Golan has submitted this change and it was merged. Change subject: core: Refactor InternalMigrateVmCommand#canMigrateVm ...................................................................... core: Refactor InternalMigrateVmCommand#canMigrateVm Change InternalMigrateVmCommand#canMigrateVm method such that: 1. The check whether the vm is migratable is being done before calling super.canMigrateVm. That way, the checks in MigrateVmCommand#canMigrateVm won't be made if the vm is not migratable, as they are irrelevant in that case. 2. Add a proper error in case InternalMigrateVmCommand fails because the VM is not migratable. Change-Id: Ida10d53ccd5321d3ccc510bd2111fa013dcdcdbe Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 19 insertions(+), 10 deletions(-) Approvals: Roy Golan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10107 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida10d53ccd5321d3ccc510bd2111fa013dcdcdbe Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: #839205 Display Host Hooks
by oliel＠redhat.com 24 Dec '12

24 Dec '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: #839205 Display Host Hooks ...................................................................... restapi: #839205 Display Host Hooks https://bugzilla.redhat.com/839205 Change-Id: I38a3d38cc52d5ec77f55fe7db4d5e47b09568ca7 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostHookResource.java A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostHooksResource.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/HostResource.java M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResource.java A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHookResourceTest.java A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostHooksResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java 10 files changed, 366 insertions(+), 0 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/9478 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I38a3d38cc52d5ec77f55fe7db4d5e47b09568ca7 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: error when adding disks without specifying storage dom...
by mlipchuk＠redhat.com 24 Dec '12

24 Dec '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core: error when adding disks without specifying storage domain ...................................................................... core: error when adding disks without specifying storage domain When adding a disk and no storage domain id is passed by the parameters, there is an attempt to get the storage domain id from the first vm disk - if this disk is a LUN disk, it won't have storage domain id and we won't be able to add the new image disk. Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e Bug-Url: https://bugzilla.redhat.com/876109 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java 1 file changed, 22 insertions(+), 9 deletions(-) Approvals: Maor Lipchuk: Looks good to me, approved Liron Aravot: Verified; Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/10289 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icc3fce53eaeca31b7b479019ba195b60e248c88e Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: history: changed minimal etl version to 3.2.0
by yzaslavs＠redhat.com 24 Dec '12

24 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: history: changed minimal etl version to 3.2.0 ...................................................................... history: changed minimal etl version to 3.2.0 Change-Id: Ic2e0ff9e34b77950c939e5fd380bc4d480b058f6 Signed-off-by: Yaniv Dary <ydary(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10326 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic2e0ff9e34b77950c939e5fd380bc4d480b058f6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Add event for MAC pool initialization error
by yzaslavs＠redhat.com 24 Dec '12

24 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Add event for MAC pool initialization error ...................................................................... core: Add event for MAC pool initialization error This patch performs two issues: a. Fixing inconsistency in handling MacPoolManager.freeMac (in some cases - the exception is caught and ignored, in some cases - not - this is behavior is incorrect). b. Introducing event to mark failure in mac pool initialization (similar to the event log of mac address already in use) Bug-Url: https://bugzilla.redhat.com/885441 Change-Id: Ibaa3d9eb23016b4866e5cfa39f919378e09fdf2d signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 5 files changed, 16 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10197 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibaa3d9eb23016b4866e5cfa39f919378e09fdf2d Gerrit-PatchSet: 13 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Improving synchronization of MacPoolManager
by yzaslavs＠redhat.com 24 Dec '12

24 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Improving synchronization of MacPoolManager ...................................................................... core: Improving synchronization of MacPoolManager Improving the synchronization of MacPpoolManager, changing from synchronzied to RWLock, and changing the synchronization of freeMacs (the write lock should be locked one for all macs that are removed) Change-Id: I62fa797fbf286513183f0a3c3409cd79bdc25341 Bug-Url: https://bugzilla.redhat.com/885441 signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java 1 file changed, 44 insertions(+), 14 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10193 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I62fa797fbf286513183f0a3c3409cd79bdc25341 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Improving MacPoolManager initialization
by yzaslavs＠redhat.com 24 Dec '12

24 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Improving MacPoolManager initialization ...................................................................... core: Improving MacPoolManager initialization Instead of getting all Vms, and for each vm getting its vm network interface, this patch perform one call to get all vm interfaces Change-Id: I76083f372ed5d9ab124047bcadb03b77e24163f0 Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java 1 file changed, 3 insertions(+), 8 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10188 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I76083f372ed5d9ab124047bcadb03b77e24163f0 Gerrit-PatchSet: 7 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: implementing VmInterfaceDAO.getAll()
by yzaslavs＠redhat.com 24 Dec '12

24 Dec '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: implementing VmInterfaceDAO.getAll() ...................................................................... core: implementing VmInterfaceDAO.getAll() This change exposes GetAllFromvm_interface psql function to the proper Dao This change also changes the type return from the psql function to conform to other get functions. This is a first patch in a series of patches regarding initialization and handling of MacPoolManager Bug-Url: https://bugzilla.redhat.com/885441 Change-Id: I142198d2059cf109be3859f255621e6ceca8581a Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/dbscripts/network_sp.sql M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/FixturesTool.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmNetworkInterfaceDAOTest.java 4 files changed, 9 insertions(+), 7 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I142198d2059cf109be3859f255621e6ceca8581a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Network tab, minor sub tab fixes
by alkaplan＠redhat.com 24 Dec '12

24 Dec '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: Network tab, minor sub tab fixes ...................................................................... webadmin: Network tab, minor sub tab fixes network->host. - default should be attached. - s/Nic/Network Device (on all the columns that contain Nic) - add Speed column network->cluster - s/Netwrok Required/Required Network - s/Network Attached/Attached Network - centralize checkbox columns Change-Id: I7d95ba68ae691a3b62d5cc7cf24b0a3957150812 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/ViewRadioGroup.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/CheckboxColumn.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkClusterView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/network/SubTabNetworkHostView.java 6 files changed, 53 insertions(+), 18 deletions(-) Approvals: Alona Kaplan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10329 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d95ba68ae691a3b62d5cc7cf24b0a3957150812 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0