Change in ovirt-engine[master]: engine, webadmin: oVirt Modes - Event Notifier changes
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine,webadmin: oVirt Modes - Event Notifier changes
......................................................................
engine,webadmin: oVirt Modes - Event Notifier changes
Event Notification List in Add Event Notification dialog
should be shown according to the mode. For example Gluster
related events should not be shown if the application is running
in VirtOnly mode.
Following changes are done to make this work:
1. EventNotificationEntity is modied to suuport mode specifications.
2. UiMode is renamed to ApplicationMode and moved to common module
as it is required in EventNotificationEntity
3. A new utility method is added to ApplicationModeHelper to filter
the event notification list according to the mode.
Change-Id: I5ec5840b1e2a78fb5f7b49280eb6b13ace74b15a
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/EventNotificationEntity.java
R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/mode/ApplicationMode.java
M frontend/webadmin/modules/gwt-common/src/main/resources/org/ovirt/engine/core/Common.gwt.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplicationModeHelper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/Model.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserEventNotifierListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserQuotaListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/volumes/VolumeListModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uimode/UiModeData.java
17 files changed, 77 insertions(+), 48 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4659
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5ec5840b1e2a78fb5f7b49280eb6b13ace74b15a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: engine: Gluster Host Remove Command
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Gluster Host Remove Command
......................................................................
engine: Gluster Host Remove Command
Includes following related to the command "Gluster Peer Detach"
- New VDS Command
- Audit Log messages and severities
- JUnit tests
- App Errors
- VDSM Errors
Change-Id: I0c82837ba911d96a1ab10d11f62d43e9e8ad4d90
Signed-off-by: Dhandapani <dgopal(a)redhat.com>
---
M backend/manager/dbscripts/gluster_volumes_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVdsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/RemoveVdsCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TestHelperImportVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/errors/VdcBllErrors.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/gluster/GlusterHostRemoveVDSParameters.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBase.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDao.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoDbFacadeImpl.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/gluster/GlusterVolumeDao.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
M backend/manager/modules/dal/src/main/resources/bundles/VdsmErrors.properties
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogableBaseTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/gluster/GlusterBrickDaoTest.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/AbstractGlusterBrokerCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterHostRemoveVDSCommand.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/VdsmErrors.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
30 files changed, 224 insertions(+), 17 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Dhandapani Gopal: Verified
--
To view, visit http://gerrit.ovirt.org/4512
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0c82837ba911d96a1ab10d11f62d43e9e8ad4d90
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: restapi: Support Floating Disks
by oliel＠redhat.com
Ori Liel has submitted this change and it was merged.
Change subject: restapi: Support Floating Disks
......................................................................
restapi: Support Floating Disks
disks are now also a root collection (under /api)
attach disk is done by adding an existing disk (identified by id) to a VM
detach disk is done by deleting an existing disk from a VM, passing <detach>true</detach>
Change-Id: I314ba532b1a40286053f87bb4f0f3c90b5850b5a
Signed-off-by: Ori Liel <oliel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllDisksQuery.java
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDiskByDiskIdQuery.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/AttachDettachVmDiskParameters.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/GetDiskByDiskIdParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
M backend/manager/modules/restapi/interface/common/jaxrs/src/main/java/org/ovirt/engine/api/common/util/LinkHelper.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DiskResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/DisksResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDiskResource.java
A backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmDisksResource.java
M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/resource/VmResource.java
M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd
M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendApiResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDiskResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResource.java
A backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java
M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQuery.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendApiResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDiskResourceTest.java
M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendDisksResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDiskResourceTest.java
A backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmDisksResourceTest.java
M backend/manager/modules/restapi/webapp/src/main/webapp/WEB-INF/applicationContext.xml
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java
30 files changed, 1,036 insertions(+), 702 deletions(-)
Approvals:
Ori Liel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4665
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I314ba532b1a40286053f87bb4f0f3c90b5850b5a
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: Avoid aborting the current TX when destroying stateles...
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: Avoid aborting the current TX when destroying stateless VM
......................................................................
core: Avoid aborting the current TX when destroying stateless VM
problem:
when destroying a VM some actions taken in new transaction
which invokes internal commands that can abort it.
solution:
invoke the code with the posiblle side-effects in a new transaction. the outcome of this flow
is not relevant, we just need to isolate it in a new TX to prevent rollbacking the current.
backgroud:
When a stateless VM is destroyed we invoke the a method that treats a VM stop
in the event listener. This direct invocation of the event listerner is exclusive to the Destroy command
for usually, the treatment is invoked when the VM status, which is reported by VDSM, is changing.
Since the VM has been destoryed already its not reported anymore and the proccessOnVmStop must be called manually.
Change-Id: I623e118420a748d091699049242a050248ca1ce1
Signed-off-by: Roy Golan <rgolan(a)redhat.com>
---
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/DestroyVmVDSCommand.java
1 file changed, 25 insertions(+), 8 deletions(-)
Approvals:
Roy Golan: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4656
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I623e118420a748d091699049242a050248ca1ce1
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: packaging: Added traceback info to the log when error happe...
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Added traceback info to the log when error happens (#818079)
......................................................................
packaging: Added traceback info to the log when error happens (#818079)
https://bugzilla.redhat.com/show_bug.cgi?id=818079
* Added printing debug information to log file, including traceback
for the exception that happened. The error is printed to the log at
the moment it happens, and that is in addition to the printing at
the end of the logfile.
Change-Id: I049231cf6a19c8ef808e378e50b94ca428099209
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/setup_sequences.py
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Alex Lourie: Verified; Looks good to me, but someone else must approve
Ofer Schreiber: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4753
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I049231cf6a19c8ef808e378e50b94ca428099209
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: [rmd] OvfManager
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: [rmd] OvfManager
......................................................................
core: [rmd] OvfManager
Removed RefObject usage from OvfManager and related classes.
Change-Id: I781f152e668f51bb313b9a81822df8c21b934a1b
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/snapshots/SnapshotsManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetTemplatesFromExportDomainQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetVmsFromExportDomainQuery.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfManager.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfVmWriter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GetImportCandidatesInfoVDSCommand.java
11 files changed, 56 insertions(+), 125 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4502
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I781f152e668f51bb313b9a81822df8c21b934a1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine-cli[master]: cli: Implement history browsing mechanism #823512
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: Implement history browsing mechanism #823512
......................................................................
cli: Implement history browsing mechanism #823512
implemented:
1. persistent history stack
2. recursive history search - ctrl+r
3. history listing - history
4. history slide retrieval - history N
https://bugzilla.redhat.com/show_bug.cgi?id=823512
Change-Id: Ibf390532331ae2b47952b1556b0d3267f80b09d5
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
A src/ovirtcli/historymanager.py
M src/ovirtcli/shell/engineshell.py
A src/ovirtcli/shell/historycmdshell.py
3 files changed, 146 insertions(+), 5 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4718
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf390532331ae2b47952b1556b0d3267f80b09d5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 11 months
Change in ovirt-engine-cli[master]: cli: Implement pipe redirection to linux shell #823508
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: Implement pipe redirection to linux shell #823508
......................................................................
cli: Implement pipe redirection to linux shell #823508
done, fixing format leftover
https://bugzilla.redhat.com/show_bug.cgi?id=823508
Change-Id: I3aa53c7e2488154ef5c1dafe2f2e9e9d3b40df11
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/cli/context.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4694
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3aa53c7e2488154ef5c1dafe2f2e9e9d3b40df11
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 11 months
Change in ovirt-engine-cli[master]: cli: exit on incorrect option
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: exit on incorrect option
......................................................................
cli: exit on incorrect option
Change-Id: I337535a738ccc00f6d9a55126b71edddea9a3779
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/options.py
1 file changed, 6 insertions(+), 0 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4693
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I337535a738ccc00f6d9a55126b71edddea9a3779
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 11 months
Change in ovirt-engine-sdk[master]: sdk: combine RequestError detail only if response body not e...
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: combine RequestError detail only if response body not empty
......................................................................
sdk: combine RequestError detail only if response body not empty
Change-Id: I396a6ae2434abcb30662d6d985398e7af71fbf19
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtsdk/infrastructure/errors.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ori Liel: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4691
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I396a6ae2434abcb30662d6d985398e7af71fbf19
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
11 years, 11 months