Change in ovirt-engine[master]: core: Add shareable check before version check
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: Add shareable check before version check
......................................................................
core: Add shareable check before version check
Adding shareable check before validating version check
Change-Id: Icc0440456db388df3af3b2804135ed1a2e7701fe
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4749
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc0440456db388df3af3b2804135ed1a2e7701fe
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: engine: New query to fetch Gluster Volume Bricks by Volume I...
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: New query to fetch Gluster Volume Bricks by Volume ID
......................................................................
engine: New query to fetch Gluster Volume Bricks by Volume ID
- Added entry in the VdcQueryType
- Introduced the Query class
- Mockito JUnit test for the query
Change-Id: I27c04482781f02d70b9c7f114c8acb309b15330e
Signed-off-by: Dhandapani <dgopal(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeBricksQuery.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterQueriesCommandBase.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeBricksQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
4 files changed, 90 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Dhandapani Gopal: Verified
--
To view, visit http://gerrit.ovirt.org/4655
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I27c04482781f02d70b9c7f114c8acb309b15330e
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: fix job properties in export vm and template (#818114)
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: core: fix job properties in export vm and template (#818114)
......................................................................
core: fix job properties in export vm and template (#818114)
https://bugzilla.redhat.com/show_bug.cgi?id=818114
added implementation to getJobMessageProperties in Export{Vm,Template}Command,
that add the vm/template in order to show its name.
Change-Id: I72938ea1962f16b490d7baaa294f304c95ebb525
Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java
2 files changed, 23 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4683
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I72938ea1962f16b490d7baaa294f304c95ebb525
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core:Refactor locking mechanism
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Refactor locking mechanism
......................................................................
core:Refactor locking mechanism
Refactor lock mechanism by swithing the key with the value.
Instead using entity name as key and guid as value, now the key will be
the GUI and the value will be the entity name.
This fix should be since now with shareable disk, there can be multiple
VMs which can be locked in one operation.
Change-Id: Icbe9e0eb5a0ec2e8af899b3e554b1cb6fccc6835
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachUserToVmFromPoolAndRunCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateAllSnapshotsFromVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveSnapshotCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RestoreAllSnapshotsCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/TryBackToAllSnapshotsOfVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lock/InMemoryLockManager.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStoragePoolWithStoragesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/lock/InMemoryLockManagerTest.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/lock/EngineLock.java
16 files changed, 58 insertions(+), 58 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4663
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icbe9e0eb5a0ec2e8af899b3e554b1cb6fccc6835
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core:Update VmDao to return multiple Vms for disk.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Update VmDao to return multiple Vms for disk.
......................................................................
core:Update VmDao to return multiple Vms for disk.
Changed the API of the VMDao to return list of VMs.
Also since now disk can be on multiple Vms, the validation if disk is part of
VM should reference a list of VMs.
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: Ib8d0bbef4828100217e488d6dbab1b81ee65103d
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractDiskVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateSnapshotCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotPlugDiskToVmCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/HotUnPlugDiskFromVmCommandTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java
7 files changed, 72 insertions(+), 10 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4491
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib8d0bbef4828100217e488d6dbab1b81ee65103d
Gerrit-PatchSet: 12
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core:Use attachable disk for shareable
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Use attachable disk for shareable
......................................................................
core:Use attachable disk for shareable
Add shareable disks to be part of the suggested attachable disk list.
Add test for shareable disk
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: I9e69edcd5ab63d09ae35abaec4ba6991978369be
---
M backend/manager/dbscripts/all_disks_sp.sql
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/DiskImageDAOTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/ImageDaoTest.java
M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDeviceDAOTest.java
M backend/manager/modules/dal/src/test/resources/fixtures.xml
6 files changed, 40 insertions(+), 8 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4488
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9e69edcd5ab63d09ae35abaec4ba6991978369be
Gerrit-PatchSet: 13
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core:Support move of shareable disk
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Support move of shareable disk
......................................................................
core:Support move of shareable disk
Support shareable disk move operation.
Since all_disks list will return multi columns of VMs, it needed to be
considered in the CDA validation.
As part of the shareable disk, the locking mechanism has been changed
with the following changes:
1. Change the lock to log all the VMs which has shared lock
2. Use lock in the end of the CDA
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: I8c59562fdd45cea4628c1e40e65713581647f86f
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyImageGroupCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommandTest.java
3 files changed, 64 insertions(+), 16 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4492
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8c59562fdd45cea4628c1e40e65713581647f86f
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core:Validate shareable disk which attached to VMs
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Validate shareable disk which attached to VMs
......................................................................
core:Validate shareable disk which attached to VMs
Use validation when updating disk to be un shared any more.
If the disk is attached to VMs then CDA message should block the
operation.
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: I1024782e96f341d0c9b1d24eb283e76797c0a128
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmDiskCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmDiskCommandTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
8 files changed, 71 insertions(+), 12 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1024782e96f341d0c9b1d24eb283e76797c0a128
Gerrit-PatchSet: 16
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core:Change CDA message to fit shareable disk
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Change CDA message to fit shareable disk
......................................................................
core:Change CDA message to fit shareable disk
Use CDA message to fit more for shareable disks.
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: I15e648267a78a76a5390ad24367a7cb2e9b8a2a3
---
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/src/test/resources/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/userportal/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties
6 files changed, 6 insertions(+), 6 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4639
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I15e648267a78a76a5390ad24367a7cb2e9b8a2a3
Gerrit-PatchSet: 21
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core:Support remove of shareable disk.
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Support remove of shareable disk.
......................................................................
core:Support remove of shareable disk.
The following patch has the following changes:
1.Adding support to remove disk from multiple vms.
The remove command was counting on the vm id which was in the disk.
After this change the vmId will be fetched from the DB.
2.Update vm device store procedures to use vmId as a parameter when remove
or getting a vm device.
This is neccessery for the Activate/Deactivate process to work for
shareable disk.
3.Update the lock mechanism in the remove disk command to log the VMs
which are using in the shared lock, and also change the aquire lock to be at
the end of the CDA instead before the validation.
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: Idde509a7bdee94e6fd481fce510b26f89d6b0429
---
M backend/manager/dbscripts/vm_device_sp.sql
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveImageCommand.java
3 files changed, 54 insertions(+), 29 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4490
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idde509a7bdee94e6fd481fce510b26f89d6b0429
Gerrit-PatchSet: 18
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
12 years, 7 months