Change in ovirt-engine[master]: core: Refactor out a method for network devices
by mkolesni＠redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Refactor out a method for network devices
......................................................................
core: Refactor out a method for network devices
Refactor out a method to add network device as part or VmDeviceUtils
which can also be used in other places to add network devices.
Change-Id: I08572b80c5255841b674ff04b2bb8877771873cf
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
2 files changed, 18 insertions(+), 10 deletions(-)
Approvals:
Mike Kolesnik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4660
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08572b80c5255841b674ff04b2bb8877771873cf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 12 months
Change in ovirt-engine[master]: webadmin: NetworkModel - remove redundant properties
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: NetworkModel - remove redundant properties
......................................................................
webadmin: NetworkModel - remove redundant properties
* Removing unused properties: Address/Subnet/Gateway.
* Removing redundant validation for these unused properties.
Change-Id: I9073d15ccad94b2e688f63db54dd0d8efdd1e78e
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/NetworkModel.java
1 file changed, 2 insertions(+), 49 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4672
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9073d15ccad94b2e688f63db54dd0d8efdd1e78e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
11 years, 12 months
Change in ovirt-dwh[master]: etl: fixed old row in sample tables (#783787)
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: fixed old row in sample tables (#783787)
......................................................................
etl: fixed old row in sample tables (#783787)
ETL didn't check all the rables for more old rows to delete.
Added check for all sample tables.
https://bugzilla.redhat.com/783787
Change-Id: I7ab013f405e7006aeca1e8d5c675af3fe3c8bba5
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/deletetimekeepingjob_3_0/DeleteTimeKeepingJob.java
M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.0.item
M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.0.properties
3 files changed, 4,238 insertions(+), 7 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4706
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7ab013f405e7006aeca1e8d5c675af3fe3c8bba5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 12 months
Change in ovirt-engine[master]: webadmin: Posix FS storage type (storage dialog)
by achub＠redhat.com
Alexey Chub has submitted this change and it was merged.
Change subject: webadmin: Posix FS storage type (storage dialog)
......................................................................
webadmin: Posix FS storage type (storage dialog)
Change-Id: I6124b2594138256e3dce04d87bf5b9c5c18a293b
Signed-off-by: Alexey Chub <achub(a)redhat.com>
---
A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelTextBoxOnlyEditor.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/DataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/NfsStorageModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/PosixStorageModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.java
A frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/PosixStorageView.ui.xml
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/storage/StoragePopupView.ui.xml
13 files changed, 1,044 insertions(+), 532 deletions(-)
Approvals:
Alexey Chub: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4617
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6124b2594138256e3dce04d87bf5b9c5c18a293b
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alexey Chub <achub(a)redhat.com>
Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com>
11 years, 12 months
Change in ovirt-dwh[master]: etl: fixed connection issue (#817519)
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: fixed connection issue (#817519)
......................................................................
etl: fixed connection issue (#817519)
ETL opened connections to ovirt engine portal and never
disconnected, which caused issues with JBoss start.
Added disconnect to pervent this issue.
https://bugzilla.redhat.com/817519
Change-Id: I1cbd239eac987c041c751635abafa6684cc6b56e
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/historyetl_3_0/HistoryETL.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_3_0/SampleTimeKeepingJob.java
M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.0.properties
M data-warehouse/history_etl/tos_project/process/HistoryETL_3.0.item
M data-warehouse/history_etl/tos_project/process/HistoryETL_3.0.properties
M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.0.item
M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.0.properties
7 files changed, 17 insertions(+), 11 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4705
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1cbd239eac987c041c751635abafa6684cc6b56e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 12 months
Change in ovirt-engine[master]: webadmin: 'Attach Disk' in VmGuideModel AddDisk
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: 'Attach Disk' in VmGuideModel AddDisk
......................................................................
webadmin: 'Attach Disk' in VmGuideModel AddDisk
Fixed 'Attach Disk' in 'GuideMe -> New Disk' dialog
Change-Id: Id11bf271f5927a85be28f546f8fb1c9d5c8599aa
Signed-off-by: Daniel Erez <derez(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmGuideModel.java
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id11bf271f5927a85be28f546f8fb1c9d5c8599aa
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
11 years, 12 months
Change in ovirt-dwh[master]: etl: fixed minor error in job
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: fixed minor error in job
......................................................................
etl: fixed minor error in job
Change-Id: Ifb1f634e5808e9bf89a6d134fbfcd72bfee32acb
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.0.item
M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.0.properties
2 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4704
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ifb1f634e5808e9bf89a6d134fbfcd72bfee32acb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 12 months
Change in ovirt-dwh[master]: etl: updated tos to version 5.1.0
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: etl: updated tos to version 5.1.0
......................................................................
etl: updated tos to version 5.1.0
Change-Id: Ic70039a5de1ad5d4edac74d81f375bf2b743184a
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/aggregationtodaily_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/aggregationtohourly_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/configurationsync_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/dailytimekeepingjob_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/deletetimekeepingjob_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/historydelete_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/historyetl_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/hostconfigcheck_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/hourlytimekeepingjob_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/minimalversioncheck_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/parallelrun_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/samplerunjobs_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/sampletimekeepingjob_3_0/contexts/Default.properties
M data-warehouse/history_etl/context_files/ovirt_engine_dwh/statisticssync_3_0/contexts/Default.properties
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtodaily_3_0/AggregationToDaily.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/aggregationtohourly_3_0/AggregationToHourly.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/configurationsync_3_0/ConfigurationSync.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/dailytimekeepingjob_3_0/DailyTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/deletetimekeepingjob_3_0/DeleteTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/historydelete_3_0/HistoryDelete.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/historyetl_3_0/HistoryETL.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/hostconfigcheck_3_0/HostConfigCheck.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/hourlytimekeepingjob_3_0/HourlyTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/minimalversioncheck_3_0/MinimalVersionCheck.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/parallelrun_3_0/ParallelRun.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/samplerunjobs_3_0/SampleRunJobs.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/sampletimekeepingjob_3_0/SampleTimeKeepingJob.java
M data-warehouse/history_etl/etl_sources/historyETLProcedure/src/main/java/ovirt_engine_dwh/statisticssync_3_0/StatisticsSync.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/DataOperation.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/Mathematical.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/Numeric.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/Relational.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/StringHandling.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/TalendDataGenerator.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/TalendDate.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/TalendString.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/AssertCatcherUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/BufferedOutput.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/Document.java
A data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/DocumentToFlat.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/FastDateParser.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/FormatterUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/GlobalResource.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/LocaleProvider.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/LogCatcherUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/MetterCatcherUtils.java
A data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/NameSpaceTool.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/ParserUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/ResumeUtil.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/RunStat.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/RunTrace.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/RuntimeUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/SharedDBConnection.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/StatCatcherUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/StringUtils.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TDieException.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TRunJobException.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TalendThread.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TalendThreadPool.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TalendThreadResult.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/TypeConvert.java
A data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/UnicodeReader.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/ESBConsumer.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/ESBEndpointInfo.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/ESBEndpointRegistry.java
M data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/TalendESBJob.java
A data-warehouse/history_etl/etl_sources/talendRoutines/src/main/java/routines/system/api/TalendESBJobFactory.java
M data-warehouse/history_etl/history_service/history_service.sh
M data-warehouse/history_etl/tos_project/code/routines/system/StringHandling_0.1.item
M data-warehouse/history_etl/tos_project/code/routines/system/StringHandling_0.1.properties
M data-warehouse/history_etl/tos_project/code/routines/system/TalendDate_0.1.item
M data-warehouse/history_etl/tos_project/code/routines/system/TalendDate_0.1.properties
M data-warehouse/history_etl/tos_project/process/AggregationToDaily_3.0.properties
M data-warehouse/history_etl/tos_project/process/AggregationToHourly_3.0.properties
M data-warehouse/history_etl/tos_project/process/ConfigurationSync_3.0.properties
M data-warehouse/history_etl/tos_project/process/DailyTimeKeepingJob_3.0.properties
M data-warehouse/history_etl/tos_project/process/DeleteTimeKeepingJob_3.0.properties
M data-warehouse/history_etl/tos_project/process/HistoryDelete_3.0.properties
M data-warehouse/history_etl/tos_project/process/HistoryETL_3.0.properties
M data-warehouse/history_etl/tos_project/process/HostConfigCheck_3.0.properties
M data-warehouse/history_etl/tos_project/process/HourlyTimeKeepingJob_3.0.properties
M data-warehouse/history_etl/tos_project/process/MinimalVersionCheck_3.0.properties
M data-warehouse/history_etl/tos_project/process/ParallelRun_3.0.properties
M data-warehouse/history_etl/tos_project/process/SampleRunJobs_3.0.properties
M data-warehouse/history_etl/tos_project/process/SampleTimeKeepingJob_3.0.properties
M data-warehouse/history_etl/tos_project/process/StatisticsSync_3.0.properties
M data-warehouse/history_etl/tos_project/talend.project
M pom.xml
88 files changed, 2,961 insertions(+), 1,104 deletions(-)
Approvals:
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4702
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic70039a5de1ad5d4edac74d81f375bf2b743184a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
11 years, 12 months
Change in ovirt-engine[master]: webadmin: Fixed remove storage host list selection
by tnisan＠redhat.com
Tal Nisan has submitted this change and it was merged.
Change subject: webadmin: Fixed remove storage host list selection
......................................................................
webadmin: Fixed remove storage host list selection
When trying to remove a storage domain, the host to be used selection
contained all hosts rather than only hosts in "up" status
Change-Id: I02d0ccec395c5510f02bcf3ed9c8c256bcce6184
Signed-off-by: Tal Nisan <tnisan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java
2 files changed, 10 insertions(+), 3 deletions(-)
Approvals:
Tal Nisan: Verified
Alexey Chub: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4701
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02d0ccec395c5510f02bcf3ed9c8c256bcce6184
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
11 years, 12 months
Change in ovirt-engine[master]: packaging: Fixed allinone plugin libvirt service handling
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Fixed allinone plugin libvirt service handling
......................................................................
packaging: Fixed allinone plugin libvirt service handling
* Fixed allinone plugin libvirt service handling.
* Removed redundant function (sleepItOff)
* Removed redundant printout
Change-Id: I4eed80dda109370b0caa78fae87997455176aa19
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/plugins/all_in_one_100.py
1 file changed, 27 insertions(+), 23 deletions(-)
Approvals:
Alex Lourie: Verified; Looks good to me, but someone else must approve
Ofer Schreiber: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4508
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4eed80dda109370b0caa78fae87997455176aa19
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
11 years, 12 months