Change in ovirt-engine[master]: core: CommandBase.getBackend()
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: CommandBase.getBackend()
......................................................................
core: CommandBase.getBackend()
Extracted a getBackend() method in CommandBase instead of calling
Backend.getInstnace() multiple times.
Also removed this method from other command classes that declared it and
used the base class' method instead.
Change-Id: I4f326301d1f7053a95743e894ef2482b2fa9c2a4
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/RemoveStorageDomainCommand.java
3 files changed, 17 insertions(+), 22 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/4687
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4f326301d1f7053a95743e894ef2482b2fa9c2a4
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: UnPowerMock ImportVmTemplateCommandTest
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: UnPowerMock ImportVmTemplateCommandTest
......................................................................
core: UnPowerMock ImportVmTemplateCommandTest
Removed PowerMock depenedency from ImportVmTemplateCommandTest.
Some minor refactoring to ImportVmTemplateCommand and
TestHelperImportVmTemplateCommand in order to encapsulate DAO/helper
access in protected methods was required.
Change-Id: Ib579a8bef98a04fb079519941b2dd3a4ab539592
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/ImportVmTemplateCommandTest.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TestHelperImportVmTemplateCommand.java
3 files changed, 40 insertions(+), 38 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/4686
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib579a8bef98a04fb079519941b2dd3a4ab539592
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: UnPowerMock FenceVdsBaseCommandTest
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: UnPowerMock FenceVdsBaseCommandTest
......................................................................
core: UnPowerMock FenceVdsBaseCommandTest
Removed PowerMock dependency from FenceVdsBaseCommandTest and replaced
it with an annonymous inheriting class that returns the needed DAOs.
Some cleanup in FenceVdsBaseCommand was required in order to allow this
technique to work.
Change-Id: I32b2c732e9ec63641e8b442ff5f86892e2689c4d
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FenceVdsBaseCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/FenceVdsBaseCommandTest.java
2 files changed, 29 insertions(+), 37 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/4685
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32b2c732e9ec63641e8b442ff5f86892e2689c4d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: Cleanup warning in UpdateVdsGroupCommandTest
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Cleanup warning in UpdateVdsGroupCommandTest
......................................................................
core: Cleanup warning in UpdateVdsGroupCommandTest
Made private methods static as detected by Eclipse IDE.
Change-Id: Ie3caae8e1761da101dddc4dc4460c8974dfd0094
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommandTest.java
1 file changed, 38 insertions(+), 34 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/4684
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie3caae8e1761da101dddc4dc4460c8974dfd0094
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: core: Cleanup TestHelperImportVmCommand
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: Cleanup TestHelperImportVmCommand
......................................................................
core: Cleanup TestHelperImportVmCommand
Removed some unneeded PowerMock leftovers.
Change-Id: Ibcbbd0f6fe05f95b19fc14cd0c477a0a5d965f1b
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/TestHelperImportVmCommand.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
Allon Mureinik: Verified
--
To view, visit http://gerrit.ovirt.org/4758
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibcbbd0f6fe05f95b19fc14cd0c477a0a5d965f1b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: engine: Fix for Wrong error on failed rebalance
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: engine: Fix for Wrong error on failed rebalance
......................................................................
engine: Fix for Wrong error on failed rebalance
https://bugzilla.redhat.com/823514
Change-Id: I03a5faaf3d055d336be680f7002040a16c9492ab
Signed-off-by: Selvasundaram <sesubram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
4 files changed, 5 insertions(+), 5 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4774
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I03a5faaf3d055d336be680f7002040a16c9492ab
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: webadmin: Gluster Volume - brick server changes
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Gluster Volume - brick server changes
......................................................................
webadmin: Gluster Volume - brick server changes
Add Bricks was using the vds_name as server name.
Now this is changed to make use of host_name while creating bricks.
Change-Id: I009d4a76e7a96245d8ca4b7b2cd5ae3dc73e1ad6
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/gluster/VolumeBrickModel.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/gluster/AddBrickPopupView.java
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4729
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I009d4a76e7a96245d8ca4b7b2cd5ae3dc73e1ad6
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: webadmin: edit & remove default quota
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: edit & remove default quota
......................................................................
webadmin: edit & remove default quota
Disallow editing and removing default quota in disable quota mode.
Change-Id: Ie4606e20517a540efce7b54167d93fcc3bbcb2ad
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaListModel.java
1 file changed, 9 insertions(+), 1 deletion(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4624
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie4606e20517a540efce7b54167d93fcc3bbcb2ad
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: webadmin: Consolidate default confirm dialog handling
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: Consolidate default confirm dialog handling
......................................................................
webadmin: Consolidate default confirm dialog handling
Before this patch, model providers (TabModelProvider.getConfirmModelPopup)
handled confirm dialogs differently than popup presenter widgets
(AbstractModelBoundPopupPresenterWidget.getConfirmModelPopup):
- TabModelProvider used default confirm dialog implementation
(DefaultConfirmationPopupPresenterWidget) as the fallback
- AbstractModelBoundPopupPresenterWidget had no fallback, and
the concrete subclass had to override getConfirmModelPopup
in order to use DefaultConfirmationPopupPresenterWidget
After this patch, default confirm dialog handling is consolidated:
- ModelBoundPopupHandler can now be instructed to use default
confirm dialog implementation via setDefaultConfirmPopupProvider
- TabModelProvider calls setDefaultConfirmPopupProvider to ensure
same behavior as before
- AbstractModelBoundPopupPresenterWidget has new constructor that
allows it to configure default confirm dialog handling via
setDefaultConfirmPopupProvider
- GuidePopupPresenterWidget no longer needs to override
getConfirmModelPopup just to use default confirm dialog impl.
(all it needs to do is to use overloaded constructor for this
purpose)
In addition, following classes were cleaned up a bit:
- VolumePopupPresenterWidget
- HostInstallPopupPresenterWidget
- ImportTemplatePopupPresenterWidget
- ImportVmPopupPresenterWidget
Change-Id: I4eabc54e661cf68ba62347e0fc2be6972122a18e
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/AbstractModelBoundPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupHandler.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/TabModelProvider.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/gluster/VolumePopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/guide/GuidePopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/host/HostInstallPopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/storage/backup/ImportTemplatePopupPresenterWidget.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/popup/storage/backup/ImportVmPopupPresenterWidget.java
8 files changed, 37 insertions(+), 43 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4632
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4eabc54e661cf68ba62347e0fc2be6972122a18e
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <vszocs(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 11 months
Change in ovirt-engine[master]: webadmin: oVirt Modes - Cluster, Volume changes
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: oVirt Modes - Cluster, Volume changes
......................................................................
webadmin: oVirt Modes - Cluster, Volume changes
1.Enable Virt Service, Enable Gluster Service checkboxes will be shown
depends on the mode. None of the checkboxes will be shown if the application
is running in XxxOnly mode.
2.VM's node in System Tree will be shown only if the cluster has
virt service enabled.
3. Volumes Tab will be avaiable in the System tree context also.
Change-Id: Ib2bf6d7b007be0e25d7cd73022a8df331f7aeacb
Signed-off-by: Kanagaraj M <kmayilsa(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/ApplicationModeHelper.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
4 files changed, 23 insertions(+), 8 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4698
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib2bf6d7b007be0e25d7cd73022a8df331f7aeacb
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
11 years, 11 months