Change in ovirt-engine[master]: core: ApplicationException cleanup
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: ApplicationException cleanup
......................................................................
core: ApplicationException cleanup
- removed outcommented code
- added serialVersionUID
Change-Id: I5d5c77d2ebff6a4952f5b3049f761bc2cc632c7f
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/ApplicationException.java
1 file changed, 2 insertions(+), 18 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d5c77d2ebff6a4952f5b3049f761bc2cc632c7f
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years
Change in ovirt-engine[master]: core: [rmd] remove Refobject from MacPoolManager
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: [rmd] remove Refobject from MacPoolManager
......................................................................
core: [rmd] remove Refobject from MacPoolManager
Refobject usage removed, because it is deprecated
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
Change-Id: I3056e7fb33f4a2fafe223b58d985ef65c855acc8
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MacPoolManager.java
4 files changed, 16 insertions(+), 28 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4236
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3056e7fb33f4a2fafe223b58d985ef65c855acc8
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years
Change in ovirt-engine[master]: core: [rmd] DoubleCompat RefObject removal
by lhornyak＠redhat.com
Laszlo Hornyak has submitted this change and it was merged.
Change subject: core: [rmd] DoubleCompat RefObject removal
......................................................................
core: [rmd] DoubleCompat RefObject removal
removed deprecated RefObject usage
Change-Id: I7068aee17b1b763479b4381b7806809e13117247
Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com>
---
M backend/manager/modules/compat/src/main/java/org/ovirt/engine/core/compat/DoubleCompat.java
M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/pm/VdsFencingOptions.java
3 files changed, 12 insertions(+), 26 deletions(-)
Approvals:
Laszlo Hornyak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4235
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7068aee17b1b763479b4381b7806809e13117247
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years
Change in ovirt-engine[master]: webadmin: New Template dialog: remove OK when dialog disable...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: New Template dialog: remove OK when dialog disabled (#589518)
......................................................................
webadmin: New Template dialog: remove OK when dialog disabled (#589518)
https://bugzilla.redhat.com/589518
virtual machies main tab -> select a machine -> click "Make Template"
If there is an error which prevents the Template to be created, the
whole dialog gets disabled, however, the OK button is still present.
The logic of disabling of the button is in
NewTemplateVmModelBehavior.DisableNewTemplateModel() which missed
the removing of the OK button.
Added removing of the OK button to this method.
Change-Id: Ibadf4777ef6c4903e81920dbf62c67d336a5e025
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
1 file changed, 5 insertions(+), 4 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibadf4777ef6c4903e81920dbf62c67d336a5e025
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years
Change in ovirt-engine[master]: webadmin: Edit Pool shows different template (#820231)
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: webadmin: Edit Pool shows different template (#820231)
......................................................................
webadmin: Edit Pool shows different template (#820231)
https://bugzilla.redhat.com/820231
When creating a pool from a template, than edit pool
shows a different template than the one from which it has been
created.
The problem was, that the edit pool dialog used the same behavior
class for both edit and new pool (the NewPoolModelBehavior),
and this one selects always the first pool.
The fix was to create a separate class ExistingPoolModelBehavior
which initializes the template correctly.
Change-Id: Iea1270499ebd3b1c6f7ee93d62cbc7a8167fb7c1
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
6 files changed, 388 insertions(+), 375 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4423
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea1270499ebd3b1c6f7ee93d62cbc7a8167fb7c1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years
Change in ovirt-engine-cli[master]: cli: release 3.1.0.1-1alpha
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: release 3.1.0.1-1alpha
......................................................................
cli: release 3.1.0.1-1alpha
Change-Id: I6ed2864ed1e5315ccf9eb93832446ad429e89c2b
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M Makefile
M ovirt-engine-cli.spec.in
M setup.py
3 files changed, 11 insertions(+), 5 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ofer Schreiber: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4470
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6ed2864ed1e5315ccf9eb93832446ad429e89c2b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years
Change in ovirt-engine[master]: userportal: Add progress animation to User Portal dialogs (#...
by vszocs＠redhat.com
Vojtech Szocs has submitted this change and it was merged.
Change subject: userportal: Add progress animation to User Portal dialogs (#745006)
......................................................................
userportal: Add progress animation to User Portal dialogs (#745006)
https://bugzilla.redhat.com/745006
UserPortalListModel completly ignored the StartProgress()
and StopProgress(). Added calling of this methods.
This patch also contains the following refactoring:
- UserPortalListModel did not used the standard
setConfirmWindow and setWindow properties to handle popup windows
and confirm windows. This has been changed so it uses the
standard properties.
This patch also contains the following fixes:
- The add permission did not work at all on Templates side tab,
because it used the PermissionListModel instead of
UserPortalPermissionListModel
- The change CD did not work because the UserPortalListModel.ChangeCD()
expected List<String> in callback of
GetAllIsoImagesListByStoragePoolId instead of VdcQueryReturnValue
Change-Id: Icd627f4c6fe190b2c3cc0e4f6ca1ddacaa1a8283
Signed-off-by: Vojtech Szocs <vszocs(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/ModelBoundPopupHandler.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/PermissionListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateInterfaceListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalTemplateListModel.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/extended/template/SubTabExtendedTemplatePermissionsPresenter.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/template/SubTabExtendedTemplatePermissionsView.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/template/TemplatePermissionListModelProvider.java
M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/model/vm/UserPortalListProvider.java
10 files changed, 217 insertions(+), 268 deletions(-)
Approvals:
Vojtech Szocs: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4391
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd627f4c6fe190b2c3cc0e4f6ca1ddacaa1a8283
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years
Change in ovirt-engine-sdk[master]: sdk: release 3.1.0.1-1alpha
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: sdk: release 3.1.0.1-1alpha
......................................................................
sdk: release 3.1.0.1-1alpha
Change-Id: I8b5042453ab128bab7454dd5bebf635fd281b494
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M Makefile
M ovirt-engine-sdk.spec.in
M setup.py
3 files changed, 7 insertions(+), 3 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
Ofer Schreiber: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/4468
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8b5042453ab128bab7454dd5bebf635fd281b494
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine-sdk
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years
Change in ovirt-engine[master]: engine: Gluster volume options info query
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Gluster volume options info query
......................................................................
engine: Gluster volume options info query
Including following related to the command for "Gluster volume options Info"
- New VDS Query
- New BLL command
Change-Id: I9c9fc6b94dc54c20bef09fe731736c0c2c8401bb
Signed-off-by: Dhandapani <dgopal(a)redhat.com>
---
A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQuery.java
A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GetGlusterVolumeOptionsInfoQueryTest.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java
A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/gluster/GlusterParameters.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GetGlusterVolumeOptionsInfoVDSCommand.java
A backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/irsbroker/GlusterVolumeOptionsInfoReturnForXmlRpc.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java
M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java
10 files changed, 253 insertions(+), 0 deletions(-)
Approvals:
Omer Frenkel: Looks good to me, approved
Dhandapani Gopal: Verified
--
To view, visit http://gerrit.ovirt.org/4112
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9c9fc6b94dc54c20bef09fe731736c0c2c8401bb
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com>
Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Kanagaraj M <kmayilsa(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years
Change in ovirt-engine-cli[master]: cli: add basic scripting capabilities
by mpastern＠redhat.com
Michael Pasternak has submitted this change and it was merged.
Change subject: cli: add basic scripting capabilities
......................................................................
cli: add basic scripting capabilities
this patch adds basic scripting capabilities,
added new option -f/--file that accept path
to the file with ovirt-shell commands,
also added new command called 'file'
HELP
===
[oVirt shell (connected)]# help file
== Usage ==
file FILE
== Description ==
This command reads commands from the FILE instead of stdin.
== Examples ==
file /home/test/script
EXAMPLE
======
[mpastern@lp /]# ovirt-shell --connec -l ... -u ... -p ... -f /home/mpastern/script
or
[oVirt shell (connected)]# file /home/mpastern/script
SCRIPT
======
less /home/mpastern/script
-----_____----------------
list vms
list clusters
list datacenters
...
Change-Id: I08b7fd6d072e237e1dc95ed6f41fb57387c72dd5
Signed-off-by: Michael Pasternak <mpastern(a)redhat.com>
---
M src/ovirtcli/options.py
M src/ovirtcli/shell/engineshell.py
A src/ovirtcli/shell/filecmdshell.py
3 files changed, 145 insertions(+), 11 deletions(-)
Approvals:
Michael Pasternak: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4426
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I08b7fd6d072e237e1dc95ed6f41fb57387c72dd5
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
12 years