June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: added tests to updateVmCommand
by ofrenkel＠redhat.com 24 Jun '12

24 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: added tests to updateVmCommand ...................................................................... core: added tests to updateVmCommand Added some test to UpdateVmCommnad canDoAction as preperation for refactoring it. some minor refactoring was needed just for the tests. Change-Id: Id37898c28a22ccf19342b8b1a2e40a6b9186bb50 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmManagementCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/UpdateVmCommandTest.java 5 files changed, 210 insertions(+), 28 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5442 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id37898c28a22ccf19342b8b1a2e40a6b9186bb50 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Data Integrity Exception (null in column "command_id")...
by mkublin＠redhat.com 24 Jun '12

24 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: Data Integrity Exception (null in column "command_id") (#830785) ...................................................................... core: Data Integrity Exception (null in column "command_id") (#830785) https://bugzilla.redhat.com/830785 The following error can occurred when engine was restarted before persist task to DB. At that case all information about a tasks is retrieved from spm host, we also can not retrieve a command id, because of no information was saved to db, so in order to continue a new command_id will be created instead of setting null Change-Id: I453ac11cf920b8e0f2f7b2b80ede483f79e2fe51 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskFactory.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AsyncTaskManager.java 2 files changed, 3 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5641 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I453ac11cf920b8e0f2f7b2b80ede483f79e2fe51 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: using SASL on LDAP queries in utils
by oourfali＠redhat.com 24 Jun '12

24 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: using SASL on LDAP queries in utils ...................................................................... core: using SASL on LDAP queries in utils This patch uses javax.security.sasl.qop configuration on the LDAP context environment in the utilities. Change-Id: Id2324d2ae375f4a6b0ce8c3a37782d2a4b58d845 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5638 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id2324d2ae375f4a6b0ce8c3a37782d2a4b58d845 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: improving log errors in manage domains utility
by oourfali＠redhat.com 24 Jun '12

24 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: improving log errors in manage domains utility ...................................................................... core: improving log errors in manage domains utility This patch adds prints to the log in the manage domains utility Change-Id: If0ee5a742fae570c3720778b0d179f5c5470585b Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosConfigCheck.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5620 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0ee5a742fae570c3720778b0d179f5c5470585b Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "core: Option with empty name and value ..."
by mkublin＠redhat.com 24 Jun '12

24 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: Revert "core: Option with empty name and value ..." ...................................................................... Revert "core: Option with empty name and value ..." cause regressions, cannot attach SD This reverts commit 04618248977aa3f649ef938e639ea59e532cfd72. Change-Id: Ic7a15ec4a874ac294490820b77c6411f8acf89bd Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java 1 file changed, 0 insertions(+), 6 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/5634 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic7a15ec4a874ac294490820b77c6411f8acf89bd Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Change icon for pending approval hosts (#809350)
by achub＠redhat.com 24 Jun '12

24 Jun '12

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Change icon for pending approval hosts (#809350) ...................................................................... webadmin: Change icon for pending approval hosts (#809350) Change-Id: I59d0728a9484fe14131f94b391e1e58149973a3f Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostStatusCell.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5632 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59d0728a9484fe14131f94b391e1e58149973a3f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: domains that were deactivated due to storage issues wi...
by mkublin＠redhat.com 24 Jun '12

24 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: domains that were deactivated due to storage issues will not be started by auto recovery(#833817) ...................................................................... core: domains that were deactivated due to storage issues will not be started by auto recovery(#833817) https://bugzilla.redhat.com/833817 The follwoing bug was caused because of we don't distingvish between regular deactivate of storage domain and decativate it during failover. The following patch will add that different Change-Id: I2f851110c800a075adf8f44db5a046cf67f2d84f Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DeactivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/HandleFailedStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ReconstructMasterDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ReconstructMasterParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainPoolParametersBase.java 5 files changed, 20 insertions(+), 24 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5629 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2f851110c800a075adf8f44db5a046cf67f2d84f Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: Revert "webadmin: Edit storage - incorrect number of LUN pat...
by derez＠redhat.com 24 Jun '12

24 Jun '12

Daniel Erez has submitted this change and it was merged. Change subject: Revert "webadmin: Edit storage - incorrect number of LUN paths" ...................................................................... Revert "webadmin: Edit storage - incorrect number of LUN paths" Will be fixed with a different apprach - number of paths should be retrieved by crossing luns data from db and getDeviceList. This reverts commit c8bc4415d80e0f74efce7e9de8b4c6f1f41a5718 Change-Id: Id200e4dfe26c4a6658eaa24a7214473ea6f3bfbc Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/SanStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 2 files changed, 14 insertions(+), 18 deletions(-) Approvals: Daniel Erez: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5630 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id200e4dfe26c4a6658eaa24a7214473ea6f3bfbc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: NPE during disk removal
by mkublin＠redhat.com 24 Jun '12

24 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: NPE during disk removal ...................................................................... core: NPE during disk removal The following problem can occurred during disk removal, a failure can cause for task getting stuck, the following fix will solve a problem of stucking task. Even failure will ocurred the task will be deleted at the end. Change-Id: Ia7d16319b8d9f7e5bed56d9bd1b08d9ccbed1b14 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java 1 file changed, 5 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5621 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia7d16319b8d9f7e5bed56d9bd1b08d9ccbed1b14 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix Host Memory Statistics Calculations
by oliel＠redhat.com 24 Jun '12

24 Jun '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Fix Host Memory Statistics Calculations ...................................................................... restapi: Fix Host Memory Statistics Calculations Change-Id: If598d74ae273b32ed12a477a9ad3b7cf6c40bc1e Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/HostStatisticalQuery.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java 2 files changed, 6 insertions(+), 6 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5534 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If598d74ae273b32ed12a477a9ad3b7cf6c40bc1e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0