June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: minor cleanup on RegisterVdsQuery
by yzaslavs＠redhat.com 24 Jun '12

24 Jun '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: minor cleanup on RegisterVdsQuery ...................................................................... core: minor cleanup on RegisterVdsQuery Change-Id: Icb7242c686a3b7a725944a5929cf475850b6f8c3 Signed-off-by: Liron Aravot <laravot(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RegisterVdsQuery.java 1 file changed, 3 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5352 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb7242c686a3b7a725944a5929cf475850b6f8c3 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added template & pool cleanups to force remove SD (#81...
by tnisan＠redhat.com 21 Jun '12

21 Jun '12

Tal Nisan has submitted this change and it was merged. Change subject: core: Added template & pool cleanups to force remove SD (#818091) ...................................................................... core: Added template & pool cleanups to force remove SD (#818091) https://bugzilla.redhat.com/818091 When force removing a storage domain, vms from pool and templates were not removed, this was fixed. Change-Id: I4b4035a593dc208fa485c5c5ea970c949cb1d6f6 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/dbscripts/storages_sp.sql M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/StorageDomainDAOTest.java 2 files changed, 42 insertions(+), 8 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5407 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4b4035a593dc208fa485c5c5ea970c949cb1d6f6 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Remove reinitialize Data Center warning message
by tnisan＠redhat.com 21 Jun '12

21 Jun '12

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Remove reinitialize Data Center warning message ...................................................................... webadmin: Remove reinitialize Data Center warning message Remove the warning message: "This operation is destructive and unrecoverable!" when trying to reinitialize a Data Center, this message is not needed since it's not correct, the operation is not destructive Change-Id: I28a70436b70db5606ac5057e11a029dd8d45a21d Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/RecoveryStorageConfirmationPopupView.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/datacenter/RecoveryStorageConfirmationPopupView.ui.xml 3 files changed, 0 insertions(+), 16 deletions(-) Approvals: Tal Nisan: Verified Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5593 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I28a70436b70db5606ac5057e11a029dd8d45a21d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: VM Custrom Properties are not passing to vdsm
by shavivi＠redhat.com 21 Jun '12

21 Jun '12

Shahar Havivi has submitted this change and it was merged. Change subject: VM Custrom Properties are not passing to vdsm ...................................................................... VM Custrom Properties are not passing to vdsm Change-Id: I694da6a0ee007f6a043acbee11cf08d690e7f1a0 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5591 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I694da6a0ee007f6a043acbee11cf08d690e7f1a0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[engine_3.1]: core: fix locks in runVm
by ofrenkel＠redhat.com 21 Jun '12

21 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: core: fix locks in runVm ...................................................................... core: fix locks in runVm locks prevented create-snapshot running during run-vm which caused stateless and pool-vms not to run. solution is to send the lock from run-vm to create-snapshot, so it wouldn't try to acquire it again. Change-Id: I5aa7d184955f4fb7103f5c95023efa4a3288b753 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> (cherry picked from commit de23ac282353163d82ee0fe8e543b5263d832f64) --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java 3 files changed, 23 insertions(+), 12 deletions(-) Approvals: Ofer Schreiber: Looks good to me, but someone else must approve Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5589 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aa7d184955f4fb7103f5c95023efa4a3288b753 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: engine_3.1 Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Setup networks- usages (#823881)
by gchaplik＠redhat.com 21 Jun '12

21 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: Setup networks- usages (#823881) ...................................................................... webadmin: Setup networks- usages (#823881) https://bugzilla.redhat.com/823881 The network has three type of usages- vm network, display network, managment network. The usages symbols should be visible if the usage is true and unvisible if false. Change-Id: I65d041f8a28ef41ef0c6cc0441cd6d9d3d670109 Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostSetupNetworksPopupView.ui.xml M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanelsStyle.java A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/empty.png 5 files changed, 14 insertions(+), 20 deletions(-) Approvals: Alona Kaplan: Verified Gilad Chaplik: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5587 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I65d041f8a28ef41ef0c6cc0441cd6d9d3d670109 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Fix notifier classpath (#828801)
by masayag＠redhat.com 21 Jun '12

21 Jun '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix notifier classpath (#828801) ...................................................................... core: Fix notifier classpath (#828801) https://bugzilla.redhat.com/828801 The classpath of the nofification service needs to be fixed in order to work with the locations of the jar files in Fedora 17. Change-Id: I7da5593c2b3b6d4b93110e2ff920d1d70ad36a19 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M backend/manager/tools/engine-notifier/engine-notifier-resources/src/main/resources/notifier.sh 1 file changed, 17 insertions(+), 33 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5111 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7da5593c2b3b6d4b93110e2ff920d1d70ad36a19 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix locks in runVm
by mkublin＠redhat.com 21 Jun '12

21 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core: fix locks in runVm ...................................................................... core: fix locks in runVm locks prevented create-snapshot running during run-vm which caused stateless and pool-vms not to run. solution is to send the lock from run-vm to create-snapshot, so it wouldn't try to acquire it again. Change-Id: I5aa7d184955f4fb7103f5c95023efa4a3288b753 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/context/CommandContext.java 3 files changed, 23 insertions(+), 12 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5588 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5aa7d184955f4fb7103f5c95023efa4a3288b753 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: VM Custrom Properties are not passing to vdsm
by shavivi＠redhat.com 21 Jun '12

21 Jun '12

Shahar Havivi has submitted this change and it was merged. Change subject: VM Custrom Properties are not passing to vdsm ...................................................................... VM Custrom Properties are not passing to vdsm Change-Id: I694da6a0ee007f6a043acbee11cf08d690e7f1a0 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VmInfoBuilder.java 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5583 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I694da6a0ee007f6a043acbee11cf08d690e7f1a0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Option with empty name and value ...
by emesika＠redhat.com 21 Jun '12

21 Jun '12

Eli Mesika has submitted this change and it was merged. Change subject: core: Option with empty name and value ... ...................................................................... core: Option with empty name and value ... Option with empty name and value in the request's xml to rest-api should not be allowed. The problem is not with the PM options, this is working without a problem. There is a leading blank in the UUID of the DC in the request that caused the exception. Adding a check for DC ID validity in canDoAction of ConnectStorageToVdsCommand command. Change-Id: I026932f5fe78592ae81e90dea5e781a34f8308ae Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5490 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I026932f5fe78592ae81e90dea5e781a34f8308ae Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0