June 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: lock dest image in import command

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: core: lock dest image in import command ...................................................................... core: lock dest image in import command currently in import VM/Template, the image that is being locked is the source one add another property that indicates whether to lock the destination image. Change-Id: I4ea1e0b50eaa8075d118b49eb2074e61bd874aa4 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/BaseImagesCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/ImagesActionsParametersBase.java 4 files changed, 16 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5647 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4ea1e0b50eaa8075d118b49eb2074e61bd874aa4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: 'Import More Than Once' clean-up

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: core: 'Import More Than Once' clean-up ...................................................................... core: 'Import More Than Once' clean-up because of an override to getVm() in import command class, there is no need for special care, in case of 'import more than once'. that's why I'm removing the reference to it in EndImportCommand() Change-Id: I89a2dc1c3e144b8cd7c440298736e2dd362fbe5c Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 1 insertion(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5646 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I89a2dc1c3e144b8cd7c440298736e2dd362fbe5c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: adjust event time column width

by gchaplik＠redhat.com

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: adjust event time column width ...................................................................... webadmin: adjust event time column width * in event subtab foreach system entity * in events main grid (basic view) Change-Id: I6e928762b230f5f75575a101d77503f129e1ddcb Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/events/EventListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabEventView.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5645 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e928762b230f5f75575a101d77503f129e1ddcb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: release 3.1.0.3-1

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.1.0.3-1 ...................................................................... cli: release 3.1.0.3-1 Change-Id: I58b6da40c573afe61b24847bbcf4c301e030abdf Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 12 insertions(+), 5 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5663 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I58b6da40c573afe61b24847bbcf4c301e030abdf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: do not verify type existence in show

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: do not verify type existence in show ...................................................................... cli: do not verify type existence in show Change-Id: I6fce904317d5899ddbb215dfde04d629cb6a0d9d Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/show.py 1 file changed, 0 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5655 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6fce904317d5899ddbb215dfde04d629cb6a0d9d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: centralise cli messages

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: centralise cli messages ...................................................................... cli: centralise cli messages Change-Id: Ibc0feb0acc826d2d7482496c3aaf1bebadab3ceb Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/command/command.py M src/cli/error.py A src/cli/messages.py M src/ovirtcli/command/action.py M src/ovirtcli/command/command.py M src/ovirtcli/command/console.py M src/ovirtcli/command/create.py M src/ovirtcli/command/delete.py M src/ovirtcli/command/disconnect.py M src/ovirtcli/command/ping.py M src/ovirtcli/command/show.py M src/ovirtcli/command/status.py M src/ovirtcli/command/update.py M src/ovirtcli/platform/posix/spice.py M src/ovirtcli/platform/posix/vnc.py M src/ovirtcli/shell/cmdshell.py M src/ovirtcli/shell/connectcmdshell.py M src/ovirtcli/shell/createcmdshell.py M src/ovirtcli/shell/engineshell.py M src/ovirtcli/shell/filecmdshell.py M src/ovirtcli/shell/listcmdshell.py M src/ovirtcli/shell/showcmdshell.py 22 files changed, 248 insertions(+), 149 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved Ori Liel: Looks good to me, but someone else must approve -- To view, visit http://gerrit.ovirt.org/5648 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibc0feb0acc826d2d7482496c3aaf1bebadab3ceb Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: New query 'GetAllVms' to get all vms with filtering su...

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: core: New query 'GetAllVms' to get all vms with filtering support (#783087) ...................................................................... core: New query 'GetAllVms' to get all vms with filtering support (#783087) https://bugzilla.redhat.com/783087 Introducing a new query 'getAllVms', used to retrieve all VMs. This query has permission filtering support, used to retrieve only the vms that the user is allowed to read. Change-Id: I492773ee76eae88b999afc8dd2032934e31e9183 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/dbscripts/vms_sp.sql A backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllVmsQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/VdcQueryType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAO.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dao/VmDAODbFacadeImpl.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/VmDAOTest.java 6 files changed, 76 insertions(+), 4 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5564 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I492773ee76eae88b999afc8dd2032934e31e9183 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: improving error messages in adbroker

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: core: improving error messages in adbroker ...................................................................... core: improving error messages in adbroker This patch improves the error messages in the adbroker project, in case of authentication errors: 1. Printing the message and not the full callstack, for readability. The full call stack is printed only in debug log mode. 2. In case of "client not found in kerberos database" error, we return a proper error to the user (instead of the "invalid credentials" error we returned so far). Change-Id: I345205621e55e99d8cbce5720f6ed961cfa07c71 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcher.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/AuthenticationResult.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/KerberosReturnCodeParser.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 20 insertions(+), 4 deletions(-) Approvals: Yair Zaslavsky: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/5657 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I345205621e55e99d8cbce5720f6ed961cfa07c71 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: add permission for changing custom properties

by ofrenkel＠redhat.com

Omer Frenkel has submitted this change and it was merged. Change subject: core: add permission for changing custom properties ...................................................................... core: add permission for changing custom properties in order to change custom properties user need to have explicit permission permission check added to addVm, updateVm, importVm, runVm permission added to admin roles that have all vm actions allowed: super user, dc admin, cluster admin Change-Id: If7409927233901439e33ec31c1091dd5948953e7 Signed-off-by: Omer Frenkel <ofrenkel(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_01_1250_add_custom_props_action_group.sql M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromScratchCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmFromSnapshotCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/ActionGroup.java M backend/manager/modules/restapi/interface/definition/src/main/java/org/ovirt/engine/api/model/PermitType.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermitMapper.java 10 files changed, 94 insertions(+), 2 deletions(-) Approvals: Omer Frenkel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5492 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If7409927233901439e33ec31c1091dd5948953e7 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 10 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fixing task monitoring - run stateless

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: Fixing task monitoring - run stateless ...................................................................... core: Fixing task monitoring - run stateless The following patch fixes task monitoring for run stateless command. A .It creates a step under EXECUTING to be the parent step of all create snapshots. B. It creates a step for RUNNING the stateless VM, after the snapshots creation succeeded. Change-Id: Ic51b5e60e526a84873014dbc2179ddfb2de1d834 Acked-By: Signed-off-by: Yair Zaslavsky <yzaslavs(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RunVmCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/job/StepEnum.java M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties 3 files changed, 50 insertions(+), 2 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5597 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic51b5e60e526a84873014dbc2179ddfb2de1d834 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 10 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits June 2012