Change in ovirt-engine[master]: engine: expose compatibility version/qemu machine type via e...
by yzaslavs@redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: expose compatibility version/qemu machine type via engine-config tool
......................................................................
engine: expose compatibility version/qemu machine type via engine-config tool
This patch is added to support http://lists.ovirt.org/pipermail/engine-devel/2012-April/001216.html
Change-Id: Iafb643aabf531be763f2ed39a67c7f6016879c82
Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
---
M backend/manager/tools/engine-config/src/main/resources/engine-config.properties
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/3893
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iafb643aabf531be763f2ed39a67c7f6016879c82
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Ryan Harper <ryanh(a)us.ibm.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: Close tags in OVF template writer (#832106)
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: Close tags in OVF template writer (#832106)
......................................................................
core: Close tags in OVF template writer (#832106)
https://bugzilla.redhat.com/832106
One of the tags in the template writer is not closed correctly.
The StAX implementation that we used in the past automatically
closed tags, but the one in OpenJDK 7 doesn't, so we need to do it
explicitly.
Change-Id: I8d0e4ee41236fae98ccc1cccb346121260bcd75d
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfTemplateWriter.java
1 file changed, 2 insertions(+), 0 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5506
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8d0e4ee41236fae98ccc1cccb346121260bcd75d
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: core: remove uneeded logging from StorageHelperDirector
by mkublin@redhat.com
Michael Kublin has submitted this change and it was merged.
Change subject: core: remove uneeded logging from StorageHelperDirector
......................................................................
core: remove uneeded logging from StorageHelperDirector
some of the StorageType enum values doesn't represent a true helper
class, so they shouldn't be logged in case of ClassNotFoundException
Change-Id: Icd95ba8f9c3c3ad80b8cfda70fd62d2bdf4b712e
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperDirector.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/StorageType.java
2 files changed, 37 insertions(+), 28 deletions(-)
Approvals:
Michael Kublin: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5451
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icd95ba8f9c3c3ad80b8cfda70fd62d2bdf4b712e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: adding network already in use error to appErr
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: adding network already in use error to appErr
......................................................................
webadmin: adding network already in use error to appErr
add NETWORK_INTERFACE_NAME_ALREADY_IN_USE to
AppError in order to see the value of this key and
not the message name.
Change-Id: I88a8846667e449d94f1bcf7651a7679f738e8da8
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5493
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I88a8846667e449d94f1bcf7651a7679f738e8da8
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: clean up- unused class
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: clean up- unused class
......................................................................
webadmin: clean up- unused class
UserVmListModel.java
Change-Id: I494b9eaa9991ced3b5dfddce8798fb688068d6ff
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/users/UserVmListModel.java
1 file changed, 0 insertions(+), 309 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5496
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I494b9eaa9991ced3b5dfddce8798fb688068d6ff
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: import as duplicate is compulsory
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: import as duplicate is compulsory
......................................................................
webadmin: import as duplicate is compulsory
import more than once: clone, clone only existing checkboxes
should always be enabled.
Change-Id: I5bda065bf3ac984138022c1b8f7a435fbe9405d5
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/ImportTemplateModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ImportVmModel.java
2 files changed, 0 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5495
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I5bda065bf3ac984138022c1b8f7a435fbe9405d5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: import - sort disks by alias
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: import - sort disks by alias
......................................................................
webadmin: import - sort disks by alias
import vm & template
Change-Id: I60de9a0102a7319952fa5f2ae8e7c7d81b36288b
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateImportDiskListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmImportDiskListModel.java
2 files changed, 11 insertions(+), 4 deletions(-)
Approvals:
Daniel Erez: Looks good to me, approved
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5494
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I60de9a0102a7319952fa5f2ae8e7c7d81b36288b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: disable rest of fields in edit pool
by gchaplik@redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: disable rest of fields in edit pool
......................................................................
webadmin: disable rest of fields in edit pool
* custom property sheet supports HasEnabled
* invoke call for disabling only when the popup finish to load
Change-Id: I516c2f07efa9570ee467c236b5354c4594d68267
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueLineWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/form/key_value/KeyValueWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/pool/PoolEditPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
4 files changed, 63 insertions(+), 4 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5458
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I516c2f07efa9570ee467c236b5354c4594d68267
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: webadmin: setup networks freezes on engine error
by derez@redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: setup networks freezes on engine error
......................................................................
webadmin: setup networks freezes on engine error
VdcActionType___SetupNetworks was missing in the
enums files
Change-Id: Iee89adac8fc81fd83474d596273c66e216a0ba5a
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java
M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties
2 files changed, 3 insertions(+), 0 deletions(-)
Approvals:
Alona Kaplan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5491
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iee89adac8fc81fd83474d596273c66e216a0ba5a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
12 years, 7 months
Change in ovirt-engine[master]: packaging: Updating flow and error messages in cleanup (#825...
by oschreib@redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: packaging: Updating flow and error messages in cleanup (#825998)
......................................................................
packaging: Updating flow and error messages in cleanup (#825998)
https://bugzilla.redhat.com/show_bug.cgi?id=825998
* Updated flows and various error messages in engine-cleanup.
Change-Id: I47480fc85cb627ad38e26f9e5052e2067095d1f2
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/engine-cleanup.py
1 file changed, 18 insertions(+), 2 deletions(-)
Approvals:
Alex Lourie: Verified; Looks good to me, but someone else must approve
Ofer Schreiber: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5031
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I47480fc85cb627ad38e26f9e5052e2067095d1f2
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 7 months