June 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: webadmin: Fix error notice when adding iSCSI storage <10GB (...

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: webadmin: Fix error notice when adding iSCSI storage <10GB (#819330) ...................................................................... webadmin: Fix error notice when adding iSCSI storage <10GB (#819330) https://bugzilla.redhat.com/819330 When new Storage Domain creation failed, failure status was not checked and flow continued to try and attach the SD to a pool which failed and returned a storage domain not found error instead of the creation failure. SD creation status is now checked before proceeding. Change-Id: If9c0e5aa18d6faf3019569f1b1dae29709406af1 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 12 insertions(+), 9 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved Daniel Erez: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5058 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If9c0e5aa18d6faf3019569f1b1dae29709406af1 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: printing kerberos exception details to log

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: printing kerberos exception details to log ...................................................................... core: printing kerberos exception details to log This patch prints the kerberos exception details to the log in case there is an AuthenticationException when trying to retrieve the user guid, by authenticating to the kerberos server. Change-Id: Iea01bb084c8dac75e2d1ecdda66d025f24eeaa70 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/JndiAction.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5185 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iea01bb084c8dac75e2d1ecdda66d025f24eeaa70 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: restoring configuration comments

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: restoring configuration comments ...................................................................... core: restoring configuration comments This patch restores comments that were originally in fill-config.sql at the time it was deprecated. In the move to config.sql only code lines were taken and comments were removed. Change-Id: I8f8923d6365d62defe659b777219489cd46dd92b Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql 1 file changed, 52 insertions(+), 6 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8f8923d6365d62defe659b777219489cd46dd92b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: add missing severities to audit log director

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: add missing severities to audit log director ...................................................................... core: add missing severities to audit log director Adding missing severities to AuditLogDirector that caused " XXXXX not have severity. Assumed Normal" messages in log. Change-Id: I0107aee38aaee86468a2d868377d940e99cd4dfd Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0107aee38aaee86468a2d868377d940e99cd4dfd Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core:remove single unknown tasks from the task(817817)

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core:remove single unknown tasks from the task(817817) ...................................................................... core:remove single unknown tasks from the task(817817) https://bugzilla.redhat.com/show_bug.cgi?id=817817 Modifying relevant SP handling Job/Step to filter Job/Step with unknown status. Change-Id: I23d0b2dd1f2d07393c49e705a657cd97c9106c7e Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/dbscripts/job_sp.sql 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4428 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I23d0b2dd1f2d07393c49e705a657cd97c9106c7e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Clean storage server connections on storage removal

by tnisan＠redhat.com

Tal Nisan has submitted this change and it was merged. Change subject: core: Clean storage server connections on storage removal ...................................................................... core: Clean storage server connections on storage removal Clean up the storage server connections from the database upon removal of storage from types NFS/Local/Posix Change-Id: Ife3fceba9157b6e1ef127fe6df20f073baf01a11 Signed-off-by: Tal Nisan <tnisan(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java 1 file changed, 12 insertions(+), 0 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife3fceba9157b6e1ef127fe6df20f073baf01a11 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core: adding validation for password to not contain commas (...

by yzaslavs＠redhat.com

Yair Zaslavsky has submitted this change and it was merged. Change subject: core: adding validation for password to not contain commas (#803418) ...................................................................... core: adding validation for password to not contain commas (#803418) https://bugzilla.redhat.com/803418 Passwords containing commas cause failures in engine-manage-domains utlilty. This patch validates that the password doesn't contain illegal characters, and print an error message accordingly Change-Id: Ifbabf0cfc98510c318011acc33d73a2266f1ca43 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsResultEnum.java 2 files changed, 10 insertions(+), 0 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5182 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifbabf0cfc98510c318011acc33d73a2266f1ca43 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: core : we can destroy a domain while its being activated (#8...

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: core : we can destroy a domain while its being activated (#819283) ...................................................................... core : we can destroy a domain while its being activated (#819283) https://bugzilla.redhat.com/819283 The following bug will be solved by using in memory lock which will lock an storage object during force remove and avtivate stoarge Change-Id: Ia27d858e7372294bab54df600e98d48af9a2f5ff Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ActivateStorageDomainCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ForceRemoveStorageDomainCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StorageDomainParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/locks/LockingGroup.java 4 files changed, 15 insertions(+), 6 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5179 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia27d858e7372294bab54df600e98d48af9a2f5ff Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: non admin user api - Filtering for VM template(s) (...

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: restapi: non admin user api - Filtering for VM template(s) (#783087) ...................................................................... restapi: non admin user api - Filtering for VM template(s) (#783087) https://bugzilla.redhat.com/783087 - Support for filtering VM Template(s) when 'filter' header set to true when accessing /api/templates & /api/templates/{id} urls. - Added the 'filter' header to the rsdl metadata file in the appropriate names. Change-Id: I39a4c046c0a0cf0cc2a120001eca27a8d5004482 Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendTemplatesResource.java 2 files changed, 8 insertions(+), 4 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5127 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I39a4c046c0a0cf0cc2a120001eca27a8d5004482 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 7 months

1
0
0 / 0

Change in ovirt-engine[master]: restapi: non admin user api - Support for filtering clusters...

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: restapi: non admin user api - Support for filtering clusters (#783087) ...................................................................... restapi: non admin user api - Support for filtering clusters (#783087) https://bugzilla.redhat.com/783087 - Support for filtering Cluster(s) when 'filter' header set to true when accessing /api/clusters & /api/clusters/{id} urls. - Added the 'filter' header to the rsdl metadata file in the appropriate names. Change-Id: Idb606244286994a0c93abf8e5b6170ce292499ab Signed-off-by: Asaf Shakarchi <asaf(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata_v-3.1.yaml M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendClustersResource.java 2 files changed, 13 insertions(+), 9 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5123 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idb606244286994a0c93abf8e5b6170ce292499ab Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

12 years, 7 months

1
0
0 / 0

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits June 2012