June 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: spice client properties
by gchaplik＠redhat.com 11 Jun '12

11 Jun '12

Gilad Chaplik has submitted this change and it was merged. Change subject: userportal: spice client properties ...................................................................... userportal: spice client properties Added the "Enable WAN Options" checkbox to the edit console popup. It is visible, when all of the following conditions are met: - the selected VM is a windows VM - the spice is available - the spice radio button is selected - the spice guest agent is installed on the VM If the above conditions are met, and the checkbox is checked, the "WANDisableEffects" and "WANColorDepth" from the vdc_options table are set to the spice plugin as the "DisableEffects" and "ColorDepth" properties. In other case, nothing is set to the "DisableEffects" and "ColorDepth" properties. Change-Id: Ic8aa78cea7a05c9edf3fae084b2fdbb4b6943598 Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/SpiceInterfaceImpl.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/PoolItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalItemModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/VmItemBehavior.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ISpice.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/SpiceConsoleModel.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WANDisableEffects.java A frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/WanColorDepth.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/ApplicationConstants.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/popup/console/ConsolePopupPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/presenter/tab/basic/MainTabBasicDetailsPresenterWidget.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/console/ConsolePopupView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/popup/console/ConsolePopupView.ui.xml M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/section/main/view/tab/extended/SideTabExtendedVirtualMachineView.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/uicommon/UserPortalConfigurator.java M frontend/webadmin/modules/userportal-gwtp/src/main/java/org/ovirt/engine/ui/userportal/widget/basic/ConsoleUtils.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/uicommon/WebAdminConfigurator.java 18 files changed, 499 insertions(+), 57 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5073 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic8aa78cea7a05c9edf3fae084b2fdbb4b6943598 Gerrit-PatchSet: 11 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: canDoAction for No up server found validation added
by ofrenkel＠redhat.com 11 Jun '12

11 Jun '12

Omer Frenkel has submitted this change and it was merged. Change subject: engine: canDoAction for No up server found validation added ...................................................................... engine: canDoAction for No up server found validation added All Gluster command required atleast one upserver to execute the command. If no up server found in the cluster vdc action will return appropriate error message. Gluster command junit tests are modified. Change-Id: I46da8c09ba3b5b754abd12d78559948f7d0ef9c6 Signed-off-by: Selvasundaram <sesubram(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterCommandBase.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/DeleteGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/ResetGlusterVolumeOptionsCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StartRebalanceGlusterVolumeCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/StopGlusterVolumeCommandTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java 12 files changed, 191 insertions(+), 16 deletions(-) Approvals: Selvasundaram: Verified Omer Frenkel: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4973 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I46da8c09ba3b5b754abd12d78559948f7d0ef9c6 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Dhandapani Gopal <dgopal(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com> Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Remove Payload Info From VM Collection
by oliel＠redhat.com 11 Jun '12

11 Jun '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Remove Payload Info From VM Collection ...................................................................... restapi: Remove Payload Info From VM Collection The way we currently append payload information to VMs is a potential performance hazard. The solution is that for now we will display Payload info at the single VM level only, and revisit the collection level later. Change-Id: Ic784dfe4b2143d9a28fec3a95eaca8ab3594e8ba Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendVmsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendVmsResourceTest.java 2 files changed, 1 insertion(+), 24 deletions(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4981 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic784dfe4b2143d9a28fec3a95eaca8ab3594e8ba Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: Fix Broken Vms Tests
by oliel＠redhat.com 11 Jun '12

11 Jun '12

Ori Liel has submitted this change and it was merged. Change subject: restapi: Fix Broken Vms Tests ...................................................................... restapi: Fix Broken Vms Tests Change-Id: Id0c1ce81e9d80ee99da99fd200ff76ba899bd6f5 Signed-off-by: Ori Liel <oliel(a)redhat.com> --- M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/VmMapper.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Ori Liel: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5224 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id0c1ce81e9d80ee99da99fd200ff76ba899bd6f5 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change default transaction timeout to 600 seconds
by oourfali＠redhat.com 11 Jun '12

11 Jun '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: Change default transaction timeout to 600 seconds ...................................................................... core: Change default transaction timeout to 600 seconds Some of the transactions in the backend need this longer timeout, and it is already the default in development environments. Change-Id: I52a7bf1a0b782d390331365439ccc1c322a28fd1 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M packaging/fedora/engine-service.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5223 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I52a7bf1a0b782d390331365439ccc1c322a28fd1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core : Fixing wrong code
by mkublin＠redhat.com 11 Jun '12

11 Jun '12

Michael Kublin has submitted this change and it was merged. Change subject: core : Fixing wrong code ...................................................................... core : Fixing wrong code Small fix, fixing wrong code Change-Id: Iceec1967fb84fd81de175f23d0a5d2ec7e51d35a Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/FencingExecutor.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5222 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iceec1967fb84fd81de175f23d0a5d2ec7e51d35a Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: adding WANDisableEffects and WANColorDepth to vdc_op...
by lhornyak＠redhat.com 11 Jun '12

11 Jun '12

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: adding WANDisableEffects and WANColorDepth to vdc_options ...................................................................... engine: adding WANDisableEffects and WANColorDepth to vdc_options Needed by Spice. Change-Id: I404119901b6650c263d84eaf3cd2d3635c29ceff Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com> --- M backend/manager/dbscripts/upgrade/pre_upgrade/config.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/queries/ConfigurationValues.java 3 files changed, 13 insertions(+), 2 deletions(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5072 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I404119901b6650c263d84eaf3cd2d3635c29ceff Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change boot protocol keys to constant
by mkolesni＠redhat.com 11 Jun '12

11 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Change boot protocol keys to constant ...................................................................... core: Change boot protocol keys to constant These keys are constant in the VDSM API, so defining them locally per this API instead of relying on some external constant which may change without notice. Also VDSM expects lower-case keys, while the external constant is upper-case. Change-Id: I5fbc1357c90c69db7995082644824db5c35dbf9a Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5090 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5fbc1357c90c69db7995082644824db5c35dbf9a Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Added test for network boot protocol DHCP
by mkolesni＠redhat.com 11 Jun '12

11 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Added test for network boot protocol DHCP ...................................................................... core: Added test for network boot protocol DHCP Added test that checks that network with boot protocol is sent correctly. Change-Id: I743213efa4e746c5c37366eac807e4ed0072df7b Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommandTest.java 2 files changed, 55 insertions(+), 5 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5089 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I743213efa4e746c5c37366eac807e4ed0072df7b Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Change BONDING_OPTS to options (#828171)
by mkolesni＠redhat.com 11 Jun '12

11 Jun '12

Mike Kolesnik has submitted this change and it was merged. Change subject: core: Change BONDING_OPTS to options (#828171) ...................................................................... core: Change BONDING_OPTS to options (#828171) https://bugzilla.redhat.com/828171 Change key sent to VDSM to the correct key. Change-Id: I8166f75199541be61c406d7e5278cc48ade2edb2 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SetupNetworksVDSCommand.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5088 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8166f75199541be61c406d7e5278cc48ade2edb2 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0