July 2012 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: core: Fix validation of Updating attached network

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Fix validation of Updating attached network ...................................................................... core: Fix validation of Updating attached network The patch modifies the existing validation of network which about to be modified: 1. The old network name is obtained from the engine database, rather getting it from the clients. This prevents the possibility to perform 2-in-1 action (removing a network and updating and existing one). 2. The validation of existence of the old network name is removed since the network is obtained from an interface reported by the host. Change-Id: I25ab34d64cc4891dba176e1cd11d073f731d2d8a Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 24 insertions(+), 29 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I25ab34d64cc4891dba176e1cd11d073f731d2d8a Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Code cleanup and adjustment of UpdateNetworkToVdsInter...

by masayag＠redhat.com

Moti Asayag has submitted this change and it was merged. Change subject: core: Code cleanup and adjustment of UpdateNetworkToVdsInterfaceCommand ...................................................................... core: Code cleanup and adjustment of UpdateNetworkToVdsInterfaceCommand The patch performs some code cleanup and adjustments: 1. Replace the deprecated StringHelper with StringUtils. 2. Rename member names which start with an underscore. Change-Id: Ib97a482bc781aedacadbc1227a4ff2031a20995d Signed-off-by: Moti Asayag <masayag(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateNetworkToVdsInterfaceCommand.java 1 file changed, 39 insertions(+), 32 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib97a482bc781aedacadbc1227a4ff2031a20995d Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: Show iso name, install host dialog (#728154)

by achub＠redhat.com

Alexey Chub has submitted this change and it was merged. Change subject: webadmin: Show iso name, install host dialog (#728154) ...................................................................... webadmin: Show iso name, install host dialog (#728154) http://bugzilla.redhat.com/728154 Change-Id: Ie559f2cf60c15c07787867cfcd477f56e4e16214 Signed-off-by: Alexey Chub <achub(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostGeneralModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/HostInstallPopupView.java 2 files changed, 2 insertions(+), 23 deletions(-) Approvals: Alexey Chub: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6043 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie559f2cf60c15c07787867cfcd477f56e4e16214 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Alexey Chub <achub(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: webadmin: missing LocalizedEnum - ConnectStorageToVds

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: missing LocalizedEnum - ConnectStorageToVds ...................................................................... webadmin: missing LocalizedEnum - ConnectStorageToVds https://bugzilla.redhat.com/834027 Added missing 'ConnectStorageToVds' ConnectStorageToVds to LocalizedEnums.java and LocalizedEnums.properties Change-Id: Id4629be1d5de653b427102666379e99fc50c8a11 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 2 files changed, 3 insertions(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6031 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id4629be1d5de653b427102666379e99fc50c8a11 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: Config tool: Get password via file or interactive console

by shavivi＠redhat.com

Shahar Havivi has submitted this change and it was merged. Change subject: Config tool: Get password via file or interactive console ...................................................................... Config tool: Get password via file or interactive console Change-Id: Icb0fe737e9d63ea5d066e31baa83126678e41fc7 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigCLIParser.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/EngineConfigLogic.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/ConfigKey.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/ConfigKeyFactory.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/CompositePasswordValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/IntegerValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/PasswordValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/StringMultipleValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/StringValueHelper.java M backend/manager/tools/engine-config/src/main/java/org/ovirt/engine/core/config/entity/helper/ValueHelper.java 12 files changed, 119 insertions(+), 28 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icb0fe737e9d63ea5d066e31baa83126678e41fc7 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: core: endTaskJob - update exitStatus by taskGroupSuccess

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core: endTaskJob - update exitStatus by taskGroupSuccess ...................................................................... core: endTaskJob - update exitStatus by taskGroupSuccess EntityAsyncTask -> handleEndActionResult: endTaskJob's exitStatus should be calculated by returnValue's succeeded flag and task's groupSuccess (a sub-task ending with status failure means a failed task). Change-Id: Ibdc0f7804b87c2a98514bac3c862fc5ecf6288f0 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/EntityAsyncTask.java 1 file changed, 5 insertions(+), 3 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6019 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibdc0f7804b87c2a98514bac3c862fc5ecf6288f0 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: ui: move logical networks cluster sub-tab to same position a...

by oourfali＠redhat.com

Oved Ourfali has submitted this change and it was merged. Change subject: ui: move logical networks cluster sub-tab to same position as in DC ...................................................................... ui: move logical networks cluster sub-tab to same position as in DC This patch moves the logical network cluster sub-tab to the same position as it is in the DC tab. Change-Id: Ib1be5f7187705eba7c43a42958974d13260ac139 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterHostPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterNetworkPresenter.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/presenter/tab/cluster/SubTabClusterVmPresenter.java 4 files changed, 4 insertions(+), 4 deletions(-) Approvals: Daniel Erez: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/6033 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib1be5f7187705eba7c43a42958974d13260ac139 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine-cli[master]: cli: import RequestError only when needed

by mpastern＠redhat.com

Michael Pasternak has submitted this change and it was merged. Change subject: cli: import RequestError only when needed ...................................................................... cli: import RequestError only when needed Change-Id: Ibfcb66a469ccfd4ef0cd7a23836d78162990936e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/cli/context.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/6036 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibfcb66a469ccfd4ef0cd7a23836d78162990936e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-reports[master]: reports: making the pollingTimeout to be in seconds

by ydary＠redhat.com

Yaniv Dary has submitted this change and it was merged. Change subject: reports: making the pollingTimeout to be in seconds ...................................................................... reports: making the pollingTimeout to be in seconds Previous patch added the pollingTimeout functionality, but it was in minutes. This patch changes it to seconds. Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> Change-Id: I9622decf0e16e5856f01583e7dca5426754b0520 --- M reports/jars/EngineAuthentication/src/main/java/org/ovirt/authentication/EngineSimplePreAuthFilter.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Yaniv Dary: Looks good to me, approved Oved Ourfali: Verified -- To view, visit http://gerrit.ovirt.org/5963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9622decf0e16e5856f01583e7dca5426754b0520 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-reports Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>

12 years, 5 months

1
0
0 / 0

Change in ovirt-engine[master]: packaging: Moving to use execCmd in all scripts (#731686)

by oschreib＠redhat.com

Ofer Schreiber has submitted this change and it was merged. Change subject: packaging: Moving to use execCmd in all scripts (#731686) ...................................................................... packaging: Moving to use execCmd in all scripts (#731686) https://bugzilla.redhat.com/show_bug.cgi?id=731686 * Renamed all uses of execExternalCmd() to use execCmd(). * Removed execExternalCmd function from common_utils.py Change-Id: If5428890f9dcf8eafaa1ab059ee5d9e84f3f7f9a Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/engine-upgrade.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/nfsutils.py 6 files changed, 313 insertions(+), 144 deletions(-) Approvals: Alex Lourie: Verified; Looks good to me, but someone else must approve Ofer Schreiber: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4943 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5428890f9dcf8eafaa1ab059ee5d9e84f3f7f9a Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

12 years, 5 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits July 2012