July 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: restapi: expose host certificate subject in host properties
by mpastern＠redhat.com 08 Jul '12

08 Jul '12

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: expose host certificate subject in host properties ...................................................................... restapi: expose host certificate subject in host properties <certificate> <organization>XXX</organization> <subject>O=XXX,CN=YYY</subject> </certificate> Change-Id: I8716ba5e096b7b86c924385d02ceccef5315d84c Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/api.xsd M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostResource.java M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendHostsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendHostsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendResourceTest.java 6 files changed, 161 insertions(+), 15 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5984 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8716ba5e096b7b86c924385d02ceccef5315d84c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Change lookup for cluster network
by mkolesni＠redhat.com 08 Jul '12

08 Jul '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Change lookup for cluster network ...................................................................... engine: Change lookup for cluster network There's no reason to look for cluster network by name, since the network has an ID and the cluster has an ID. Change-Id: Ia25850d7691e5e09c57d98d2146c3dd67a46fd9e Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AttachNetworkToVdsGroupCommandTest.java 2 files changed, 8 insertions(+), 36 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5511 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia25850d7691e5e09c57d98d2146c3dd67a46fd9e Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: Add method to process "VmsCount" log token
by oourfali＠redhat.com 07 Jul '12

07 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: engine: Add method to process "VmsCount" log token ...................................................................... engine: Add method to process "VmsCount" log token https://bugzilla.redhat.com/835933 Two existing event log messages, displayed when adding or updating VM pools, had the ${VmsCount} token present but there was no code to process the token. This caused the text "VmsCount" to appear in the messages instead of the numeric count. Change-Id: I2dce0c2a2103949e4785c1cd22c12630af8e9bbf Signed-off-by: Greg Padgett <gpadgett(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommonVmPoolWithVmsCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Greg Padgett: Verified Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5991 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2dce0c2a2103949e4785c1cd22c12630af8e9bbf Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: 'import more than once' saves snapshot as disk (#83055...
by gchaplik＠redhat.com 05 Jul '12

05 Jul '12

Gilad Chaplik has submitted this change and it was merged. Change subject: core: 'import more than once' saves snapshot as disk (#830557) ...................................................................... core: 'import more than once' saves snapshot as disk (#830557) https://bugzilla.redhat.com/830557 when importing more than once, the vm's snapshots had the original vm id, and image group, instead of the newly created. because of that we created a vmDevice record for each of the snapshot, for a disk. Change-Id: I7689f7466a82cfebefef0971f751293bd3c654eb Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/5751 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7689f7466a82cfebefef0971f751293bd3c654eb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: rename Host 'problematic' state to connecting
by emesika＠redhat.com 05 Jul '12

05 Jul '12

Eli Mesika has submitted this change and it was merged. Change subject: core: rename Host 'problematic' state to connecting ...................................................................... core: rename Host 'problematic' state to connecting Rename enum from problematic to connecting Modify all relevant message entries Change-Id: I390d089af790871fb060f1f2a50918d957d7d55c Signed-off-by: Eli Mesika <emesika(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HandleVdsVersionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/StartVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FenceVdsManualyCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcActionUtils.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VDSStatus.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/HostMapper.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/ResourceManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SpmStopVDSCommand.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Enums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/Enums.properties M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/table/column/HostStatusCell.java M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 16 files changed, 17 insertions(+), 17 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5190 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I390d089af790871fb060f1f2a50918d957d7d55c Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: setting action name and object type on ChangeVDSCluste...
by oourfali＠redhat.com 05 Jul '12

05 Jul '12

Oved Ourfali has submitted this change and it was merged. Change subject: core: setting action name and object type on ChangeVDSClusterCommand ...................................................................... core: setting action name and object type on ChangeVDSClusterCommand This patch sets the action and object type in the ChangeVDSClusterCommand, so that it will be replaces properly in the log messages. Change-Id: If920743d6e09d2233ed2e5140607e9904e3620e6 Signed-off-by: Oved Ourfali <oourfali(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ChangeVDSClusterCommand.java 1 file changed, 6 insertions(+), 0 deletions(-) Approvals: Oved Ourfali: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5972 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If920743d6e09d2233ed2e5140607e9904e3620e6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: fix NPE
by emesika＠redhat.com 05 Jul '12

05 Jul '12

Eli Mesika has submitted this change and it was merged. Change subject: core: fix NPE ...................................................................... core: fix NPE in equals method of VmBase there is no check of NPE for dedicated_vm_for_vds. Change-Id: If03b4d9337ecd8b4b03f28b683035413c866c36e Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VmBase.java 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Eli Mesika: Looks good to me, approved Gilad Chaplik: Verified -- To view, visit http://gerrit.ovirt.org/5971 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If03b4d9337ecd8b4b03f28b683035413c866c36e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ConfigValues - Reloadable and Deprecated
by msalem＠redhat.com 05 Jul '12

05 Jul '12

Muli Salem has submitted this change and it was merged. Change subject: core: ConfigValues - Reloadable and Deprecated ...................................................................... core: ConfigValues - Reloadable and Deprecated This patch add the @Reloadable Annotation to the relevant members in ConfigValues. It also adds the @Deprecated Annotation to unused members. Signed-off-by: Muli Salem <msalem(a)redhat.com> Change-Id: I5f7bc04f303696d10e6c99de0f5cbcae592d8b8d --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigValues.java 1 file changed, 198 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/4948 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5f7bc04f303696d10e6c99de0f5cbcae592d8b8d Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: Edit storage - update NFS Version parameter
by derez＠redhat.com 05 Jul '12

05 Jul '12

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: Edit storage - update NFS Version parameter ...................................................................... webadmin: Edit storage - update NFS Version parameter https://bugzilla.redhat.com/835554 * Added a missing nullity check to 'itemModel.getEntity()'. * Re-factored Version property updating condition. Change-Id: Ie2ee0549e1e37b59fdf2e0f193a7cc6a2a2926c6 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageListModel.java 1 file changed, 4 insertions(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/5968 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2ee0549e1e37b59fdf2e0f193a7cc6a2a2926c6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-log-collector[master]: tools: Gracefully handle cases where API is down.
by oschreib＠redhat.com 05 Jul '12

05 Jul '12

Ofer Schreiber has submitted this change and it was merged. Change subject: tools: Gracefully handle cases where API is down. ...................................................................... tools: Gracefully handle cases where API is down. Didn't have gettext imported which caused many exception catches to be bypassed and resulted in ungraceful exits. Manifested obviously when REST API was down or when incorrect PW supplied. Change-Id: Icd77cb075e6984e4feb885fd407e21ed34f09cc1 Signed-off-by: Keith Robertson <kroberts(a)redhat.com> --- M src/rhev/helper/hypervisors.py M src/rhev/logcollector.py 2 files changed, 19 insertions(+), 4 deletions(-) Approvals: Ofer Schreiber: Looks good to me, approved Keith Robertson: Verified -- To view, visit http://gerrit.ovirt.org/5785 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Icd77cb075e6984e4feb885fd407e21ed34f09cc1 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-log-collector Gerrit-Branch: master Gerrit-Owner: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Lee Yarwood <lyarwood(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0