August 2012 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: core: Remove deprecated StringHelper in GetDeviceListQuery.
by masayag＠redhat.com 19 Aug '12

19 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove deprecated StringHelper in GetDeviceListQuery. ...................................................................... core: Remove deprecated StringHelper in GetDeviceListQuery. Replaced StringHelper with StringUtils Change-Id: I917ce720963d95dbc7154dbb692a0bfcccf632f6 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/GetDeviceListQuery.java 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7238 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I917ce720963d95dbc7154dbb692a0bfcccf632f6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Remove deprecated StringHelper in VdsInstaller.
by masayag＠redhat.com 19 Aug '12

19 Aug '12

Moti Asayag has submitted this change and it was merged. Change subject: core: Remove deprecated StringHelper in VdsInstaller. ...................................................................... core: Remove deprecated StringHelper in VdsInstaller. Replaced StringHelper with StringUtils Change-Id: Ic0a18db51ef6411ea6379763f117a470723b4ce0 Signed-off-by: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7240 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic0a18db51ef6411ea6379763f117a470723b4ce0 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core:Print clusters when upgrading DC version(#844425)
by mlipchuk＠redhat.com 19 Aug '12

19 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Print clusters when upgrading DC version(#844425) ...................................................................... core:Print clusters when upgrading DC version(#844425) https://bugzilla.redhat.com/show_bug.cgi?id=844425 When we upgrade Data-Center we check if all cluster also has a validate level (which is the same as the DC or higher), if not, the user gets a message that he should upgrade the clusters, but there are no mention which clusters it should be upgraded. The proposed fix, adds the cluster names that should be upgraded to the message, and add a test to cover it. Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> Change-Id: Ia9c92d1c477354f7f5fa66895ecf2ab38c10bdf6 --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/UpdateStoragePoolCommandTest.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/utils/src/test/resources/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 7 files changed, 57 insertions(+), 17 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7132 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia9c92d1c477354f7f5fa66895ecf2ab38c10bdf6 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: bootstrap: send firewall rules without creating temp file
by yzaslavs＠redhat.com 19 Aug '12

19 Aug '12

Yair Zaslavsky has submitted this change and it was merged. Change subject: bootstrap: send firewall rules without creating temp file ...................................................................... bootstrap: send firewall rules without creating temp file With new SSH implementation there is no need to use temporary files to send files from memory. Change-Id: I61b0ee4c62382807d14c5476baf2898a08ee5892 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VdsInstaller.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSH.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/hostinstall/VdsInstallerSSHTest.java 3 files changed, 54 insertions(+), 26 deletions(-) Approvals: Yair Zaslavsky: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7028 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61b0ee4c62382807d14c5476baf2898a08ee5892 Gerrit-PatchSet: 10 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: STP Allowed Only in VM Network (#839546)
by msalem＠redhat.com 19 Aug '12

19 Aug '12

Muli Salem has submitted this change and it was merged. Change subject: core: STP Allowed Only in VM Network (#839546) ...................................................................... core: STP Allowed Only in VM Network (#839546) https://bugzilla.redhat.com/839546 This patch adds a canDoAction in Add/Update NetworkCommand to make sure the STP property is only used with VM Networks. Change-Id: If5b628aaa62c0113d398781eca97ac5445928624 Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddNetworkCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/NetworkCommon.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateNetworkCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 25 insertions(+), 0 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7305 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If5b628aaa62c0113d398781eca97ac5445928624 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com>

1 0

Change in ovirt-engine[master]: core:Add connection to DB after connectVds(#815083)
by mlipchuk＠redhat.com 19 Aug '12

19 Aug '12

Maor Lipchuk has submitted this change and it was merged. Change subject: core:Add connection to DB after connectVds(#815083) ...................................................................... core:Add connection to DB after connectVds(#815083) https://bugzilla.redhat.com/show_bug.cgi?id=815083 When user adds a faulty storage connection it will cause the command to fail, but will leave the connection in the data base. The proposed fix is to add the connection to the DB, only after connect has succeeded at the execute section. Also some unused code is being removed, when we get Vds Id which is empty, rest and GUI should not send an empty vds Id. Change-Id: I6e1387295f4c24f4222b57924ec2f4380411c5f4 Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java 1 file changed, 11 insertions(+), 28 deletions(-) Approvals: Maor Lipchuk: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/3784 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I6e1387295f4c24f4222b57924ec2f4380411c5f4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: webadmin: adding port mirroring indication to network interf...
by alkaplan＠redhat.com 19 Aug '12

19 Aug '12

Alona Kaplan has submitted this change and it was merged. Change subject: webadmin: adding port mirroring indication to network interface (#845991) ...................................................................... webadmin: adding port mirroring indication to network interface (#845991) https://bugzilla.redhat.com/845991 Problem: there is no way to see if a nic has port mirroring enabled Solution: added a column to the network interface tab indicating the use of port mirroring the indication is "Enabled" for true and blank for false created new column type BooleanColumn, shows a message by a boolean value added the needed column in SubTabVirtualMachineNetworkInterfaceView Change-Id: I9949aea5b6817a898a51ffd496969d7217e5db20 Signed-off-by: Noam Slomianko <nslomian(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java A frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/table/column/BooleanColumn.java M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/vm/BaseInterfaceListModelTable.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/virtualMachine/SubTabVirtualMachineNetworkInterfaceView.java 4 files changed, 39 insertions(+), 2 deletions(-) Approvals: Alona Kaplan: Looks good to me, approved Noam Slomianko: Verified -- To view, visit http://gerrit.ovirt.org/7124 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9949aea5b6817a898a51ffd496969d7217e5db20 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Noam Slomianko <nslomian(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: core: Block Hotplug Nic in Certain Vm States (#826931)
by msalem＠redhat.com 19 Aug '12

19 Aug '12

Muli Salem has submitted this change and it was merged. Change subject: core: Block Hotplug Nic in Certain Vm States (#826931) ...................................................................... core: Block Hotplug Nic in Certain Vm States (#826931) https://bugzilla.redhat.com/826931 This patch adds a canDoAction that makes sure the VM is in a valid state for attaching a network interface. The patch also adds a check in AddVmInterfaceCommand, to make sure Hotplug is supported by OS and according to flag in vdc_options. Change-Id: Id759ca8152b455047c9c83447f526aaccdd77d6c Signed-off-by: Muli Salem <msalem(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmInterfaceCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HotPlugUnplugVmNicCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmHandler.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 8 files changed, 46 insertions(+), 11 deletions(-) Approvals: Muli Salem: Verified; Looks good to me, approved Moti Asayag: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7176 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id759ca8152b455047c9c83447f526aaccdd77d6c Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Muli Salem <msalem(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Capitalize DC in network messages (#846241)
by mkolesni＠redhat.com 19 Aug '12

19 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Capitalize DC in network messages (#846241) ...................................................................... engine: Capitalize DC in network messages (#846241) https://bugzilla.redhat.com/846241 Data Center should be written with capital letters as it is written in other messages. Change-Id: I86a09bf1ee6f57381d3b0d85e8992960784dc7c9 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7303 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I86a09bf1ee6f57381d3b0d85e8992960784dc7c9 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0

Change in ovirt-engine[master]: engine: Added audit log to update network (#846241)
by mkolesni＠redhat.com 19 Aug '12

19 Aug '12

Mike Kolesnik has submitted this change and it was merged. Change subject: engine: Added audit log to update network (#846241) ...................................................................... engine: Added audit log to update network (#846241) https://bugzilla.redhat.com/846241 Added audit logging to update of network in the DC. Change-Id: I5743f143c596c1ea57e2a45c54324dbd04876d70 Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/UpdateNetworkCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 4 files changed, 14 insertions(+), 2 deletions(-) Approvals: Mike Kolesnik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/7219 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5743f143c596c1ea57e2a45c54324dbd04876d70 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: oVirt Jenkins CI Server

1 0