Change in ovirt-engine[master]: core: Updated to version 3.2
by mkolesni@redhat.com
Mike Kolesnik has submitted this change and it was merged.
Change subject: core: Updated to version 3.2
......................................................................
core: Updated to version 3.2
The 3.2 compatibility version is needed to support bridgeless networks
in oVirt, so updated the version to 3.2 and added necessary keys to
allow data-centers & clusters in this version.
Change-Id: Ic4ed674435fbfa12dcc9e280e32145270da0278a
Signed-off-by: Mike Kolesnik <mkolesni(a)redhat.com>
---
M backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
1 file changed, 31 insertions(+), 2 deletions(-)
Approvals:
Mike Kolesnik: Verified
Moti Asayag: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7169
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic4ed674435fbfa12dcc9e280e32145270da0278a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: packaging: Better failed start message (#838527)
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Better failed start message (#838527)
......................................................................
packaging: Better failed start message (#838527)
https://bugzilla.redhat.com/838527
Improve the message presented to the user when the service can't
be started because the PID file exists but the process is not
running, thus indicating that the service crashed or was killed.
Change-Id: I4099e4e32dd76eeca7f42a90e0fb5ed0049313fd
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/fedora/engine-service.py
1 file changed, 19 insertions(+), 2 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7175
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4099e4e32dd76eeca7f42a90e0fb5ed0049313fd
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: packaging: Create vdsm user and kvm group (#847833)
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Create vdsm user and kvm group (#847833)
......................................................................
packaging: Create vdsm user and kvm group (#847833)
https://bugzilla.redhat.com/847833
The vdsm user and kvm group used to be created by the ovirt-engine
package before the changes I did to support Fedora 17. That was a
mistake. This patch brings that back.
Change-Id: I8cca5a00df645c375e2c5a0f30e4bb47853cc22b
Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com>
---
M packaging/fedora/spec/ovirt-engine.spec.in
1 file changed, 32 insertions(+), 4 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
Keith Robertson: Looks good to me, but someone else must approve
--
To view, visit http://gerrit.ovirt.org/7247
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8cca5a00df645c375e2c5a0f30e4bb47853cc22b
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: BZ#841676 packaging: modify secure db connection prompt
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: BZ#841676 packaging: modify secure db connection prompt
......................................................................
BZ#841676 packaging: modify secure db connection prompt
Phrase the ssl prompt to a more user friendly prompt, so the default
'no' may be kept without alerting anyone.
Alters commit 88bb2185880 with different wording.
Change-Id: Iea03c96997d7fe5b38850015e35f015578c4497b
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/setup/output_messages.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7269
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iea03c96997d7fe5b38850015e35f015578c4497b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Yaniv Kaul <ykaul(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: packaging: Updated cleanup to show error message to user (#8...
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Updated cleanup to show error message to user (#818230)
......................................................................
packaging: Updated cleanup to show error message to user (#818230)
https://bugzilla.redhat.com/show_bug.cgi?id=818230
* Updated engine-cleanup to show an error message during DB drop
about possible external connections to the DB and print it to
the user in addition to the log.
Change-Id: Ia11d0604f5e476f5359b7d13dc5bc3934f119897
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/engine-cleanup.py
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Alex Lourie: Verified; Looks good to me, but someone else must approve
Juan Hernandez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/4907
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia11d0604f5e476f5359b7d13dc5bc3934f119897
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: 848434 - In UserPortal user can only see his own permissions...
by oourfali@redhat.com
Oved Ourfali has submitted this change and it was merged.
Change subject: 848434 - In UserPortal user can only see his own permissions on the objects (#848434)
......................................................................
848434 - In UserPortal user can only see his own permissions on the objects (#848434)
https://bugzilla.redhat.com/show_bug.cgi?id=848434
This patch changes the logic of getting direct permissions on an object,
to show all permissions to a user which has any permission on the
object.
Change-Id: Ic7a54ab2de26b607b9e79dc678f0bb45b700e343
Signed-off-by: Oved Ourfali <oourfali(a)redhat.com>
---
M backend/manager/dbscripts/multi_level_administration_sp.sql
1 file changed, 15 insertions(+), 2 deletions(-)
Approvals:
Oved Ourfali: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7246
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic7a54ab2de26b607b9e79dc678f0bb45b700e343
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-dwh[master]: packaging: replaced execExternalCmd with execCmd (#844667)
by ydary@redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: replaced execExternalCmd with execCmd (#844667)
......................................................................
packaging: replaced execExternalCmd with execCmd (#844667)
https://bugzilla.redhat.com/844667
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
Change-Id: I12458bd73d6806048a3f627b57005192ab627be1
---
M packaging/common_utils.py
M packaging/ovirt-engine-dwh-setup.py
2 files changed, 56 insertions(+), 59 deletions(-)
Approvals:
Alex Lourie: Verified; Looks good to me, but someone else must approve
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7250
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I12458bd73d6806048a3f627b57005192ab627be1
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: attach of Illegal disk should not be allowed (#848074)
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: attach of Illegal disk should not be allowed (#848074)
......................................................................
core: attach of Illegal disk should not be allowed (#848074)
https://bugzilla.redhat.com/show_bug.cgi?id=848074
Illegal disk should not be allowed to be attached to VMs, only to be
deleted, since we can't know if this disk is valid in the storage or
not.
Change-Id: I35fe4123c40de371a6f338bc3655923ab51400e1
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M backend/manager/modules/utils/src/test/resources/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
5 files changed, 16 insertions(+), 5 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7205
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I35fe4123c40de371a6f338bc3655923ab51400e1
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Ori Liel <oliel(a)redhat.com>
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: engine:Remaining disks of deleted VM will be ILLEGAL.(#82205...
by mlipchuk@redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
......................................................................
engine:Remaining disks of deleted VM will be ILLEGAL.(#822051)
When removing a VM, the VM images are removed from the VDSM
and the DB.
If VDSM fails to start a task for deleting a specific image,
it throws an exception and the image is not removed from the engine DB.
This results a bug which is reflected, when user sees part of the VM
disks, which were not be able to delete from the VDSM, in the
disk main tab.
The proposed solution is that we leave the remaining disks in the setup
with ILLEGAL state and remove all the rest of the VM.
Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/AuditLogType.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/auditloghandling/AuditLogDirector.java
M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties
5 files changed, 67 insertions(+), 7 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5806
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic59918037a87a2c169c4410d297de81a03ab6848
Gerrit-PatchSet: 14
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: packaging: Change variable name to be consistant to its mess...
by juan.hernandez@redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Change variable name to be consistant to its message type.
......................................................................
packaging: Change variable name to be consistant to its message type.
Changed the variable WARN_SPACES_IN_PASS to ERR_SPACES_IN_PASS. Variable
name should be consistant with its message type.
Change-Id: I9ba09e644837bb757aa0c2db43753c5b7f109843
Signed-off-by: Kiril Nesenko <knesenko(a)redhat.com>
---
M packaging/fedora/setup/engine_validators.py
M packaging/fedora/setup/output_messages.py
2 files changed, 5 insertions(+), 3 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7256
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ba09e644837bb757aa0c2db43753c5b7f109843
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Kiril Nesenko <knesenko(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>
12 years, 4 months