Change in ovirt-engine[master]: engine: ManageDomainsResult returns null when DB error raise...
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: engine: ManageDomainsResult returns null when DB error raise it (#818479)
......................................................................
engine: ManageDomainsResult returns null when DB error raise it (#818479)
https://bugzilla.redhat.com/show_bug.cgi?id=818479
Added variable of default message, so if error occurred during
varification of the paramerts, the default message will be the output.
Change-Id: If21f117208a53a80ebfefbbe4f6a0c188e35a3bd
Signed-off-by: Yaniv Bronhaim <ybronhei(a)redhat.com>
---
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ConfigurationProvider.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomains.java
M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/kerberos/ManageDomainsResult.java
3 files changed, 89 insertions(+), 41 deletions(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7202
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If21f117208a53a80ebfefbbe4f6a0c188e35a3bd
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: packaging: Block 3.1 upgrade if DC/cluster 2.2 present
by juan.hernandez＠redhat.com
Juan Hernandez has submitted this change and it was merged.
Change subject: packaging: Block 3.1 upgrade if DC/cluster 2.2 present
......................................................................
packaging: Block 3.1 upgrade if DC/cluster 2.2 present
* Added the DC + cluster version check before starting the
upgrade. If 2.2 version is found, raises an Exception.
Change-Id: I0277b73628872e8c0fa163fee0b89bd5cb724f05
Signed-off-by: Alex Lourie <alourie(a)redhat.com>
---
M packaging/fedora/setup/engine-upgrade.py
1 file changed, 42 insertions(+), 0 deletions(-)
Approvals:
Juan Hernandez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5186
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0277b73628872e8c0fa163fee0b89bd5cb724f05
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Fix exception for unlock VM.
by masayag＠redhat.com
Moti Asayag has submitted this change and it was merged.
Change subject: core: Fix exception for unlock VM.
......................................................................
core: Fix exception for unlock VM.
Fix exception to use unlock VM for VM instead vm id
Change-Id: Ia696ef0f7e0a66a99e8f9c53458961d26d77d5b7
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Moti Asayag: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7222
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia696ef0f7e0a66a99e8f9c53458961d26d77d5b7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: BZ#841676 packaging: modify secure db connection prompt
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: BZ#841676 packaging: modify secure db connection prompt
......................................................................
BZ#841676 packaging: modify secure db connection prompt
Phrase the ssl prompt to a more user friendly prompt, so the default
'no' may be kept without alerting anyone.
Change-Id: I447c842ff21ef7193b005ff9758572cdd3fe08d0
Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com>
---
M packaging/fedora/setup/output_messages.py
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7212
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I447c842ff21ef7193b005ff9758572cdd3fe08d0
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: core: enable import/export of diskless VM/VM with no snappab...
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core: enable import/export of diskless VM/VM with no snappable disks(#838937)
......................................................................
core: enable import/export of diskless VM/VM with no snappable disks(#838937)
https://bugzilla.redhat.com/show_bug.cgi?id=838937
this patch enables the export/import of VM's with no snappable/image
disks and diskless VM's.
Change-Id: I77565ffd66134b44d15f66cfdfa97422e3c11fb2
Signed-off-by: Liron Aravot <laravot(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
2 files changed, 74 insertions(+), 60 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6379
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I77565ffd66134b44d15f66cfdfa97422e3c11fb2
Gerrit-PatchSet: 15
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-dwh[master]: packaging: refactored package name in setup (#845024)
by ydary＠redhat.com
Yaniv Dary has submitted this change and it was merged.
Change subject: packaging: refactored package name in setup (#845024)
......................................................................
packaging: refactored package name in setup (#845024)
https://bugzilla.redhat.com/845024
Change-Id: I0beb85f5f45c89697b94498df1332d3c81240d44
Signed-off-by: Yaniv Dary <ydary(a)redhat.com>
---
M packaging/ovirt-engine-dwh-setup.py
1 file changed, 7 insertions(+), 6 deletions(-)
Approvals:
Alex Lourie: Looks good to me, but someone else must approve
Yaniv Dary: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7217
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0beb85f5f45c89697b94498df1332d3c81240d44
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-dwh
Gerrit-Branch: master
Gerrit-Owner: Yaniv Dary <ydary(a)redhat.com>
Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com>
Gerrit-Reviewer: Yaniv Dary <ydary(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: net int subtab- vlan hides non-vlan nets on the sa...
by alkaplan＠redhat.com
Alona Kaplan has submitted this change and it was merged.
Change subject: webadmin: net int subtab- vlan hides non-vlan nets on the same nic(#841513)
......................................................................
webadmin: net int subtab- vlan hides non-vlan nets on the same nic(#841513)
https://bugzilla.redhat.com/841513
if a nic have vlan network/s and non-vlan network, just the vlan networks
are displayed in the interface subtable.
Change-Id: Ib099f69896f2041aff573cd87a51836ec2dd2a21
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksInterfacePopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/SetupNetworksManagementPopupView.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/host/VLanPanel.java
3 files changed, 11 insertions(+), 6 deletions(-)
Approvals:
Alona Kaplan: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7208
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib099f69896f2041aff573cd87a51836ec2dd2a21
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
12 years, 4 months
Change in ovirt-engine[master]: webadmin: new VM: pin to host not used from template(#845570...
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: webadmin: new VM: pin to host not used from template(#845570)
......................................................................
webadmin: new VM: pin to host not used from template(#845570)
https://bugzilla.redhat.com/845570
New VM -> select template -> host tab
The data are not read from the template.
The probelem was that the reaction to the template selection
change was not the read of the update of the host pinning props.
Fixed by extraction of the respective logic and added to the
VmModelBehaviorBase (methods doChangeDefautlHost() and
updateHostPinning()). This methods are called also from the
Existing* behaviours to read the respective data from the
VM (or VM Data in case of Pool).
This patch also enriches the AbstractVmPopupWidget by
adding the listener to IsAutoAssign property, because
this is not connected with the model itself.
Change-Id: I561c5ee3967676ffd89758820b09a192a741a2e8
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewPoolModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
7 files changed, 64 insertions(+), 40 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6935
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I561c5ee3967676ffd89758820b09a192a741a2e8
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: userportal, webadmin: redesign vCPU editing (#809800)
by tjelinek＠redhat.com
Tomas Jelinek has submitted this change and it was merged.
Change subject: userportal,webadmin: redesign vCPU editing (#809800)
......................................................................
userportal,webadmin: redesign vCPU editing (#809800)
https://bugzilla.redhat.com/809800
The new design is now the following:
- there is an editable text field without a slider with label
"Total Virtual CPUs"
- just under it an "advanced options" expandable component with two
combo boxes:
- Virtual Sockets
- Cores per Virtual Socket
The behaviour is as follows:
- When the "Num of vCPUs" changes to new correct value, than:
1 when some value is already selected in the
"Cores per Virtual Socket", it tries to set the value of the
"Virtual Sockets" to compose the new "Total Virtual CPUs" but
preserving the "Cores per Virtual Socket" (e.g. "Cores per Virtual
Socket" is 2 and "Total Virtual CPUs" changed to 12, the "Virtual
Sockets" will be changed to 6).
2 If the "Cores per Virtual Socket" is not set or can not be used to
compose the new "Total Virtual CPUs", than the "Cores per Virtual
Socket" and "Virtual Sockets" are automatically adjusted to the new
values, while the "Virtual Sockets" tries to be the biggest possible
(but not bigger, than the predefined value from vdc_options). For
example, both the max enabled "Virtual Sockets" and "Cores per
Virtual Socket" is 16 and the "Total Virtual CPUs" changes to 18,
than the "Num of Virtual Sockets" will be 9 and the "Cores per
Virtual Socket" will be 2.
3 The combo boxes will be filled only by values, which
can be used to compose the selected "Total Virtual CPUs" (e.g. the
"Total Virtual CPUs" is the boundary for the advanced options.
- When the "Total Virtual CPUs" changes to new incorrect value, than the
"Cores per Socket" and "Num of Sockets" gets disabled
- On submit there are three validations:
1 Not Empty validation
2 Integer validation which checks both if the value is an integer and
also if it is between <1, max num of vcpus from vdc_options>
3 Custom validation, which checks, if the specified
"Total Virtual CPUs" is composable from the "Virtual Sockets" and
"Cores per Virtual Socket" (e.g. there exists at least one
combination of the available "Virtual Sockets" and "Cores per
Virtual Socket" which makes up this number of "Total Virtual CPUs".
If this is not fulfilled, than the following message is shown:
"Incorrect number of Total Virtual CPUs. It is not possible to
compose this number from the available Virtual Sockets and Cores
per Virtual Sockets"
- When one of the combo boxes changes, the second one is
automatically adjusted to the value to compose the selected
"Total Virtual CPUs" amount.
- The combo boxes never contains values, which can not compose
the defined "Total Virtual CPUs" amount.
Change-Id: I75cc943dfa986546878b3ae5faae3cfb637fb188
Signed-off-by: Tomas Jelinek <tjelinek(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationConstants.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/view/popup/AbstractVmPopupView.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/dialog/AdvancedParametersExpander.ui.xml
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelInputWithSlider.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelSliderWithTextBoxEditor.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/uicommon/popup/AbstractVmPopupWidget.ui.xml
D frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/RangeEntityModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/pools/PoolListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/templates/TemplateListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/ExistingVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewTemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/NewVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/PoolModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/TemplateVmModelBehavior.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/UnitVmModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmListModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmSnapshotListModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Messages.java
21 files changed, 495 insertions(+), 258 deletions(-)
Approvals:
Tomas Jelinek: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6184
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75cc943dfa986546878b3ae5faae3cfb637fb188
Gerrit-PatchSet: 8
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <tjelinek(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: merge the 2 SPM columns into 1 (#845320)
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: webadmin: merge the 2 SPM columns into 1 (#845320)
......................................................................
webadmin: merge the 2 SPM columns into 1 (#845320)
https://bugzilla.redhat.com/845320
The two columns - "SPM Status", "SPM Priority" were merged.
New column is called "SPM"
For a host which is Contending or SPM - the status is shown.
For other host - the priority is shown (Low, Normal, High, Custom)
The numberes behind the priority were drop from the column and the 'Edit
Host' -> SPM subtab.
Change-Id: I1db81336eac01ea2e713912a37e5bec90e10dfd5
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostModel.java
M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/Constants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/MainTabHostView.java
4 files changed, 21 insertions(+), 20 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/7170
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1db81336eac01ea2e713912a37e5bec90e10dfd5
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
12 years, 4 months