Change in ovirt-engine[master]: webadmin: [SetupNetworks] nets behaviour on bond create/exte...
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: [SetupNetworks] nets behaviour on bond create/extend (#840825)
......................................................................
webadmin: [SetupNetworks] nets behaviour on bond create/extend (#840825)
https://bugzilla.redhat.com/840825
If just one of the nics/bond in the action has attached networks,
they should be attached to the new/extended bond.
Otherwise- the operiotion should be blocked with explanation message.
Change-Id: Ic15934c9d12f24fdcc4f5d80503465d3810917e0
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperation.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java
3 files changed, 151 insertions(+), 16 deletions(-)
Approvals:
Daniel Erez: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6987
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic15934c9d12f24fdcc4f5d80503465d3810917e0
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core:Edit job message referencing template/VM(#818295)
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Edit job message referencing template/VM(#818295)
......................................................................
core:Edit job message referencing template/VM(#818295)
https://bugzilla.redhat.com/show_bug.cgi?id=818295
Edit job messages for vm and template, to indicate the container of
template and VM, instead the storage domain they created on.
For vm we use cluster, and for template we use storage pool
Change-Id: Id5d41889360cf7bc309e9e9a49fb0298269c7984
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java
M backend/manager/modules/dal/src/main/resources/bundles/ExecutionMessages.properties
4 files changed, 18 insertions(+), 6 deletions(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6353
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Id5d41889360cf7bc309e9e9a49fb0298269c7984
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: tools: Add tolerance to engine-setup min memory threshold
by oschreib＠redhat.com
Ofer Schreiber has submitted this change and it was merged.
Change subject: tools: Add tolerance to engine-setup min memory threshold
......................................................................
tools: Add tolerance to engine-setup min memory threshold
engine-setup exits with error if system is under memory
threshold in basedefs.py (CONST_MIN_MEMORY_GB).
Since engine-setup is using 'free -g' command, using
default threshold (2GB), systems with less than 2048 MB
of RAM will be classified as 1 GB.
e.g. a system with 2048 MB with some memory allowed
to video cards will not be able to run engine setup.
This patch will change engine-setup to use 'free -m',
change the memory threshold to be in MB and add a
tolerance of 5% to MIN_MEMORY.
http://bugzilla.redhat.com/843621
Change-Id: Ibd22cccc85c62535c57b651347bd6e7ccedec625
Signed-off-by: Amador Pahim <apahim(a)redhat.com>
---
M packaging/fedora/setup/basedefs.py
M packaging/fedora/setup/engine-setup.py
M packaging/fedora/setup/output_messages.py
3 files changed, 12 insertions(+), 11 deletions(-)
Approvals:
Ofer Schreiber: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6992
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibd22cccc85c62535c57b651347bd6e7ccedec625
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Amador Pahim <apahim(a)redhat.com>
Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>
Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>
Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: engine: Brick existance validation for add brick
by ofrenkel＠redhat.com
Omer Frenkel has submitted this change and it was merged.
Change subject: engine: Brick existance validation for add brick
......................................................................
engine: Brick existance validation for add brick
- New brick exists check is added in Add Brick To Gluster Volume command.
Change-Id: Ie93eb97560bc02157683983aa4e65cfb187bdb97
Signed-off-by: Selvasundaram <sesubram(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterVolumeRemoveBricksCommand.java
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/ReplaceGlusterVolumeBrickCommand.java
M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/gluster/AddBricksToGlusterVolumeCommandTest.java
M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java
M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties
M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java
7 files changed, 65 insertions(+), 8 deletions(-)
Approvals:
Selvasundaram: Verified
Omer Frenkel: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/5432
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie93eb97560bc02157683983aa4e65cfb187bdb97
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com>
Gerrit-Reviewer: Selvasundaram <sesubram(a)redhat.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: UI: fix NPE in new cluster dialogue
by shavivi＠redhat.com
Shahar Havivi has submitted this change and it was merged.
Change subject: UI: fix NPE in new cluster dialogue
......................................................................
UI: fix NPE in new cluster dialogue
Change-Id: Ic5de999ab1a18e7c9c44e5073380da8c41122355
Signed-off-by: Shahar Havivi<shavivi(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterModel.java
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Shahar Havivi: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6982
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic5de999ab1a18e7c9c44e5073380da8c41122355
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: backend: Quota log messages with UNKNOWN (#844646)
by dfediuck＠redhat.com
Doron Fediuck has submitted this change and it was merged.
Change subject: backend: Quota log messages with UNKNOWN (#844646)
......................................................................
backend: Quota log messages with UNKNOWN (#844646)
https://bugzilla.redhat.com/844646
creating, removing and editing quota show the action in even log with
quota name <UNKNOWN>
This was due to lack of getter in the Audit log machanism.
Change-Id: I53f74b169fd6032933475c62936e0aa34b352ee2
Signed-off-by: Ofri Masad <omasad(a)redhat.com>
---
M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/QuotaCRUDCommand.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Doron Fediuck: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6896
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I53f74b169fd6032933475c62936e0aa34b352ee2
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <omasad(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core:Use %d instead %i for String format (#843099)
by mlipchuk＠redhat.com
Maor Lipchuk has submitted this change and it was merged.
Change subject: core:Use %d instead %i for String format (#843099)
......................................................................
core:Use %d instead %i for String format (#843099)
Fix UnknownFormatConversionException by changing %i in string format to
use %d.
https://bugzilla.redhat.com/show_bug.cgi?id=843099
Signed-off-by: Maor Lipchuk <mlipchuk(a)redhat.com>
Change-Id: I32475369cbfd510632d4aa3c97126ebeebbbd29b
---
M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/ReconstructMasterVDSCommandParameters.java
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Maor Lipchuk: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6986
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I32475369cbfd510632d4aa3c97126ebeebbbd29b
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>
Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: no error messages after jboss restart (#842112)
by gchaplik＠redhat.com
Gilad Chaplik has submitted this change and it was merged.
Change subject: webadmin: no error messages after jboss restart (#842112)
......................................................................
webadmin: no error messages after jboss restart (#842112)
https://bugzilla.redhat.com/842112
when the application logs out we need to clean the error messages, in
order the application to show error messages in the next login.
Change-Id: I76d828aad967c7fa9f3f1b1014ba035fd9ed1e58
Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com>
---
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/presenter/popup/ErrorPopupPresenterWidget.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/BaseApplicationInit.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/system/ErrorPopupManager.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/FrontendFailureEventListener.java
M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/uicommon/model/CommonModelManager.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/system/ApplicationInit.java
6 files changed, 19 insertions(+), 3 deletions(-)
Approvals:
Gilad Chaplik: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6912
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I76d828aad967c7fa9f3f1b1014ba035fd9ed1e58
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: webadmin: [SetupNetworks] unmanaged networks (#820504)
by derez＠redhat.com
Daniel Erez has submitted this change and it was merged.
Change subject: webadmin: [SetupNetworks] unmanaged networks (#820504)
......................................................................
webadmin: [SetupNetworks] unmanaged networks (#820504)
https://bugzilla.redhat.com/820504
Add unmanaged networks to SetupNetworks gui
- Network panel- remove instead of edit
- Right click menu- contains just detach
- Tooltip- just tell the network is unmanaged.
Other values are not displayed.
Change-Id: I1ea44aaa1487cea4bc1c842a222dd708ff855315
Signed-off-by: Alona Kaplan <alkaplan(a)redhat.com>
---
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/HostSetupNetworksModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/LogicalNetworkModel.java
M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/network/NetworkOperationFactory.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationConstants.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/ApplicationResources.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/ItemInfoPopup.java
M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/popup/host/panels/NetworkPanel.java
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/but_erase_net_hover.png
A frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/but_erase_net_mousedown.png
D frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/webadmin/images/network/empty.png
10 files changed, 85 insertions(+), 61 deletions(-)
Approvals:
Alona Kaplan: Verified
Daniel Erez: Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6973
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I1ea44aaa1487cea4bc1c842a222dd708ff855315
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>
Gerrit-Reviewer: Livnat Peer <lpeer(a)redhat.com>
12 years, 4 months
Change in ovirt-engine[master]: core: Clean up engineeringcryptutils' test logging
by yzaslavs＠redhat.com
Yair Zaslavsky has submitted this change and it was merged.
Change subject: core: Clean up engineeringcryptutils' test logging
......................................................................
core: Clean up engineeringcryptutils' test logging
Fixed log4j to reference org.apache.log4j.helpers.OnlyOnceErrorHandler
instead of org.jboss.logging.util.OnlyOnceErrorHandler to avoid
getting a NoClassDefError in unit test execution.
Change-Id: Idaff7477ee94d76f281c4dd75cb701ae2daf45bf
Signed-off-by: Allon Mureinik <amureini(a)redhat.com>
---
M backend/manager/modules/engineencryptutils/src/test/resources/log4j.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Yair Zaslavsky: Verified; Looks good to me, approved
--
To view, visit http://gerrit.ovirt.org/6683
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idaff7477ee94d76f281c4dd75cb701ae2daf45bf
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com>
Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>
12 years, 4 months