January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Removing validateStorageServerConnection - storage p...
by mkublin＠redhat.com 28 Jan '13

28 Jan '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing validateStorageServerConnection - storage part ...................................................................... engine: Removing validateStorageServerConnection - storage part The following patch is removing uses of validateStorageServerConnection. The API is depricated and usefull, espicially when it called from canDoaction of internal commands Benefit, reduced XML RPC call at most of the storage operations, reduced useless logic Change-Id: I7b3bc2491943a6daa21228e37169c83f32865984 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddStorageServerConnectionCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/BaseFsStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectStorageToVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/FCPStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ISCSIStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/IStorageHelper.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/StorageHelperBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/VDSCommandType.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ValidateStorageServerConnectionVDSCommand.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 15 files changed, 1 insertion(+), 139 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11416 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7b3bc2491943a6daa21228e37169c83f32865984 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Sharad Mishra <snmishra(a)linux.vnet.ibm.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: updated taskcleaner to run from external python code
by juan.hernandez＠redhat.com 28 Jan '13

28 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: core: updated taskcleaner to run from external python code ...................................................................... core: updated taskcleaner to run from external python code Change-Id: Ibb894849bc732640719216fb0c308d410aa17a81 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M backend/manager/dbscripts/taskcleaner.sh 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11408 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb894849bc732640719216fb0c308d410aa17a81 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: creating a version file for fetching product vers...
by juan.hernandez＠redhat.com 28 Jan '13

28 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: creating a version file for fetching product version ...................................................................... packaging: creating a version file for fetching product version Change-Id: I479668e0d82007d283743f732067d58c73d1ea15 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M Makefile M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-setup.py M packaging/fedora/setup/post_upgrade.py M packaging/fedora/spec/ovirt-engine.spec.in 6 files changed, 17 insertions(+), 6 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11383 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I479668e0d82007d283743f732067d58c73d1ea15 Gerrit-PatchSet: 9 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Ohad Basan <obasan(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: checking SELINUX status during ports redirection
by juan.hernandez＠redhat.com 28 Jan '13

28 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: checking SELINUX status during ports redirection ...................................................................... packaging: checking SELINUX status during ports redirection Change-Id: I2e9f4c1abc8c58a1b1556ba56f4cc0acfac91050 Bug-Url: https://bugzilla.redhat.com/893562 Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/engine_validators.py M packaging/fedora/setup/output_messages.py 3 files changed, 19 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11345 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2e9f4c1abc8c58a1b1556ba56f4cc0acfac91050 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com> Gerrit-Reviewer: Sandro Bonazzola <sbonazzo(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated all utilities to use backup.sh instead of...
by juan.hernandez＠redhat.com 28 Jan '13

28 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated all utilities to use backup.sh instead of pg_dump ...................................................................... packaging: Updated all utilities to use backup.sh instead of pg_dump * Previously, the setup utilities used pg_dump command to backup the database. The more appropriate way is to use the backup.sh utility, that runs the dump of the database in a more correct and way. This also has the added benifit in that changes in DB mechanisms or parameters for dumping the data would be handled by the external script, and changes to the setup code would not be required. Bug-Url: https://bugzilla.redhat.com/866964 Change-Id: I011bc64d989cfba602977fd3f9522ea2c329aedc Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/basedefs.py M packaging/fedora/setup/common_utils.py M packaging/fedora/setup/engine-cleanup.py M packaging/fedora/setup/engine-upgrade.py 4 files changed, 35 insertions(+), 54 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10548 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I011bc64d989cfba602977fd3f9522ea2c329aedc Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: improve messages of create/delete snapshot
by tnisan＠redhat.com 27 Jan '13

27 Jan '13

Tal Nisan has submitted this change and it was merged. Change subject: core: improve messages of create/delete snapshot ...................................................................... core: improve messages of create/delete snapshot Improve text of event log messages for creation and deletion of snapshots (and live snapshots). Change-Id: I29bc8638dc8506bb09efd00bb6f96b1ba8a0a825 Bug-Url: https://bugzilla.redhat.com/896418 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/dal/src/main/resources/bundles/AuditLogMessages.properties 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Tal Nisan: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11439 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I29bc8638dc8506bb09efd00bb6f96b1ba8a0a825 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: InternalMigrateVmCommand cleanup
by ofrenkel＠redhat.com 27 Jan '13

27 Jan '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: InternalMigrateVmCommand cleanup ...................................................................... core: InternalMigrateVmCommand cleanup Replaced convertInternalMigrateParamsToMigrateParams method in InternalMigrateVmCommand with a constructor in MigrateVmParameters that gets as an input InternalMigrateVmParameters instance. InternalMigrateVmParameters class was moved to org.ovirt.engine.core.common.action package so that it will be accessible from MigrateVmParameters class (and that package it should be in anyway as all the parameters class resides there) On the way two minor changes were made in order to support later patches: 1. a constructor that also gets the parent command was added to InternalMigrateVmParameters 2. the correlation-id is also copied from the InternalMigrateVmParameters on the newly added constructor in MigrateVmParameters Change-Id: Idfeb4966b6ae0a570904861a5e6b1768b0c6d47f Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InternalMigrateVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java R backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/InternalMigrateVmParameters.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/MigrateVmParameters.java 4 files changed, 22 insertions(+), 21 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/11368 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idfeb4966b6ae0a570904861a5e6b1768b0c6d47f Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: revert change If615a9d9
by ofrenkel＠redhat.com 27 Jan '13

27 Jan '13

Omer Frenkel has submitted this change and it was merged. Change subject: core: revert change If615a9d9 ...................................................................... core: revert change If615a9d9 In patch If615a9d9 the execution context of SetNonOperationalVdsCommand changed to async if it triggered migrations. This patch change its execution context back to sync. migrations that will be triggered from SetNonOperationalCommand will be executed as different jobs (it will be pushed in a different patch), thus resolving bug 888199 without making the set-non-operational command to be async (this command shouldn't be async, as the host become non-operational right after the sync part, independently from the triggered migrations) Change-Id: I91eb9e84d0ff4ce6a0c8390dc973c3f8822a0c8c Signed-off-by: Arik Hadas <ahadas(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SetNonOperationalVdsCommand.java 1 file changed, 0 insertions(+), 7 deletions(-) Approvals: Omer Frenkel: Looks good to me, approved Arik Hadas: Verified -- To view, visit http://gerrit.ovirt.org/11369 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I91eb9e84d0ff4ce6a0c8390dc973c3f8822a0c8c Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Arik Hadas <ahadas(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: storage domain validation refactoring
by amureini＠redhat.com 27 Jan '13

27 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: storage domain validation refactoring ...................................................................... core: storage domain validation refactoring Refactored StorageDoaminValidator to return a ValidationResult in all relevant methods as validators ought to, instead of the old-fashioned pattern of returning a boolean and accepting a List<String> parameter for the error messages. Change-Id: I64734303de8c9cfaaca4fba6bfeeccc93e18c9a6 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmAndCloneImageCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ExportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImportVmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmTemplateFromImportExportCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/VmTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/validator/StorageDomainValidator.java A backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/StorageDomainValidatorTest.java 15 files changed, 88 insertions(+), 48 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11415 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I64734303de8c9cfaaca4fba6bfeeccc93e18c9a6 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImagesHandler.checkDiskImages with multi-SDs
by amureini＠redhat.com 27 Jan '13

27 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImagesHandler.checkDiskImages with multi-SDs ...................................................................... core: ImagesHandler.checkDiskImages with multi-SDs In the current implementation, checkDiskImages takes the first storage domain for each disk it checks. This behaviour is obviously problematic for images which exist on multiple storage domains, as the check could succeed or fail based solely on the order the domains appear in the disk's data member. This patch changes the logic to accumulate ALL of the domains of all the images, for a more meaningful behaviour. Looking forward, this change will enable using checkDiskImages for template disks correctly, even though all the current use cases are VM usecases, which implies a single domain per disk. Thus, this patch preserves the current behaviour, but allows additional future usecases. Change-Id: I61b729bdcbd3001d371fb58a6358172b07be94f4 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11414 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I61b729bdcbd3001d371fb58a6358172b07be94f4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0