January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: Improved host life cycle
by mkublin＠redhat.com 27 Jan '13

27 Jan '13

Michael Kublin has submitted this change and it was merged. Change subject: engine: Improved host life cycle ...................................................................... engine: Improved host life cycle The following patch is introducing a folloing improvements: 1. By adding HostStoragePoolParametersBase class, it is possible to pass vds and storage pool to command and no need to perform additional query at command Benefit, reduced two queries at ConnectHostToStoragePoolServersCommand and at DisconnectHostFromStoragePoolServersCommand 2. From now DisconnectHostFromStoragePoolServersCommand running with out openning transaction, no need , DB is not updated so no need for global transaction. Benefit - less long transaction during moving host to maintainance 3. Removed canDoAction of DisconnectHostFromStoragePoolServersCommand, usually will be true, reason it is useless. Benefit - less useless code, less useless checks Change-Id: I14b07f4568a78e4da359c1ac3bfd8417550574d7 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InitVdsOnUpCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceVdsCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/DisconnectHostFromStoragePoolServersCommand.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/HostStoragePoolParametersBase.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/action/StoragePoolParametersBase.java 6 files changed, 71 insertions(+), 40 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11308 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I14b07f4568a78e4da359c1ac3bfd8417550574d7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: expand all expands selected node
by derez＠redhat.com 27 Jan '13

27 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: expand all expands selected node ...................................................................... webadmin: expand all expands selected node - Added logic to find the selected node and pass that into the node expansion method. - Added logic to find the selected node and pass that into the node collapse method. - Fixed the node collapse to properly collapse all sub nodes AND itself. Change-Id: I110efdff51be6e5545a1de304bdce657ec5cda88 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=879291 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java 1 file changed, 54 insertions(+), 20 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10913 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I110efdff51be6e5545a1de304bdce657ec5cda88 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: live migration for disks based on template
by derez＠redhat.com 27 Jan '13

27 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: core: live migration for disks based on template ...................................................................... core: live migration for disks based on template Fetch DiskImage using get() instead of getAncestor() (getAncestor() returns template's disk when applicable) Change-Id: I42747d9d5d7f55e457c4b2f9d05b1c7b02dffb3d Bug-Url: https://bugzilla.redhat.com/896439 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java 2 files changed, 26 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11299 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42747d9d5d7f55e457c4b2f9d05b1c7b02dffb3d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: LSM - lock image on CreateImagePlaceholder phase
by derez＠redhat.com 27 Jan '13

27 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: core: LSM - lock image on CreateImagePlaceholder phase ...................................................................... core: LSM - lock image on CreateImagePlaceholder phase Lock image on CreateImagePlaceholder phase rather than on LiveSnapshot endSuccessfully(). (prevents locked disks when shutting down the VM during live snapshot). Change-Id: I899e55c995a96f68023e2ad7b31daac57d1e8dbb Bug-Url: https://bugzilla.redhat.com/896445 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/CreateImagePlaceholderTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveSnapshotTaskHandler.java 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11311 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I899e55c995a96f68023e2ad7b31daac57d1e8dbb Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>

1 0

Change in samples-portals[master]: java: support for oVirt SDK
by shavivi＠redhat.com 27 Jan '13

27 Jan '13

Shahar Havivi has submitted this change and it was merged. Change subject: java: support for oVirt SDK ...................................................................... java: support for oVirt SDK Change the connection with oVirt engine to work with oVirt SDK and not via direct RESTful calls Change-Id: Ieab9134ab61e136a3eb1ccc85bdef7aac728a2f7 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M java/javauserportal/README M java/javauserportal/pom.xml D java/javauserportal/src/main/java/org/ovirt/samples/portals/javauserportal/ActionRestCommand.java D java/javauserportal/src/main/java/org/ovirt/samples/portals/javauserportal/LoginRestCommand.java M java/javauserportal/src/main/java/org/ovirt/samples/portals/javauserportal/OVirtProperties.java A java/javauserportal/src/main/java/org/ovirt/samples/portals/javauserportal/OVirtSDKWrapper.java D java/javauserportal/src/main/java/org/ovirt/samples/portals/javauserportal/RestClient.java D java/javauserportal/src/main/java/org/ovirt/samples/portals/javauserportal/RestCommand.java D java/javauserportal/src/main/java/org/ovirt/samples/portals/javauserportal/UserVmsRestCommand.java D java/javauserportal/src/main/java/org/ovirt/samples/portals/javauserportal/VmByIdRestCommand.java D java/javauserportal/src/main/java/org/ovirt/samples/portals/javauserportal/ovirt.properties A java/javauserportal/src/main/resources/ovirt.properties M java/javauserportal/src/main/webapp/action.jsp M java/javauserportal/src/main/webapp/index.jsp A java/javauserportal/src/main/webapp/spice.jsp M java/javauserportal/src/main/webapp/uservms.jsp 16 files changed, 230 insertions(+), 467 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved Oved Ourfali: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11092 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ieab9134ab61e136a3eb1ccc85bdef7aac728a2f7 Gerrit-PatchSet: 6 Gerrit-Project: samples-portals Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : Add the option to set custom ticket to a VM(#88684...
by mpastern＠redhat.com 27 Jan '13

27 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : Add the option to set custom ticket to a VM(#886840) ...................................................................... restapi : Add the option to set custom ticket to a VM(#886840) Let the user set a custom ticket for VM. If custom ticket is provided by the user the api/backend must use the ticket provided by the use and not generate a new ticket. Change-Id: I06b48b5ad300cb607e62f461ca7a07c16c59bf4a Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=886840 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Michael Pasternak: Looks good to me, approved Ravi Nori: Verified -- To view, visit http://gerrit.ovirt.org/11398 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06b48b5ad300cb607e62f461ca7a07c16c59bf4a Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: core: better detection of otopi executable
by Alon Bar-Lev 26 Jan '13

26 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: core: better detection of otopi executable ...................................................................... core: better detection of otopi executable 1. Allow override of sources location. 2. Look for otopi at same location as script. Change-Id: Ife228161053fda9d8dcc3aa1fbcfcf0a1c053e19 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/bin/ovirt-host-deploy.in 1 file changed, 9 insertions(+), 5 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11403 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ife228161053fda9d8dcc3aa1fbcfcf0a1c053e19 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-engine[master]: spelling: s/mster/master/
by amureini＠redhat.com 25 Jan '13

25 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: spelling: s/mster/master/ ...................................................................... spelling: s/mster/master/ Change-Id: Idccb43477ed1fe78fbba833409430d561203e019 Signed-off-by: Itamar Heim <iheim(a)redhat.com> --- M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/vdscommands/RefreshStoragePoolVDSCommandParameters.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11361 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idccb43477ed1fe78fbba833409430d561203e019 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Updated spec to use sdk version that supports ssl...
by juan.hernandez＠redhat.com 25 Jan '13

25 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Updated spec to use sdk version that supports ssl. ...................................................................... packaging: Updated spec to use sdk version that supports ssl. Change-Id: I394e69453fd38c5fd9fdf86c59bbb30873bba08c Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/spec/ovirt-engine.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/8602 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I394e69453fd38c5fd9fdf86c59bbb30873bba08c Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: packaging: Starting ssh before adding host in AIO
by juan.hernandez＠redhat.com 25 Jan '13

25 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: Starting ssh before adding host in AIO ...................................................................... packaging: Starting ssh before adding host in AIO Bug-Url: https://bugzilla.redhat.com/896472 Change-Id: I84cbacec81d08cc72d8951887b5ad44c3c2cb4fa Signed-off-by: Alex Lourie <alourie(a)redhat.com> --- M packaging/fedora/setup/plugins/all_in_one_100.py M packaging/fedora/spec/ovirt-engine.spec.in 2 files changed, 8 insertions(+), 1 deletion(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11155 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I84cbacec81d08cc72d8951887b5ad44c3c2cb4fa Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Itamar Heim <iheim(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com> Gerrit-Reviewer: Ofer Schreiber <oschreib(a)redhat.com>

1 0