January 2013 - Engine-commits - Ovirt List Archives

Change in ovirt-engine[master]: engine: AddVdsSpmIdCommand throw exception when...

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: engine: AddVdsSpmIdCommand throw exception when... ...................................................................... engine: AddVdsSpmIdCommand throw exception when... AddVdsSpmIdCommand throw exception when trying to edit cluster and we have more than one host attached to these cluster. The bug is regression caused by commit 4b9a4cfaee613e3254735f06df339840ebc8c4fc. The problem is the following: UpdateVdsGroupCommand running inside transaction. canDoAction() of AddVdsSpmIdCommand is running outside those transaction. In canDoAction() was retrieved a list of already existed spm_ids. execute() of AddVdsSpmIdCommand is running inside same transaction as UpdateVdsGroupCommand. As a result a second AddVdsSpmIdCommand is retrieving a list of spm_ids but with out id inserted by first AddVdsSpmIdCommand, because of it is still not committed and canDoAction() is running outside transaction. Solution: move appropriate logic to execute(). Also for internal command there are no meaning to put some checks inside canDoAction(), the internal command is not logged and a result of canDoAction() will not be passed to client. Change-Id: I7f8aa6b6cb3dfc1508a99c53553afc2e15009b68 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVdsSpmIdCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/UpdateVdsGroupCommand.java 2 files changed, 27 insertions(+), 26 deletions(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11271 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7f8aa6b6cb3dfc1508a99c53553afc2e15009b68 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Omer Frenkel <ofrenkel(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix vds_group_sp.sql

by emesika＠redhat.com

Eli Mesika has submitted this change and it was merged. Change subject: core: Fix vds_group_sp.sql ...................................................................... core: Fix vds_group_sp.sql Fix for Change-Id: I5847d234e396fe8a83017fb25a5139f552e7c61b Table name was not changed in internal SELECT clause. Change-Id: I7d1a191ef1610e80f72c9bb01895e00e6b58503e Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- M backend/manager/dbscripts/vds_groups_sp.sql 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Eli Mesika: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11411 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7d1a191ef1610e80f72c9bb01895e00e6b58503e Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Greg Padgett <gpadgett(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: fix MoveDisksCommandTest - invalidVmStatus

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: fix MoveDisksCommandTest - invalidVmStatus ...................................................................... core: fix MoveDisksCommandTest - invalidVmStatus Change-Id: I5c63551c7848594aa53c7ecf0f15ccf2a920406b Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/MoveDisksCommandTest.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11417 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5c63551c7848594aa53c7ecf0f15ccf2a920406b Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: pom.xml: update findbugs mvn plugin version to latest 2.5.2

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: pom.xml: update findbugs mvn plugin version to latest 2.5.2 ...................................................................... pom.xml: update findbugs mvn plugin version to latest 2.5.2 Change-Id: Ice0307ccc05ea78d6eab60408a22d538266cb0bf Signed-off-by: Eyal Edri <eedri(a)redhat.com> --- M pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10301 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ice0307ccc05ea78d6eab60408a22d538266cb0bf Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eyal Edri <eedri(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: improve logs in VdsManager

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: improve logs in VdsManager ...................................................................... core: improve logs in VdsManager Fix mispellings, remove "resource manager" from logging statements since it's a wrong class name, rephrase log statements to be more clear, remove isDebugEnabled around logException (which is logged as error) Change-Id: I815f0c7bdadc25be5fa3f0829114f1d7f2a2dddd Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/VdsManager.java 1 file changed, 18 insertions(+), 25 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11270 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I815f0c7bdadc25be5fa3f0829114f1d7f2a2dddd Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Roy Golan <rgolan(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core, ui: allow disk live migration when VM is Paused

by derez＠redhat.com

Daniel Erez has submitted this change and it was merged. Change subject: core,ui: allow disk live migration when VM is Paused ...................................................................... core,ui: allow disk live migration when VM is Paused Allow live migrating a disk when the VM is in Paused status. I.e. on each step of LSM process, verify that the VM is in Up or Paused status. Change-Id: I37926ba2ae87c334e6f2d17b65b91290fe2c3d39 Bug-Url: https://bugzilla.redhat.com/894035 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AbstractSPMAsyncTaskHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveDisksCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateDiskCommand.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/VMStatus.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmDiskListModel.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 9 files changed, 17 insertions(+), 9 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11202 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I37926ba2ae87c334e6f2d17b65b91290fe2c3d39 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Make MockConfigRule work with Versions

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Make MockConfigRule work with Versions ...................................................................... core: Make MockConfigRule work with Versions Fixed MockConfigRule to work with the Version class so it provides a meaningful interface instead of just passing any String which is just implementation detail in the Config class. This patch contains the following: * Fixing MockConfigRule's interface * Adjusting AddVmCommandTest, GetConfigurationValueQueryTest and GetDeviceListQueryTest to pass the Version they use instead of its text value. * Fixing VmNicValidatorTest to send the Version used in the validator to MockConfigRule. Change-Id: I9f407bc1af73e76e223a8cbb1c67009f7dd97d61 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/AddVmCommandTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetConfigurationValueQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/storage/GetDeviceListQueryTest.java M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/validator/VmNicValidatorTest.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MockConfigRule.java 5 files changed, 20 insertions(+), 12 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11353 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9f407bc1af73e76e223a8cbb1c67009f7dd97d61 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Fix GetAllVmPoolsAttachedToUserQueryTest

by amureini＠redhat.com

Allon Mureinik has submitted this change and it was merged. Change subject: core: Fix GetAllVmPoolsAttachedToUserQueryTest ...................................................................... core: Fix GetAllVmPoolsAttachedToUserQueryTest GetAllVmPoolsAttachedToUserQueryTest was broken by change-id I59346bc9f1cf6d948c4401ddbd7bb365c67b5b05 which changed the query from a user query to an admin query. This patch removes the parts of the test that are only relevant to user queries (i.e., permission filtering) so that it will only check the expected behavior. Change-Id: I5883d47c4ca074c83913449ecd80972139a7dcf2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/GetAllVmPoolsAttachedToUserQueryTest.java 1 file changed, 6 insertions(+), 27 deletions(-) Approvals: Allon Mureinik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11413 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I5883d47c4ca074c83913449ecd80972139a7dcf2 Gerrit-PatchSet: 3 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: core: Ignore maven-ear-plugin in Eclipse

by asaf＠redhat.com

Asaf Shakarchi has submitted this change and it was merged. Change subject: core: Ignore maven-ear-plugin in Eclipse ...................................................................... core: Ignore maven-ear-plugin in Eclipse Eclipse doesn't have support for most of the parameters of the maven-ear-plugin, so in order to import the project without errors we need to ignore the execution of the generate-application-xml goal. Change-Id: I196ae0fd10615e8576a6fa3abc3dfcbc2a530e86 Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M ear/pom.xml 1 file changed, 35 insertions(+), 0 deletions(-) Approvals: Asaf Shakarchi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11258 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I196ae0fd10615e8576a6fa3abc3dfcbc2a530e86 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

11 years, 11 months

1
0
0 / 0

Change in ovirt-engine[master]: engine: Removing canDoaction from ConnectHostToStoragePoolSe...

by mkublin＠redhat.com

Michael Kublin has submitted this change and it was merged. Change subject: engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand ...................................................................... engine: Removing canDoaction from ConnectHostToStoragePoolServersCommand The following change is removes canDoAction from ConnectHostToStoragePoolServersCommand. The purpose of canDoAction was to validate storage connections at VDSM, the following API is depreacted and not useful at vdsm side, and doesn't provide any benefit to engine, also the following command is internal so no reason to perfrom additional xml rpc call in order to validate storage server connection. Benefit, reduced number of XML RPC calls via InitVdsOnUp, meaning vds should be moved to status UP much faster. Additional benefit, less code, less bugs Change-Id: I0124e47b2f1194e5de9b40216cd285c47b1b6f94 Signed-off-by: Michael Kublin <mkublin(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/ConnectHostToStoragePoolServersCommand.java 1 file changed, 8 insertions(+), 42 deletions(-) Approvals: Michael Kublin: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11309 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0124e47b2f1194e5de9b40216cd285c47b1b6f94 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

11 years, 11 months

1
0
0 / 0

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

Engine-commits January 2013