January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: packaging: End list of dependencies in $(NULL)
by juan.hernandez＠redhat.com 15 Jan '13

15 Jan '13

Juan Hernandez has submitted this change and it was merged. Change subject: packaging: End list of dependencies in $(NULL) ...................................................................... packaging: End list of dependencies in $(NULL) To simplify patching in the future make sure that lists have one element per line and that they end in a line containing only $(NULL). Change-Id: Ic779d18c95de04c65eddd95e3fad8f36c8dc779d Signed-off-by: Juan Hernandez <juan.hernandez(a)redhat.com> --- M Makefile 1 file changed, 10 insertions(+), 5 deletions(-) Approvals: Juan Hernandez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10992 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic779d18c95de04c65eddd95e3fad8f36c8dc779d Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl> Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImagesHandler cleanup: Generic warnings
by amureini＠redhat.com 15 Jan '13

15 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImagesHandler cleanup: Generic warnings ...................................................................... core: ImagesHandler cleanup: Generic warnings Cleaned up warnings about using raw types in PerformImagesChecks passing a Collection that's intended as a Collection of Disks. Change-Id: Iad9a2f228087e697fd718d8ecfce9b79b0374076 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 2 files changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/10999 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iad9a2f228087e697fd718d8ecfce9b79b0374076 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImagesHandler cleanup: Logged empty catch
by amureini＠redhat.com 15 Jan '13

15 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImagesHandler cleanup: Logged empty catch ...................................................................... core: ImagesHandler cleanup: Logged empty catch Added a log message to an empty catch block. Change-Id: Ie600ed85f38f7de1b36e461517183851185bc9c2 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/10998 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie600ed85f38f7de1b36e461517183851185bc9c2 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImagesHandler cleanup: unwrap else clauses
by amureini＠redhat.com 15 Jan '13

15 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImagesHandler cleanup: unwrap else clauses ...................................................................... core: ImagesHandler cleanup: unwrap else clauses Unwrapped useless else clauses where the if clause does not terminate normally (breaks, returns, etc.). Change-Id: I0d1a9ad5c01471c217973cd0a6907023564d841d Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/10997 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0d1a9ad5c01471c217973cd0a6907023564d841d Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImagesHandler cleanup: remove useless const
by amureini＠redhat.com 15 Jan '13

15 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImagesHandler cleanup: remove useless const ...................................................................... core: ImagesHandler cleanup: remove useless const Removed the useless BlankImageTemplateId constant which is just another copy of Guid.Empty. Change-Id: If0794165fbebf1226134259fcb67bc0d753f75ee Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CreateImageTemplateCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveOrCopyDiskCommand.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/lsm/LiveMigrateVmDisksCommand.java 4 files changed, 4 insertions(+), 5 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/10996 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: If0794165fbebf1226134259fcb67bc0d753f75ee Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: ImagesHandler cleanup: make log private
by amureini＠redhat.com 15 Jan '13

15 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: ImagesHandler cleanup: make log private ...................................................................... core: ImagesHandler cleanup: make log private Made the log private, as per proper java conventions. Change-Id: Iff3d828b0d102fa74eeb6bd92e226cda63365f68 Signed-off-by: Allon Mureinik <amureini(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/ImagesHandler.java 1 file changed, 3 insertions(+), 3 deletions(-) Approvals: Tal Nisan: Looks good to me, approved Allon Mureinik: Verified -- To view, visit http://gerrit.ovirt.org/10995 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iff3d828b0d102fa74eeb6bd92e226cda63365f68 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com> Gerrit-Reviewer: Tal Nisan <tnisan(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: post ovirt-host-deploy-1.0.0_beta
by Alon Bar-Lev 15 Jan '13

15 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: post ovirt-host-deploy-1.0.0_beta ...................................................................... packaging: post ovirt-host-deploy-1.0.0_beta Change-Id: Ifb55f8e8e77b6fe01601d3f44ed87c4b295a877c Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M configure.ac 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11009 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifb55f8e8e77b6fe01601d3f44ed87c4b295a877c Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: ovirt-host-deploy-1.0.0_beta
by Alon Bar-Lev 15 Jan '13

15 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: ovirt-host-deploy-1.0.0_beta ...................................................................... packaging: ovirt-host-deploy-1.0.0_beta Change-Id: Ia61bf5eae69ae561d7f9c50b5c0ffb6b2ab315d3 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M configure.ac M ovirt-host-deploy.spec.in 2 files changed, 3 insertions(+), 3 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11008 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ia61bf5eae69ae561d7f9c50b5c0ffb6b2ab315d3 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: bump master to 1.0.0
by Alon Bar-Lev 15 Jan '13

15 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: bump master to 1.0.0 ...................................................................... packaging: bump master to 1.0.0 Change-Id: I173f283de21ee348c7d3dfd8e058587c2073893b Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ChangeLog M configure.ac 2 files changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11007 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I173f283de21ee348c7d3dfd8e058587c2073893b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0

Change in ovirt-host-deploy[master]: packaging: setup tarball publish location
by Alon Bar-Lev 15 Jan '13

15 Jan '13

Alon Bar-Lev has submitted this change and it was merged. Change subject: packaging: setup tarball publish location ...................................................................... packaging: setup tarball publish location Change-Id: I8c2e7f04b40fe828ca6d6ca03e1ca6e040bf30c0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-host-deploy.spec.in 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/11006 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8c2e7f04b40fe828ca6d6ca03e1ca6e040bf30c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-host-deploy Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>

1 0