January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: userportal: No null to display
by derez＠redhat.com 13 Jan '13

13 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: userportal: No null to display ...................................................................... userportal: No null to display - Fixed missing entity title for UserPortalListModel. Change-Id: I4bea19ac57ede41a8da8e3c3611028f9d15ec2a7 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=894306 Signed-off-by: Alexander Wels <awels(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/userportal/UserPortalListModel.java 1 file changed, 1 insertion(+), 0 deletions(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10909 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4bea19ac57ede41a8da8e3c3611028f9d15ec2a7 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Alexander Wels <awels(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Vojtech Szocs <vszocs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: fixing buttons text misalignment
by derez＠redhat.com 13 Jan '13

13 Jan '13

Daniel Erez has submitted this change and it was merged. Change subject: webadmin: fixing buttons text misalignment ...................................................................... webadmin: fixing buttons text misalignment Removed redundant 'margin-right:3px' from dialogButton template. * Causing an horizontal misalignment in text position on OK/Cancel/Close buttons. I.e. text is not aligned to center. * Checked on FF/Chorme/IE. Change-Id: I4a00915b9521e5c2d14dca97e57e8495e4ae6f90 Signed-off-by: Daniel Erez <derez(a)redhat.com> --- M frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/CommonApplicationTemplates.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Daniel Erez: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10826 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4a00915b9521e5c2d14dca97e57e8495e4ae6f90 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Tomas Jelinek <tjelinek(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: expand the tree to the second level
by shavivi＠redhat.com 13 Jan '13

13 Jan '13

Shahar Havivi has submitted this change and it was merged. Change subject: webadmin: expand the tree to the second level ...................................................................... webadmin: expand the tree to the second level Expanding system tree to Storage-Clusters level on load and refresh. Change-Id: I3114271cab914979c0a93b9d4697b8ba6669197a bug-url: https://bugzilla.redhat.com/838457 Signed-off-by: Shahar Havivi <shavivi(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java M frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/widget/tree/SystemTree.java 2 files changed, 40 insertions(+), 38 deletions(-) Approvals: Shahar Havivi: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10427 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3114271cab914979c0a93b9d4697b8ba6669197a Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <shavivi(a)redhat.com> Gerrit-Reviewer: Alona Kaplan <alkaplan(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core+ui: Add host notifications
by dfediuck＠redhat.com 13 Jan '13

13 Jan '13

Doron Fediuck has submitted this change and it was merged. Change subject: core+ui: Add host notifications ...................................................................... core+ui: Add host notifications This patch adds 3 new events to the notification service - storage domain became inactive - host became non-operational - Engine failed to elect an SPM for a DC Change-Id: Ie11d3d4e2c5e8b9a8096d742bc35cab82ff27bd0 Signed-off-by: Ofri Masad <omasad(a)redhat.com> --- A backend/manager/dbscripts/upgrade/03_02_0310_add_vds_event_notifications.sql M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/VdcEventNotificationUtils.java M frontend/webadmin/modules/uicompat/src/main/java/org/ovirt/engine/ui/uicompat/LocalizedEnums.java M frontend/webadmin/modules/uicompat/src/main/resources/org/ovirt/engine/ui/uicompat/LocalizedEnums.properties 4 files changed, 27 insertions(+), 0 deletions(-) Approvals: Doron Fediuck: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10808 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie11d3d4e2c5e8b9a8096d742bc35cab82ff27bd0 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: ofri masad <omasad(a)redhat.com> Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com> Gerrit-Reviewer: Eli Mesika <emesika(a)redhat.com> Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com> Gerrit-Reviewer: Simon Grinberg <sgrinber(a)redhat.com> Gerrit-Reviewer: ofri masad <omasad(a)redhat.com>

1 0

Change in ovirt-engine[master]: common: move default version out of Config
by gchaplik＠redhat.com 13 Jan '13

13 Jan '13

Gilad Chaplik has submitted this change and it was merged. Change subject: common: move default version out of Config ...................................................................... common: move default version out of Config This way we will be able to codegen the default version. Config.DefaultConfigurationVersion -> ConfigCommon.defaultConfigurationVersion Change-Id: Ibcbf08fd77d61a07c83e1e32f0cd67c40ab4cde0 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/Backend.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValueQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetConfigurationValuesQuery.java M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetDefaultConfigurationVersionQuery.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/Config.java A backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/config/ConfigCommon.java M backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/validation/ConfiguredRangeValidator.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/ConfiguredRangeValidatorTest.java M backend/manager/modules/common/src/test/java/org/ovirt/engine/core/common/utils/MTUValidatorTest.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/DbFacadeUtils.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtils.java M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dal/dbbroker/generic/DBConfigUtilsTest.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ConfigUtilsBase.java M backend/manager/modules/utils/src/test/java/org/ovirt/engine/core/utils/MockConfigRule.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/VdsManagerTest.java M backend/manager/modules/vdsbroker/src/test/java/org/ovirt/engine/core/vdsbroker/vdsbroker/SysprepHandlerTest.java M backend/manager/tools/engine-notifier/engine-notifier-service/src/main/java/org/ovirt/engine/core/notifier/EngineMonitorService.java M frontend/wars/rmw-war/src/main/java/org/ovirt/engine/core/redirect/RedirectServlet.java M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/server/gwt/WebadminDynamicHostingServlet.java 20 files changed, 63 insertions(+), 49 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10263 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibcbf08fd77d61a07c83e1e32f0cd67c40ab4cde0 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: webadmin: remove using Config.DefaultConfigurationVersion
by gchaplik＠redhat.com 13 Jan '13

13 Jan '13

Gilad Chaplik has submitted this change and it was merged. Change subject: webadmin: remove using Config.DefaultConfigurationVersion ...................................................................... webadmin: remove using Config.DefaultConfigurationVersion use AsyncDataProvider.getDefaultConfigurationVersion() instead We want to update default value only in a single component; and Config is a common class. Change-Id: Id935d4d73f6959243723db5a416b4d253cc9b332 Signed-off-by: Gilad Chaplik <gchaplik(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java 2 files changed, 2 insertions(+), 3 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10887 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id935d4d73f6959243723db5a416b4d253cc9b332 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <gchaplik(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Einav Cohen <ecohen(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine[master]: engine: remove Config dependency from frontend
by gchaplik＠redhat.com 13 Jan '13

13 Jan '13

Gilad Chaplik has submitted this change and it was merged. Change subject: engine: remove Config dependency from frontend ...................................................................... engine: remove Config dependency from frontend Fix leftover from I47e6f47 Change-Id: Ie0df1112cf518823a98f020c06bb1100a31496d4 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/dataprovider/AsyncDataProvider.java 1 file changed, 1 insertion(+), 2 deletions(-) Approvals: Gilad Chaplik: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10886 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie0df1112cf518823a98f020c06bb1100a31496d4 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Gilad Chaplik <gchaplik(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: sdk: release 1.0.0.1-1
by mpastern＠redhat.com 13 Jan '13

13 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: sdk: release 1.0.0.1-1 ...................................................................... sdk: release 1.0.0.1-1 Change-Id: Ie075bbb49cce0972bbf99da1abec04ab65e08e91 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10941 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie075bbb49cce0972bbf99da1abec04ab65e08e91 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: Revert "[maven-release-plugin] prepare release 1.0.0.1"
by mpastern＠redhat.com 13 Jan '13

13 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: Revert "[maven-release-plugin] prepare release 1.0.0.1" ...................................................................... Revert "[maven-release-plugin] prepare release 1.0.0.1" This reverts commit 5b679adf711ee66e5b61f48a4a5f5d39c7bea901. Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> Change-Id: I1715e60a1b06ad2baddceaa6c153488e5d58d305 --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 3 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10939 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1715e60a1b06ad2baddceaa6c153488e5d58d305 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-sdk-java[master]: [maven-release-plugin] prepare release 1.0.0.1
by mpastern＠redhat.com 13 Jan '13

13 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: [maven-release-plugin] prepare release 1.0.0.1 ...................................................................... [maven-release-plugin] prepare release 1.0.0.1 Change-Id: I9bbea7aeb13593d934cda5151f8a55b6c0d1b91e Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M ovirt-engine-sdk-java/pom.xml 1 file changed, 2 insertions(+), 3 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10938 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I9bbea7aeb13593d934cda5151f8a55b6c0d1b91e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-sdk-java Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0