January 2013 - Engine-commits - oVirt List Archives

Change in ovirt-engine[master]: engine: pom metainformation
by lhornyak＠redhat.com 14 Jan '13

14 Jan '13

Laszlo Hornyak has submitted this change and it was merged. Change subject: engine: pom metainformation ...................................................................... engine: pom metainformation added some meta-information about the project to the pom file Change-Id: Idafadb82b978d97557b8af3043ff4736b94489b4 Signed-off-by: Laszlo Hornyak <lhornyak(a)redhat.com> --- M pom.xml 1 file changed, 16 insertions(+), 1 deletion(-) Approvals: Laszlo Hornyak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10575 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idafadb82b978d97557b8af3043ff4736b94489b4 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Asaf Shakarchi <asaf(a)redhat.com> Gerrit-Reviewer: Laszlo Hornyak <lhornyak(a)redhat.com> Gerrit-Reviewer: Mike Kolesnik <mkolesni(a)redhat.com> Gerrit-Reviewer: Yair Zaslavsky <yzaslavs(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: Elaborate on maintenance err msg (#862440)
by amureini＠redhat.com 14 Jan '13

14 Jan '13

Allon Mureinik has submitted this change and it was merged. Change subject: core: Elaborate on maintenance err msg (#862440) ...................................................................... core: Elaborate on maintenance err msg (#862440) VDS_CANNOT_MAINTENANCE_VDS_IS_NOT_RESPONDING_AND_IS_SPM raised some questions with users and is now more elaborate, specifically, how to overcome the error and switch to maintenance. Change-Id: Ic5e0e3f85d2f1ff1a94b152d6d739308fb970113 Bug-Url: https://bugzilla.redhat.com/862440 Signed-off-by: Vered Volansky <vvolansk(a)redhat.com> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MaintananceNumberOfVdssCommand.java M backend/manager/modules/dal/src/main/java/org/ovirt/engine/core/dal/VdcBllMessages.java M backend/manager/modules/dal/src/main/resources/bundles/AppErrors.properties M frontend/webadmin/modules/frontend/src/main/java/org/ovirt/engine/ui/frontend/AppErrors.java M frontend/webadmin/modules/userportal-gwtp/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties M frontend/webadmin/modules/webadmin/src/main/resources/org/ovirt/engine/ui/frontend/AppErrors.properties 6 files changed, 23 insertions(+), 11 deletions(-) Approvals: Allon Mureinik: Looks good to me, approved Vered Volansky: Verified -- To view, visit http://gerrit.ovirt.org/10599 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ic5e0e3f85d2f1ff1a94b152d6d739308fb970113 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <vvolansk(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com> Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com> Gerrit-Reviewer: Vered Volansky <vvolansk(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: cleanup: pep8 compliant
by kroberts＠redhat.com 14 Jan '13

14 Jan '13

Keith Robertson has submitted this change and it was merged. Change subject: cleanup: pep8 compliant ...................................................................... cleanup: pep8 compliant Change-Id: Id27d66958e176c1c67cb932cad21fd30258e09ae Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M src/__main__.py 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Alon Bar-Lev: Verified Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10934 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id27d66958e176c1c67cb932cad21fd30258e09ae Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: build: maintainer-clean to not warn if empty lines in .gitig...
by kroberts＠redhat.com 14 Jan '13

14 Jan '13

Keith Robertson has submitted this change and it was merged. Change subject: build: maintainer-clean to not warn if empty lines in .gitignore ...................................................................... build: maintainer-clean to not warn if empty lines in .gitignore Change-Id: I1df905c1b7621f4f726d8d0e0d7d5cdfa1d35a81 Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M Makefile.am 1 file changed, 2 insertions(+), 2 deletions(-) Approvals: Alon Bar-Lev: Verified Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10933 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1df905c1b7621f4f726d8d0e0d7d5cdfa1d35a81 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com>

1 0

Change in ovirt-iso-uploader[master]: build: support rpm package branding
by kroberts＠redhat.com 14 Jan '13

14 Jan '13

Keith Robertson has submitted this change and it was merged. Change subject: build: support rpm package branding ...................................................................... build: support rpm package branding Change-Id: I22ceb99d8cc81188f0fc5e5ec107a38c2009752e Signed-off-by: Alon Bar-Lev <alonbl(a)redhat.com> --- M ovirt-iso-uploader.spec.in 1 file changed, 5 insertions(+), 4 deletions(-) Approvals: Alon Bar-Lev: Verified Alex Lourie: Looks good to me, but someone else must approve Kiril Nesenko: Looks good to me, but someone else must approve Keith Robertson: Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10923 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I22ceb99d8cc81188f0fc5e5ec107a38c2009752e Gerrit-PatchSet: 1 Gerrit-Project: ovirt-iso-uploader Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Alex Lourie <alourie(a)redhat.com> Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com> Gerrit-Reviewer: Keith Robertson <kroberts(a)redhat.com> Gerrit-Reviewer: Kiril Nesenko <knesenko(a)redhat.com> Gerrit-Reviewer: Moran Goldboim <mgoldboi(a)redhat.com>

1 0

Change in ovirt-engine[master]: core: add isTraceEnabled to Log class
by masayag＠redhat.com 13 Jan '13

13 Jan '13

Moti Asayag has submitted this change and it was merged. Change subject: core: add isTraceEnabled to Log class ...................................................................... core: add isTraceEnabled to Log class Add isTraceEnabled to trace methods of Log class for performance Change-Id: I1e55a6964ed317dbe10bf3bd28af8b187edb90e3 Signed-off-by: Alissa Bonas <abonas(a)redhat.com> --- M backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/log/Log.java 1 file changed, 6 insertions(+), 2 deletions(-) Approvals: Moti Asayag: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10873 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1e55a6964ed317dbe10bf3bd28af8b187edb90e3 Gerrit-PatchSet: 4 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Alissa Bonas <abonas(a)redhat.com> Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com> Gerrit-Reviewer: Moti Asayag <masayag(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi: wrong user id in /api/users/<id>/permissions(#89012...
by mpastern＠redhat.com 13 Jan '13

13 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi: wrong user id in /api/users/<id>/permissions(#890124) ...................................................................... restapi: wrong user id in /api/users/<id>/permissions(#890124) The user id returned by /api/users/<id>/permissions shows the everyone id 'eee00000-0000-0000-0000-123456789eee' where it should show the user id. This patch replaces the everyone id with the user id before returning the results. Change-Id: I3d801cb3c4ad788e984c5338a04ac534d4942601 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890124 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendAssignedPermissionsResource.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/AbstractBackendBaseTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendGroupAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendUserAssignedPermissionsResourceTest.java M backend/manager/modules/restapi/types/src/main/java/org/ovirt/engine/api/restapi/types/PermissionMapper.java 6 files changed, 68 insertions(+), 28 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10581 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I3d801cb3c4ad788e984c5338a04ac534d4942601 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine[master]: restapi : error when adding disk with missing parameters(#89...
by mpastern＠redhat.com 13 Jan '13

13 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: restapi : error when adding disk with missing parameters(#890524) ...................................................................... restapi : error when adding disk with missing parameters(#890524) When trying to add disk with missing parameters we get error with superfluous 0: Disk [format, interface] required for invoke0 This patch fixes the error message by returning the right operation name in the message Change-Id: Idc57a93fee99859ba26bcc0bd5b25035358f5734 Bug-Url: https://bugzilla.redhat.com/show_bug.cgi?id=890524 Signed-off-by: Ravi Nori <rnori(a)redhat.com> --- M backend/manager/modules/restapi/jaxrs/src/main/java/org/ovirt/engine/api/restapi/resource/BackendDisksResource.java 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10820 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Idc57a93fee99859ba26bcc0bd5b25035358f5734 Gerrit-PatchSet: 2 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Ravi Nori <rnori(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Ravi Nori <rnori(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: release 3.2.0.9-1
by mpastern＠redhat.com 13 Jan '13

13 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: release 3.2.0.9-1 ...................................................................... cli: release 3.2.0.9-1 Change-Id: Ibb6e7d4176177d87a22cf7506b4253ab5c68a834 Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M Makefile M ovirt-engine-cli.spec.in M setup.py 3 files changed, 8 insertions(+), 2 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10964 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ibb6e7d4176177d87a22cf7506b4253ab5c68a834 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0

Change in ovirt-engine-cli[master]: cli: detailed command syntax in help
by mpastern＠redhat.com 13 Jan '13

13 Jan '13

Michael Pasternak has submitted this change and it was merged. Change subject: cli: detailed command syntax in help ...................................................................... cli: detailed command syntax in help Change-Id: I42c2c4f1d448cfd380ffbb5917167f1813bdfdbc Signed-off-by: Michael Pasternak <mpastern(a)redhat.com> --- M src/ovirtcli/command/action.py M src/ovirtcli/command/add.py M src/ovirtcli/command/connect.py M src/ovirtcli/command/help.py M src/ovirtcli/command/list.py M src/ovirtcli/command/remove.py M src/ovirtcli/command/show.py M src/ovirtcli/command/update.py 8 files changed, 17 insertions(+), 17 deletions(-) Approvals: Michael Pasternak: Verified; Looks good to me, approved -- To view, visit http://gerrit.ovirt.org/10963 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I42c2c4f1d448cfd380ffbb5917167f1813bdfdbc Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine-cli Gerrit-Branch: master Gerrit-Owner: Michael Pasternak <mpastern(a)redhat.com> Gerrit-Reviewer: Michael Pasternak <mpastern(a)redhat.com>

1 0